Bgp apipa changes #8482
Closed
Bgp apipa changes #8482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding swagger Spec for Quota RP API.
* Adding Quota RP swagger API.
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* Updated based on the comments.
* Updating based on the comments from jhendrixMSFT
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* Updating quota request status parameter.
* Making all response for all quotaRequests status response same, for one or collection.
* Adding Filter for quotaRequest by requestSubmitTime.
* Fixing casing of the operationId - QuotaRequest_Status
* Removing unused model and adding initial version of readme.md
* Adding Readme.md File.
* Updated path for quota.json.
* Chaning filename Quota.json to quota.json in readme.ms. Looks like it's
case-sensitive.
* Fixing json.
* Updating based on build errors.
* Updating suppression directive for opeartions.
* Fixing Suppression Directive.
* Fixing List operationId name.
* Update specification/quota/resource-manager/Microsoft.Quota/preview/2019-07-19-preview/quota.json
Co-Authored-By: Nick Schonning <nschonni@gmail.com>
* 1. Updated the _list_ as suggested in the build.
2. Removed the 4XX responses.
* Adding example file.
* 1.Adding providerId in the parameter List.
* 1. Changed the namesace to Microsoft.Capacity. Work with Capacity RP Team (Reservation) to share the namespace.
2. Updated the API to Get and Put pair. Use the same model for Get and Put as suggested.
Todo:
1. Once Apis are finalized add samples for each api.
* 1. Fixing spelling.
2. Updateing the Put datamodel to match Get data model.
* rename QuotaRequests_list_Status - QuotaRequests_listStatus.
There was a warning for QuotaRequests_list_Status.
* 1. Updated API.
2. Added example for Put /serviceLimits.
3. Updated Get example - /serviceLimits.
* 1. Adding examples for /quotaRequests/{id}
2. Adding examples for /quotaRequests
* 1. Formatting changes.
2. Fixing example.
* 1. Removing nextLink from get /serviceLimits, as the RPs doesn't support nextLink for /usages.
* 1. Moving the examples, next to the operationId.
2. Making the arrary "value" instead of quotaRequests.
* 1. Changing quotaRequests to value.
* Fixing example filed name to match the model.
* 1. Fixing example for Put request.
2. Supressing warning PageableOperation or Get /serviceLimits, as all the RPs /usages api doesn't support pagable operation.
* Fixing readme.md
* 1. Removing pageableOperation Suppression.
2. Removing readonly roperties from put parameters.
* 1. Changing quotaRequests to value to address - warning PutRequestResponseScheme.
2. Suppressing RequiredPropertiesMissingInResourceModel. The quotaRequest doesn't have the parameters specified.
* 1. Making Put request and response same to address PutRequestResponseScheme
* 1. Changing requestId to id to address BodyTopLevelProperties
* Adding example for BatchAI /serviceLimits
* 1. Adding the swagger definition files for Quota.
2. Updating Readme.md to include Quota.json
3. Updating the title to "Microsoft.Capacity", it's required to be same in all the files.
* Updating readme.md to resolve conflicy with master.
* Removing the conflict.
* Removing space, which was causing merge conflict.
* Removing files from Quota path.
The Quota APIs will be hosted with Microsoft.Capacity RP.
* 1. Addressing SDK warning for - XmsResourceInPutResponse.
* Updating QuotaRequestResponse Model.
* Updating examples, based on the model change.
* Model change.
* Model Update.
* Adding description.
* Updated example
* 1. Validating new APIs.
2. Will add examples in next iteration.
* 1. Updating AI and adding examples.
* 1. Changing Operation_id
* 1. Added examples.
2. Added properties object to hold additional properties from different resource providers.
* Adding examples for QuotaRequests.
* Adding missing example file.
adding x-ms-azure-resource : true
* Setting - x-ms-azure-resource : true
* Adding example for MsSql get usages.
Fixing few warnings.
* Setting "x-ms-pageable": {
"nextLinkName": "nextLink"
}
for the APIs, which are not pageable, returns only one object.
* Removing extra ,
* Updating name to resourceLimits
* Adding example of quotaRequest in progress and quotaRequest Failed.
* Changing name back to serviceLimits.
* Removing "x-ms-client-flatten": true, from the propties,
which may hold specific properties for the RP.
* 1. Fixing errors - Reming Nulls for next page link.
2. The get request for 1 item doesn't need to be pageable.
* 1.Updating the name for ResourceType
* 1. Adding Auto Quota Request API.
* 1. Updated AQI Api.
* Fixing recipients spelling.
Removing x-ms-azure-resource
* 1. Adding examples for Auto Quota Increase.
* 1. Adding example for turning off th Auto Quota Invrease.
2. Fixing examples.
* Updating the model.
* Fixing reference.
* Fixing spelling of Sev
* Adding "x-ms-azure-resource": true,
* Adding name, type parameters.
* Fixing top level elements.
* Updating descriptions and summary text.
* Updating Id with full resource path.
* Speeling fix for specified
* Removing '' from the json.
* ,
* 1. Updating operations ID as suggested.
2. Updated summary to clarify one resource vs multiple reources.
3. Updated autoQuota Increase data model and examples.
* Updated examples.
* Fixinf spelling.
* 1. Changing the enums to OnSuccess, OnFailure.
* 1. Changing the serviceLimits/requests to /quotaRequests.
The requests cannot be child resource of /serviceLimits.
* 1. Updating the quotaRequests to serviceRequests.
2. Updating the examples.
* Changing the serviceRequest to serviceLimitsRequests, as suggested.
* Changing emailActions to emailAction.
* 1. Adding eTag header.
2. Adding oData $metadata.
* 1. Making etag required parameter for put.
2. Updating metadata example.
* Updating the name to - "name": "Automatic Quota Increase",
* Adding $skipToken parameter.
* Adding If-Match to the put and patch examples for quota.
* 1. Updating the Examles based on the model.
* Updating examples based on model.
* Fixing examples' model for autoQuotaIncrease.
* Fixing examples Model errors.
* Fixing recipients.
* Changing the AutoQuotaIncrease Put data model.
* Fixing json.
* Fixing example.
* Removing $metadata api.
* 1. Adding subRequestId for subrequests.
2. Updating examples with subRequestId.
* 1. Updating long running task response based on comments.
2. Updating Auto Quota Increase request.
Auto Quota increase is a functionality/service, where a customer can opt in for - service monitoring the usages and quota value and automatically increase the quota, when a threshold is reached.
* Fixing builderror camel case.
Fixing example.
* Changing "operationId": "AutoQuotaIncrease_Create"
* Changing the field names to lower case.
* Changing case.
* Changing Case.
* Updating Auto Quota Increase schema.
* Fixing AQI examples.
* Removing readonly properties from Set requests.
* Removing unused model.
* changing to lowercase
* Fixing schema.
* Fixing nested refs.
* Changing type to object.
* example fix.
* Updated the Put schema and examle, as per discussion.
* Updated Examples and formatting.
* Fixing errors/warnings.
* Put Response fix.
* Model Fix.
* Model Fixes.
* removing "x-ms-azure-resource": true from request.
* Updating response schema for Put.
* Put examples fixing.
* Adding type= object for top level models.
* Example fix.
* Quota request response updates.
* Example Fix.
* Model fix.
* Changing model.
* Example Fix.
* One SKU Put quota request update.
* Fixing Put requests.
* Example updates.
* Making currentValue readonly.
* Remove currentValue from quota update response.
* Model Fix for put.
* Fixing Patch example.
* Making proerties read-only.
* Removing readonly properties from resource name and unit
* removing ready-only from unit.
* 1. Removing collection Put and Patch.
2. Adding patch for single resource.
* 1. Making Put request and response body same.
2. Making provisioningState as readonly property.
3. Updated Examples accordingly.
* Updating Patch operation name to _Update.
* Model Update.
* Fixing examples.
* Fixing examples.
* 1. Fixing Examples.
* Updating operation id as suggested.
* Updated Operation Id: "operationId": "Quotas_GetStatus",
* Fixing issue - The PUT/GET/PATCH operations must have same schema response.
* 1. Adding id, name, type properties in reponse example.
2. Making ResourceType property setable for Put,Patch request.
* Updating the samples
* Updating the samples
* Revert commit.
* Formatting the json.
Example spelling correction.
* 1. Chaging resource name from Providers to resourceProviders, as suggested by ARM team.
2. Updating examples.
* Fixing jSon.
* Adding patch API.
* Adding resource name to the example.
* Updating patch example.
* Updating Patch example.
* Patch example fix.
* Remove unit from request example.
* Removing readonly property Unit from request.
* Updating request format.
* Changing the title to match the reservation - Azure Reservation API
* Changing the tile back to - Microsoft.Capacity
* Removing Readonly roperty from the quota request.
* Including stable version of Reservation API for tag-
tag: package-preview-2019-07-19.
* Matching the title with the released version of reservation Api.
* Including the reservation latest swagger file.
Matching the Title to Microsoft.Capacity.
* Reverting the title back to Azure Reservation API
* Running json formatter.
* Formatting json from vscode.
The prettier didn't work! Used vscode to format the json.
Error:
D:\src\azureAPI\azure-rest-api-specs>npm run prettier -- --write "specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/**/*.json"
npm ERR! missing script: prettier
* Running json Prettier.
* Running formatting from visul studio.
* Running prettier check.
Output shows no Issues-
D:\src\azureAPI\azure-rest-api-specs>prettier -c specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/*.json
Checking formatting...
All matched files use Prettier code style!
* Running Prettier.
Co-authored-by: Nick Schonning <nschonni@gmail.com>
* ANF-567 add API 2019-11-01 * ANF-567 add API 2019-11-01 * Update netapp.json Prettier * ANF-567 add API 2019-11-01 * ANF-567 add API 2019-11-01 * ANF-567 add new API 2019-11-01 Correct long running operations - add dummy terminal 200 state
* python sdk generation for ops management * missing change
…riptions (#8204) * Update descriptions * Put is a long running operation, adding the property for it
* microsoft.operationalinsights_add_data_export * fix * fix * fix readmfile + fix cSpell * fix * Revert "fix" This reverts commit a23f53b. * Fix azure-rest-api-specs-tests * format * Revert "format" This reverts commit f39f5e4. * Revert "Fix azure-rest-api-specs-tests" This reverts commit 50cf6aa. * prettifer * Code review fixes * Update OperationalInsights.json * Make Destination type "readonly" Co-authored-by: Arik Olsh <47111029+arolshan@users.noreply.github.com>
* Added Azure App Configuration v1.0 data plane API spec. * update custom-words.txt * fix formatting * add another custom word Co-authored-by: Joel Hendrix <jhendrix@microsoft.com>
* update swagger - aading LogicAppResourceId to Action put and response * update swagger - changing to logicAppResourceId style * adding LogicAppResourceId to Actions Request & Response * adding LogicAppResourceId to Actions Request & Response * adding Action property base * editing examples and adding reauired to logicAppResourceId * from LogicAppResourceId to logicAppResourceId * running prettier * running prettier * removing required for LogicAppRexourceId * changing logicApp propery doc * changing logicApp propery description
…ble/2019-11-09 (#8214) * Added stateReason property to cluster * Executed prettier
…ew version (#8229) * support rp swagger for public preview * fixing spelling error * addressing review comments * adding common resource properties * fixing readme.csharp.md * adding example that was missed * fix syntax error in swagger spec * fixing model validation error * put support for communication resource and other updates based on comments * updating communication to be async, fixing version on async and location headers * updating documentation and examples * fixing spelling error * ran prettier fix and addressing review comments
* Improve descriptions in bastionHost.json * Address PR feedback
* swagger changes for zone to zone recovery plan * zone to zone recovery plan provider specific read only property update * prettier format * prettier formatting
* changing host to management.azure.com aligning with other specs * Fixing examples for varios azs admin swagger specs * Fixing OAV validation errors * Run npm prettier-check
* fix examples for deployments link * remove resource ids * fix code style issues
* ApiManagement - long running operations * ApiManagement - long running operations - 200 * ApiManagement - long running operations - 200 - example * ApiManagement - long running operations - 200 - payload
* Add incidents API to swagger * Replace tabs with spaces * Fix failed prettier test
* Adding new fields to transactions API Adding new fields to transactions API * Updated the field description Updated the field description * Updated few descriptions
* updated keyvault readme * fixed mistake
…table/2020-01-01 (#8210) * add disabled property to digest config, change type of frequency property * fix examples * change bool to enum * add name property * apply prettier and fix frequency description
* Add tenantId to product. * fix
This was referenced Feb 24, 2020
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.