Develop #133
Merged
Develop #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source resources from GitHub
- Update config variable example to be correct yaml. - Added back rule that was blocked by incorrect yaml. - Update headings to all start with heading 1.
Markdownlint
Added all available default rules except standard_module_structure as many of our resources do not require main.tf or outputs.tf
Shellcheck precommit hook has been added and all shell scripts have been updated to meet the requirements of the hook. In addition, it was determined that test-in-cloud and test-with-docker are not longer used and should be removed rather than updated to work again.
Added ansiblelint and seperately yamllint so both could be configured independently.
Adding install for shellcheck and shfmt
In order to run shellcheck on template bash scripts, a .shellcheckrc file was added to the template directory disabling any checks that confuse the template interface with the bash interface. .*tpl will remain excluded from shfmt as we don't want to inadvertently make changes in a template file related to the template interface.
Add more tflint rules
SC1090 doesn't like unknown paths because it tries to verify they are valid. We are not running locally and the path is not known before runtime, so this should be disabled.
Add to the Makefile rule to install shfmt and warn if shellcheck is not found.
Add yaml/ansible/shell precommit hooks and update all code to be in compliance
A bug where the backends in all resource groups have the same prefix is fixed with this change. Before the address of the default configuration was being added to the groups and it's prefix was added. That prefix would propogate as the defaults were added to other groups and therefore the correct prefix was never updated. In addition to the bug fix, the section of code was pulled out into it's own function in expand as that better represents what it is doing. Tests have been added to hopefully catch this type of bug in the future.
Fix bug in applied group terraform backends
This readme will replace the quickstart section of the user guide.
Update Installation, Basic Usage, and Development documentation
Add debug partitions to examples
We make no assumption about the level of default quota and define all required quotas.
Adds documentation on quotas required for examples
Replace path package with path/filepath
Troubleshooting
Update pre-commit hooks to latest releases
…ing to provider value
Filestore module should allow specification of project_id
Adds install of [goimports](https://pkg.go.dev/golang.org/x/tools/cmd/goimports) required by pre-commit checks to both the dockerfile and install-dev-deps rule of the Makefile
Add installation of goimports to Dockerfile
Missed a module.json file in cleanup. Remove last one
Update small example to have same region and zone as high-io
Update version to 0.4.0
* Expose all VPC module input variables for networks and subnetworks
* Completely disable auto-creation of subnetworks in all regions
* Explicitly define a primary subnetwork and "additional" subnetworks
* Follow CFT recommendation to create NATs using
terraform-google-cloud-router module
* Resolves #73
Refactor VPC module to support finer settings and avoid failure when invalid region specified
nick-stroud
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist:
pre-commit installmake testschange?
guides?