Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #133

Merged
merged 71 commits into from
Mar 2, 2022
Merged

Develop #133

merged 71 commits into from
Mar 2, 2022

Commits on Feb 4, 2022

  1. Configuration menu
    Copy the full SHA
    85807e2 View commit details
    Browse the repository at this point in the history
  2. Remove git-ssh test case

    mittz committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    e7f505b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Create sourcereader package

    mittz committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1ab84ed View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Address reviewer feedback

    mittz committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a97792c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8cdd6c2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #100 from mittz/resource-sourcing

    Source resources from GitHub
    cboneti authored Feb 9, 2022
    Configuration menu
    Copy the full SHA
    9a91abb View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Configuration menu
    Copy the full SHA
    6b79493 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5f7f80 View commit details
    Browse the repository at this point in the history
  3. Address PR comments

    - Update config variable example to be correct yaml.
      - Added back rule that was blocked by incorrect yaml.
    - Update headings to all start with heading 1.
    nick-stroud committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    298c230 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #105 from nick-stroud/markdownlint

    Markdownlint
    cboneti authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3b7337c View commit details
    Browse the repository at this point in the history
  5. Add more tflint rules

    Added all available default rules except standard_module_structure as
    many of our resources do not require main.tf or outputs.tf
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    905a472 View commit details
    Browse the repository at this point in the history
  6. Add shellcheck precommit hook

    Shellcheck precommit hook has been added and all shell scripts have been
    updated to meet the requirements of the hook. In addition, it was
    determined that test-in-cloud and test-with-docker are not longer used
    and should be removed rather than updated to work again.
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    6f499eb View commit details
    Browse the repository at this point in the history
  7. Add yamllint and ansiblelint, fix lint errors

    Added ansiblelint and seperately yamllint so both could be configured
    independently.
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3a28e61 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    613decb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    50269bb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    09a5f2c View commit details
    Browse the repository at this point in the history
  11. Update build Dockerfile to install shell checks

    Adding install for shellcheck and shfmt
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    156dbff View commit details
    Browse the repository at this point in the history
  12. Add shellcheckrc to template directory

    In order to run shellcheck on template bash scripts, a .shellcheckrc
    file was added to the template directory disabling any checks that
    confuse the template interface with the bash interface.
    
    .*tpl will remain excluded from shfmt as we don't want to inadvertently
    make changes in a template file related to the template interface.
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    bb4f1d4 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #108 from heyealex/add-tflint-rules

    Add more tflint rules
    heyealex authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3fad99d View commit details
    Browse the repository at this point in the history
  14. Add SC1090 as a disabled shellcheck rule

    SC1090 doesn't like unknown paths because it tries to verify they are
    valid. We are not running locally and the path is not known before
    runtime, so this should be disabled.
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    cfda817 View commit details
    Browse the repository at this point in the history
  15. Add shfmt and shellcheck to install-dev-deps

    Add to the Makefile rule to install shfmt and warn if shellcheck is not
    found.
    heyealex committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a83fbc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Merge pull request #106 from heyealex/add-pre-commits

    Add yaml/ansible/shell precommit hooks and update all code to be in compliance
    heyealex authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    d50db55 View commit details
    Browse the repository at this point in the history
  2. Fix bug in applied group terraform backends

    A bug where the backends in all resource groups have the same prefix is
    fixed with this change. Before the address of the default configuration
    was being added to the groups and it's prefix was added. That prefix
    would propogate as the defaults were added to other groups and therefore
    the correct prefix was never updated.
    
    In addition to the bug fix, the section of code was pulled out into it's
    own function in expand as that better represents what it is doing.
    
    Tests have been added to hopefully catch this type of bug in the future.
    heyealex committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    320660f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    859d436 View commit details
    Browse the repository at this point in the history
  4. Update Development docs

    nick-stroud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    24f1e7f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #110 from heyealex/bugfix/tf-backend-group

    Fix bug in applied group terraform backends
    heyealex authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    82015c2 View commit details
    Browse the repository at this point in the history
  6. Fix misspelling of variable

    tpdownes committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e081ce1 View commit details
    Browse the repository at this point in the history
  7. Update readme with missing information from hpc-toolkit user guide

    This readme will replace the quickstart section of the user guide.
    nick-stroud committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    fd02d5a View commit details
    Browse the repository at this point in the history
  8. Merge pull request #109 from nick-stroud/cloud_shell_docs

    Update Installation, Basic Usage, and Development documentation
    heyealex authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8d09177 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #113 from tpdownes/fix_typo

    Fix typo
    tpdownes authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    943a4b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Update spack resource with logs and environments

    This merge updates the spack installation resource to have a
    configurable logfile where output is written while installing spack.
    Additionally, it adds the ability to generate spack environments to
    contain groups of packages.
    douglasjacobsen committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    006ab7a View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Add option to promote module outputs to top level

    Add a new field in the YAML definition that takes a list of outputs to
    be added to the top level of a resource group blueprint.
    heyealex committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    5b742f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a02420 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #115 from tpdownes/fix_typo

    Fix misspelling in variable description and add validation block
    tpdownes authored Feb 14, 2022
    Configuration menu
    Copy the full SHA
    6566bac View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Merge pull request #111 from douglasjacobsen/spack_environments

    Update the spack resource with logfiles and environments
    cboneti authored Feb 15, 2022
    Configuration menu
    Copy the full SHA
    9b1a256 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Add a validation for whether an output exists

    Checks if an output exists in the underlying resource module, fails if
    not. Also added further unit tests where necessary.
    heyealex committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    3522e8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f13664e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a5c91c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ccb65bb View commit details
    Browse the repository at this point in the history
  5. Merge pull request #114 from heyealex/feature/top-level-outputs

    Add option to promote module outputs to top level
    heyealex authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    4109d8c View commit details
    Browse the repository at this point in the history
  6. Bump SlurmGCP to v4.1.5

    Branden Moore committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    50fc63f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Merge pull request #118 from mittz/add-cli-autocompletion

    Add tab command completion to CLI
    cboneti authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    86c3b80 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #119 from brandenm-nag/bump_slurm_gcp_version

    Bump slurm gcp version to v4.1.5
    cboneti authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5531a9c View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Configuration menu
    Copy the full SHA
    ae2147b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2c6699 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #117 from nick-stroud/debug_examples

    Add debug partitions to examples
    cboneti authored Feb 18, 2022
    Configuration menu
    Copy the full SHA
    6d2892a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    02fa82b View commit details
    Browse the repository at this point in the history
  5. Documenting quota requirments for example yaml

    We make no assumption about the level of default quota and define all
    required quotas.
    nick-stroud committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    442349e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge pull request #121 from nick-stroud/quota_docs

    Adds documentation on quotas required for examples
    nick-stroud authored Feb 23, 2022
    Configuration menu
    Copy the full SHA
    723d9c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    3c0a610 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba21b18 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #122 from mittz/replace-path-with-filepath

    Replace path package with path/filepath
    nick-stroud authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    5c65d27 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fde679b View commit details
    Browse the repository at this point in the history
  5. Merge pull request #124 from nick-stroud/troubleshooting

    Troubleshooting
    nick-stroud authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    bf80869 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Configuration menu
    Copy the full SHA
    c4bd6c3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #126 from tpdownes/update_precommit

    Update pre-commit hooks to latest releases
    tpdownes authored Feb 25, 2022
    Configuration menu
    Copy the full SHA
    416f098 View commit details
    Browse the repository at this point in the history
  3. Filestore module should allow specification of project_id w/o default…

    …ing to provider value
    tpdownes committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    6364be2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #125 from tpdownes/filestore_project_id

    Filestore module should allow specification of project_id
    tpdownes authored Feb 25, 2022
    Configuration menu
    Copy the full SHA
    7752312 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f141317 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Add installation of goimports to Dockerfile

    Adds install of
    [goimports](https://pkg.go.dev/golang.org/x/tools/cmd/goimports)
    required by pre-commit checks to both the dockerfile and
    install-dev-deps rule of the Makefile
    heyealex committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    abb767d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. Merge pull request #129 from heyealex/add-install-goimports

    Add installation of goimports to Dockerfile
    heyealex authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    a54a169 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d968f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99d9e29 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #130 from tpdownes/last_module_json

    Missed a module.json file in cleanup. Remove last one
    tpdownes authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c1df963 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #123 from nick-stroud/unify_example_regions

    Update small example to have same region and zone as high-io
    nick-stroud authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    3454fdd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b5feb8b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    42c5707 View commit details
    Browse the repository at this point in the history
  8. Update version to 0.4.0

    heyealex committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    25966b4 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #132 from heyealex/update-version

    Update version to 0.4.0
    heyealex authored Mar 1, 2022
    Configuration menu
    Copy the full SHA
    3f2c196 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. * Adopt latest version of all CFT modules

    * Expose all VPC module input variables for networks and subnetworks
        * Completely disable auto-creation of subnetworks in all regions
        * Explicitly define a primary subnetwork and "additional" subnetworks
    * Follow CFT recommendation to create NATs using
      terraform-google-cloud-router module
    * Resolves #73
    tpdownes committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    2546eae View commit details
    Browse the repository at this point in the history
  2. Merge pull request #131 from tpdownes/refactor_vpc

    Refactor VPC module to support finer settings and avoid failure when invalid region specified
    tpdownes authored Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f234409 View commit details
    Browse the repository at this point in the history