Release 5.0.3 #156
Merged
Release 5.0.3 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Mar 4, 2023
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Release 5.0.3 |
| Type? | |
| BC breaks? | |
| Deprecations? | |
| Fixed ticket? | |
| How to test? |
Replace SUM(pc.`grade`) / COUNT(pc.`grade`) by AVG(pc.`grade`)
Replace SUM(pc.`grade`) / COUNT(pc.`grade`) by AVG(pc.`grade`)
Remove redundant open parenthesis left by previous commit
1. Assign $id_xyz = (int) $id_xyz once at top, instead of using (int) $id_xyz throughout the function 2. if Validate::isUnsignedId($id_xyz ) then there is no need to type cast (int) ($id_xyz)
if Validate::isUnsignedId($id_product) then there is no need to type cast (int) $id_product
Co-authored-by: Matthieu Rolland <matthieu.rolland@prestashop.com>
Field requires positive integer value need validation before saving
'%s is invalid. Please enter an integer greater than %s.'
In fact, in Validate class: isUnsignedId is just an alias of isUnsignedInt Co-authored-by: Amoifr <31698966+Amoifr@users.noreply.github.com>
Co-authored-by: Amoifr <31698966+Amoifr@users.noreply.github.com>
Clearer variable name and function name
and Better Module display message functions
Add validation for 2 positive integer fields
Simplify Average code
Simplify Type casting
fixes remove not needed checks php 5.6 support fix wrong variable name
Improved lastname anonymization
Remove microdata from product miniatures
Delete logo.gif
Template improvements
Remove unneeded code
Bump version to 5.0.3
kpodemski
approved these changes
Mar 6, 2023
djoelleuch
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Hello @Hlavtox
Tested on 1.7.8.8, 8.0.0 and 8.0.1.
This release LGTM , it's QA approved ✔️
Thank you 🚀 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.