Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ignored messages reactivity #27279

Merged
merged 17 commits into from
Feb 8, 2023
Merged

[FIX] Ignored messages reactivity #27279

merged 17 commits into from
Feb 8, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Nov 16, 2022

Proposed changes (including videos or screenshots)

Issue(s)

fixes #27182
TC-249

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #27279 (46f753e) into develop (7f507c1) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27279      +/-   ##
===========================================
+ Coverage    42.03%   42.07%   +0.04%     
===========================================
  Files          848      848              
  Lines        17555    17555              
  Branches      2078     2078              
===========================================
+ Hits          7379     7387       +8     
+ Misses        9898     9891       -7     
+ Partials       278      277       -1     
Flag Coverage Δ
e2e 42.07% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

…age-ignore-reactivity

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Chore: removing useEndpointData from license api (#26634)
  Chore: Create unique index for `E2EKey` field (#27301)
  [FIX] LDAP "Sync Roles" option doesn't work for custom roles (#26842)
  Chore: UserAvatar wrapper missing key in RoomForeword (#27300)
  Chore: Add deprecation warning to settings (#27295)
  Chore: Refactor LeaveTeam to Typescript (#27197)
  [FIX] Sidebar context menu in searchList (#23830)
  [NEW] Federation events coverage expansion (#27119)
  [FIX] Message Parser version upgrade (#27284)
  [FIX] Replace regex not compatible with safari (#27294)
  [NEW] Emphasis Elements (italic, strike and bold) in Message Parser Components (#27003)
  [FIX] Set default value "false" for global search. (#25568)
  Regression: Custom fields form not showing in user profile nor admin (#27244)
  [FIX] Sort RecordList items in REVERSE chronological order, not FORWARD (#27201)
  Chore: Remove unused css (#27289)
  Chore: also send thread to channel translations (#27242)
  [FIX] Marketplace app details page back-button behavior (#27062)
  Chore: Add tests for omni-jobs & add more context in system messages for jobs (#27048)
  Chore: Fix missing license for forks (#27258)
  i18n: Language update from LingoHub 🤖 on 2022-11-14Z (#27255)
  ...
@ggazzo ggazzo added this to the 6.0.0 milestone Nov 25, 2022
@yash-rajpal yash-rajpal marked this pull request as ready for review December 13, 2022 15:22
@yash-rajpal yash-rajpal requested review from a team as code owners December 13, 2022 15:22
hugocostadev
hugocostadev previously approved these changes Dec 14, 2022
tassoevan
tassoevan previously approved these changes Dec 29, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 19, 2023
hugocostadev
hugocostadev previously approved these changes Jan 19, 2023
@dionisio-bot dionisio-bot bot added stat: conflict and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Feb 7, 2023
@kodiakhq kodiakhq bot merged commit 6c003f6 into develop Feb 8, 2023
@kodiakhq kodiakhq bot deleted the message-ignore-reactivity branch February 8, 2023 23:20
gabriellsh added a commit that referenced this pull request Feb 13, 2023
…e/wizard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969)
  [NEW] Emojis rendering properly on quote message previews (#27972)
  Chore: Wait message to not be Busy (#28000)
  Chore: e2e changes tests (#27987)
  [IMPROVE] Audit (#27994)
  [IMPROVE] Registration Experience (#27820)
  [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854)
  [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902)
  [NEW] Permission to bypass message editing and removing limits (#27644)
  [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764)
  Chore: Set missing colors (#27817)
  Fix CI
  Chore: undo busy selector
  [BREAK] Remove message view mode from User Preferences (#27867)
  Chore: Aria busy indicators (#27978)
  Chore: Refactor Composer Dropdown (#27931)
  Chore: Added Enterprise Options to Login customization (#27855)
  [FIX] Ignored messages reactivity (#27279)
  [BREAK] [NEW] Custom roles upsell modal (#27707)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ignoring/Unignoring user doesn't hide/unhide messages until refresh
6 participants