Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REBASE only]: Migrate notebooks and add new amalthea #418

Merged
merged 20 commits into from
Nov 11, 2024
Merged

[REBASE only]: Migrate notebooks and add new amalthea #418

merged 20 commits into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. feat: add new apispec for the new amalthea sessions (#360)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    faa2246 View commit details
    Browse the repository at this point in the history

  2. feat!: expand environments specification (#338) 

    This is a breaking change in the API. It requires changes in the UI for it to be fully useful.
    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a6e8243 View commit details
    Browse the repository at this point in the history

  3. feat: run notebooks in data service (#375) 

    Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>

squashme: resolve package version conflicts
    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f509340 View commit details
    Browse the repository at this point in the history

  4. feat: ensure notebook endpoints do their job (#388) 

    This work brings the notebook related endpoints to a working state
to serve as replacement for the renku-notebooks external service.

Short summary:
- API tests have been added
- Code has been fixed to answer / handle exception
- Automated test cluster creation has been added using k3d

---------

Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch>
    @sgaist @olevski
    sgaist and olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2e92ba6 View commit details
    Browse the repository at this point in the history

  5. feat: use cloud storage from amalthea (#387) 

    Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
    @olevski @sgaist
    olevski and sgaist committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4de34f3 View commit details
    Browse the repository at this point in the history

  6. feat: perf improvements for amalthea sessions (#411)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    12c2ab2 View commit details
    Browse the repository at this point in the history

  7. refactor: add validation to project, storage, repo and session bluepr… 

    …ints (#347)
    @Panaetius @olevski
    Panaetius authored and olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    34c99fa View commit details
    Browse the repository at this point in the history

  8. fix: allow session launcher parameters to be reset (#434) 

    Allows the API to accept None as input for args, command and the session
launcher resource class ID so that they can be reset to their defaults
in patch endpoints.
    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2cf4d78 View commit details
    Browse the repository at this point in the history

  9. fix: docker image check endpoint and gitlab authn (#439)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a03872e View commit details
    Browse the repository at this point in the history

  10. fix: add hibernation and deletion time in status (#440)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a8bfb8e View commit details
    Browse the repository at this point in the history

  11. fix: find images when there is an oci index (#462) 

    This was causing the API to consider some images as non-existing.
Whereas in reality they exist. I noticed this with this image:
ghcr.io/salimkayal/renku-devcontainer-wizard:latest.
    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    40b64fa View commit details
    Browse the repository at this point in the history

  12. Notebook: refactor blueprint business logic to core (#429) 

    The move of business logic out of the blueprint allows the code to
be reusable without having to go through the web API. It also allows
for tests to be added without the web complexity.

Tests have been refactored so that test clusters will be created only
when testing endpoints that actually require a cluster. This has the
advantage of speeding up test time. This is especially useful when
doing development.

Finally, a new test option has been added so one can use a local
cluster in place of re-creating one each time tests are run.
    @sgaist @olevski
    sgaist authored and olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    95cfa9c View commit details
    Browse the repository at this point in the history

  13. feat: add data connectors (#478) 

    Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
    @olevski @sgaist
    @Panaetius @leafty
    4 people committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    684ab13 View commit details
    Browse the repository at this point in the history

  14. fix: environment kind assignment (#511)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3e28eb9 View commit details
    Browse the repository at this point in the history

  15. fix: do not create storage secrets twice (#512)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    03a24e0 View commit details
    Browse the repository at this point in the history

  16. fix: preserve the default url in the session spec (#514) 

    Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
    @olevski @Panaetius
    olevski and Panaetius committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    55ad740 View commit details
    Browse the repository at this point in the history

  17. fix: migrate old session launchers (#513)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0575d30 View commit details
    Browse the repository at this point in the history

  18. fix: git connectors and reading logs (#518)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f6fd293 View commit details
    Browse the repository at this point in the history

  19. fix: add user secret key when using saved secrets (#519)

    @olevski
    olevski committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8d63208 View commit details
    Browse the repository at this point in the history

  20. fix: run the /post-init.sh script if present 

    Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
    @olevski @leafty
    olevski and leafty committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1046f40 View commit details
    Browse the repository at this point in the history