Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean error log lines #12019

Merged
merged 2 commits into from
Feb 14, 2024
Merged

clean error log lines #12019

merged 2 commits into from
Feb 14, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

Test Plan

Copy link

trunk-io bot commented Feb 14, 2024

⏱️ 8h 58m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 2h 10m 🟩🟩🟩
rust-smoke-tests 1h 55m 🟩
rust-unit-tests 1h 21m 🟩🟩
windows-build 39m 🟩🟩🟩
execution-performance / single-node-performance 37m 🟩🟩
rust-images / rust-all 27m 🟩🟩
rust-lints 22m 🟩🟩🟩
forge-e2e-test / forge 20m 🟩
forge-compat-test / forge 17m 🟩
cli-e2e-tests / run-cli-tests 13m 🟥
check 13m 🟩🟩🟩
run-tests-main-branch 11m 🟥🟥🟥
general-lints 7m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 2m 🟩🟩🟩
file_change_determinator 32s 🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
file_change_determinator 21s 🟩🟩
execution-performance / file_change_determinator 18s 🟩🟩
permission-check 14s 🟩🟩🟩
permission-check 11s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 6s 🟩🟩
determine-docker-build-metadata 3s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-smoke-tests 1h 36m 30m +218%
cli-e2e-tests / run-cli-tests 9m 7m +31%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos enabled auto-merge (squash) February 14, 2024 21:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 80933440712371e21b34fc423b98f5c870737169

Compatibility test results for aptos-node-v1.8.3 ==> 80933440712371e21b34fc423b98f5c870737169 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4695 txn/s, latency: 6762 ms, (p50: 6200 ms, p90: 10500 ms, p99: 18300 ms), latency samples: 178440
2. Upgrading first Validator to new version: 80933440712371e21b34fc423b98f5c870737169
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1852 txn/s, latency: 15712 ms, (p50: 18400 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92600
3. Upgrading rest of first batch to new version: 80933440712371e21b34fc423b98f5c870737169
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1781 txn/s, latency: 16238 ms, (p50: 19000 ms, p90: 22500 ms, p99: 22900 ms), latency samples: 92620
4. upgrading second batch to new version: 80933440712371e21b34fc423b98f5c870737169
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2347 txn/s, latency: 11324 ms, (p50: 12300 ms, p90: 14700 ms, p99: 16800 ms), latency samples: 110320
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 80933440712371e21b34fc423b98f5c870737169 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 80933440712371e21b34fc423b98f5c870737169

two traffics test: inner traffic : committed: 7636 txn/s, latency: 5036 ms, (p50: 4800 ms, p90: 6200 ms, p99: 10500 ms), latency samples: 3291420
two traffics test : committed: 100 txn/s, latency: 2243 ms, (p50: 2100 ms, p90: 2500 ms, p99: 6800 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.233, avg: 0.200", "QsPosToProposal: max: 0.148, avg: 0.143", "ConsensusProposalToOrdered: max: 0.581, avg: 0.526", "ConsensusOrderedToCommit: max: 0.504, avg: 0.467", "ConsensusProposalToCommit: max: 1.019, avg: 0.993"]
Max round gap was 1 [limit 4] at version 1102463. Max no progress secs was 4.681564 [limit 15] at version 1102463.
Test Ok

@igor-aptos igor-aptos merged commit 388a7e9 into main Feb 14, 2024
39 of 43 checks passed
@igor-aptos igor-aptos deleted the igor/clean_error_logs branch February 14, 2024 23:47
danielxiangzl added a commit that referenced this pull request Feb 16, 2024
* clean error log lines (#12019)

* [table info][2/4] add utils for table info backup and restore and redesign the db read (#11793)

* separate indexer async v2 db from aptosdb

* address comments

* add utils for table info backup and restore and redesign the db read

* address comments to spawn block sync file ops

* address comments

* tests for events and improve event v1 handling (#12012)

* [move-vm] Cache verified modules (#12002)

* [move-vm] Cache verified modules

* fixup! [move-vm] Cache verified modules

* [passkey] Add MAX_BYTES limit for signatures (#11697)

* [passkey] Add MAX_BYTES limit for signatures

* [passkey] Add tracing for AssertionSignature type and fix README

* [passkey] Rebased on latest main, rerun authenticator_regenerate.sh

* Object Code Deployment module with CLI commands generated (#11748)

* [simple] rename RG split in VmChangeSet flag (#12027)

* rename RG split in VmChangeSet flag

old name was stale, when charging was different

* [fuzzing] fixes oss-fuzz FP and fuzz.sh (#12030)

* [fuzzing] fixes oss-fuzz FP and fuzz.sh

* Update Docker images (#12026)

Co-authored-by: sionescu <sionescu@users.noreply.github.com>

* Update release.yaml (#12020)

* Update release.yaml

* enable REFUNDABLE_BYTES

* enable FairnessShuffler

* enable WEBAUTHN_SIGNATURE

* AIP-54 Object Code Deployment release addition

* enable vtxn and jwk consensus

* Update release.yaml

adding aggregators v2 flags, and updating execution onchain config

* add feature flag for zkID (ZK-only mode)

* fix jwk/zkid entries in release yaml 1.10 (#12024)

* update

* update

* Update release.yaml

fix flag name

* Update release.yaml

rename feature

---------

Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: hariria <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: zhoujunma <zjma@users.noreply.github.com>

* Cherry-pick VM changes (#12021)

* [gas] add gas charges for type creation

* [gas-calibration] Add calibration sample

* [move-vm] Implement a per-frame cache for paranoid mode

* fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* [gas] add gas charges for dependencies

---------

Co-authored-by: Runtian Zhou <runtian@aptoslabs.com>

* trivial doc fix

* [GHA] Upgrade actions/checkout to v4

* jwk ob counters (#12048)

* Revert "[GHA] Upgrade actions/checkout to v4"

This reverts commit 04d078f.

* [CI][indexer] fix the e2e localnet. (#12047)

* fix the e2e localnet.

* fix the e2e localnet.

* bump latest gas feature version to 14

Also be conservative and leave legacy parameters in >14 versions for
now. Need to clean up after REFUNDABLE_BYTES feature is actually enabled
on all networks.

* compat test to be against the testnet tag

* [GHA] Upgrade lint-test.yaml and the dependent actions to checkout@v4

actions/checkout@v4 doesn't behave well if both a workflow and an
invoked action checkout the source code on top of each other.

* [GHA] Update pin for tj-actions/changed-files

* start jwk consensus for google (#12053)

* [consensus] check rpc epoch in epoch_manager (#12018)

* [consensus] check rpc epoch in epoch_manager

* fix gas version (13 is deprecated/cannot be used) (#12064)

* FatalVMError shouldn't create "Delayed materialization code invariant" (#12044)

* Move all visibility checking into AST-level function_checker, simplify that code a bit, and improve diagnostics. (#11948)

* rust changes to move all visibility checking to AST and clean it up a bit
* change `Known attribute ... position` warning to a neater `Attribute .. position` warning
* add FunctionData id_loc to allow pointing at function name in declaration for more concise error messages. abstract messages a bit in function_checker
* add 'inlined from' labels to diagnostics with labels, fix bug in function_checker to enable post-inlining visibility checking

* lint

* fix for small stakes

* assert

---------

Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: jill <121921928+jillxuu@users.noreply.github.com>
Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com>
Co-authored-by: runtianz <runtian@aptoslabs.com>
Co-authored-by: Andrew Hariri <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: Gerardo Di Giacomo <gerardo@aptoslabs.com>
Co-authored-by: sionescu <sionescu@users.noreply.github.com>
Co-authored-by: Junkil Park <jpark@aptoslabs.com>
Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: Victor Gao <10379359+vgao1996@users.noreply.github.com>
Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com>
Co-authored-by: Stelian Ionescu <sionescu@cddr.org>
Co-authored-by: larry-aptos <112209412+larry-aptos@users.noreply.github.com>
Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
Co-authored-by: Brian R. Murphy <132495859+brmataptos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants