start jwk consensus for google #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sherry-x
reviewed
Feb 15, 2024
| @@ -116,6 +116,7 @@ proposals: | |||
| discussion_url: "https://github.com/aptos-foundation/AIPs/issues/331" | |||
| execution_mode: MultiStep | |||
| update_sequence: | |||
| - RawScript: data/proposals/aip_67_initialization.move | |||
There was a problem hiding this comment.
I think you need aptos-move/aptos-release-builder/data/proposals/aip_67_initialization.move full path cause release builder would be running on aptps-core directory.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
sherry-x
approved these changes
Feb 15, 2024
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
sherry-x
reviewed
Feb 16, 2024
| @@ -160,3 +161,11 @@ proposals: | |||
| - FeatureFlag: | |||
| enabled: | |||
| - zk_id_signature | |||
| - name: step_13_start_watching_google_jwks | |||
There was a problem hiding this comment.
actually could you please move step 7 and 8 to the end (10 and 11) then zkid, then google? so we can control the submittion of those 3 proposals better
zekun000
approved these changes
Feb 16, 2024
danielxiangzl
added a commit
that referenced
this pull request
Feb 16, 2024
* clean error log lines (#12019) * [table info][2/4] add utils for table info backup and restore and redesign the db read (#11793) * separate indexer async v2 db from aptosdb * address comments * add utils for table info backup and restore and redesign the db read * address comments to spawn block sync file ops * address comments * tests for events and improve event v1 handling (#12012) * [move-vm] Cache verified modules (#12002) * [move-vm] Cache verified modules * fixup! [move-vm] Cache verified modules * [passkey] Add MAX_BYTES limit for signatures (#11697) * [passkey] Add MAX_BYTES limit for signatures * [passkey] Add tracing for AssertionSignature type and fix README * [passkey] Rebased on latest main, rerun authenticator_regenerate.sh * Object Code Deployment module with CLI commands generated (#11748) * [simple] rename RG split in VmChangeSet flag (#12027) * rename RG split in VmChangeSet flag old name was stale, when charging was different * [fuzzing] fixes oss-fuzz FP and fuzz.sh (#12030) * [fuzzing] fixes oss-fuzz FP and fuzz.sh * Update Docker images (#12026) Co-authored-by: sionescu <sionescu@users.noreply.github.com> * Update release.yaml (#12020) * Update release.yaml * enable REFUNDABLE_BYTES * enable FairnessShuffler * enable WEBAUTHN_SIGNATURE * AIP-54 Object Code Deployment release addition * enable vtxn and jwk consensus * Update release.yaml adding aggregators v2 flags, and updating execution onchain config * add feature flag for zkID (ZK-only mode) * fix jwk/zkid entries in release yaml 1.10 (#12024) * update * update * Update release.yaml fix flag name * Update release.yaml rename feature --------- Co-authored-by: aldenhu <msmouse@gmail.com> Co-authored-by: hariria <hariria@usc.edu> Co-authored-by: John Chang <johnchang9094@gmail.com> Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com> Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com> Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com> Co-authored-by: zhoujunma <zjma@users.noreply.github.com> * Cherry-pick VM changes (#12021) * [gas] add gas charges for type creation * [gas-calibration] Add calibration sample * [move-vm] Implement a per-frame cache for paranoid mode * fixup! [move-vm] Implement a per-frame cache for paranoid mode * fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode * fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode * fixup! fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode * [gas] add gas charges for dependencies --------- Co-authored-by: Runtian Zhou <runtian@aptoslabs.com> * trivial doc fix * [GHA] Upgrade actions/checkout to v4 * jwk ob counters (#12048) * Revert "[GHA] Upgrade actions/checkout to v4" This reverts commit 04d078f. * [CI][indexer] fix the e2e localnet. (#12047) * fix the e2e localnet. * fix the e2e localnet. * bump latest gas feature version to 14 Also be conservative and leave legacy parameters in >14 versions for now. Need to clean up after REFUNDABLE_BYTES feature is actually enabled on all networks. * compat test to be against the testnet tag * [GHA] Upgrade lint-test.yaml and the dependent actions to checkout@v4 actions/checkout@v4 doesn't behave well if both a workflow and an invoked action checkout the source code on top of each other. * [GHA] Update pin for tj-actions/changed-files * start jwk consensus for google (#12053) * [consensus] check rpc epoch in epoch_manager (#12018) * [consensus] check rpc epoch in epoch_manager * fix gas version (13 is deprecated/cannot be used) (#12064) * FatalVMError shouldn't create "Delayed materialization code invariant" (#12044) * Move all visibility checking into AST-level function_checker, simplify that code a bit, and improve diagnostics. (#11948) * rust changes to move all visibility checking to AST and clean it up a bit * change `Known attribute ... position` warning to a neater `Attribute .. position` warning * add FunctionData id_loc to allow pointing at function name in declaration for more concise error messages. abstract messages a bit in function_checker * add 'inlined from' labels to diagnostics with labels, fix bug in function_checker to enable post-inlining visibility checking * lint * fix for small stakes * assert --------- Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com> Co-authored-by: jill <121921928+jillxuu@users.noreply.github.com> Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com> Co-authored-by: runtianz <runtian@aptoslabs.com> Co-authored-by: Andrew Hariri <hariria@usc.edu> Co-authored-by: John Chang <johnchang9094@gmail.com> Co-authored-by: Gerardo Di Giacomo <gerardo@aptoslabs.com> Co-authored-by: sionescu <sionescu@users.noreply.github.com> Co-authored-by: Junkil Park <jpark@aptoslabs.com> Co-authored-by: aldenhu <msmouse@gmail.com> Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com> Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com> Co-authored-by: Victor Gao <10379359+vgao1996@users.noreply.github.com> Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com> Co-authored-by: Stelian Ionescu <sionescu@cddr.org> Co-authored-by: larry-aptos <112209412+larry-aptos@users.noreply.github.com> Co-authored-by: Balaji Arun <balaji@aptoslabs.com> Co-authored-by: Brian R. Murphy <132495859+brmataptos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan