merge main to randomnet

[zjma]

Description

Test Plan

[trunk-io]

⏱️ 16h 49m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-smoke-coverage	3h 42m	🟩
rust-move-unit-coverage	1h 49m	⬜ 🟩 ⬜ 🟩
rust-smoke-tests	1h 48m	⬜ 🟩 ⬜ 🟩
rust-unit-tests	1h 29m	🟥 🟥 ⬜ 🟩
execution-performance / single-node-performance	1h 18m	🟩 🟩 🟩 🟩
windows-build	1h 15m	🟥 🟩 🟩 🟩 🟩
rust-move-tests	1h 8m	🟩 🟩 ⬜ 🟩
rust-images / rust-all	45m	🟩 🟩 ⬜ 🟩
forge-e2e-test / forge	41m	🟩 🟩 🟩
forge-compat-test / forge	37m	🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	27m	🟥 🟥 🟥
rust-lints	26m	🟥 🟩 🟩 🟩
run-tests-main-branch	25m	🟥 🟥 🟥 🟥
rust-unit-coverage	13m	🟥
check	13m	⬜ 🟥 🟩 🟩 🟩
check-dynamic-deps	11m	🟩 🟩 🟩 🟩 🟩
general-lints	9m	🟩 🟩 🟩 🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	5m	🟥 🟩 🟥
node-api-compatibility-tests / node-api-compatibility-tests	3m	🟩 🟩 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩 🟩
file_change_determinator	45s	🟩 🟩 🟩 🟩
file_change_determinator	45s	⬜ 🟩 🟩 🟩 🟩
file_change_determinator	44s	🟩 🟩 🟩 🟩
execution-performance / file_change_determinator	41s	🟩 🟩 🟩 🟩
permission-check	20s	🟩 🟩 🟩 🟩 🟩
permission-check	19s	🟩 🟩 🟩 🟩 🟩
permission-check	13s	🟩 🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
determine-docker-build-metadata	10s	🟩 🟩 🟩 🟩
permission-check	10s	🟩 🟩 🟩 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
cli-e2e-tests / run-cli-tests	10m	6m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[codecov]

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (b701c7d) 71.3% compared to head (fa66e2b) 69.9%.
Report is 157 commits behind head on randomnet.

Files	Patch %	Lines
types/src/dkg/real_dkg/rounding/mod.rs	0.0%	49 Missing ⚠️
...cached-packages/src/aptos_framework_sdk_builder.rs	57.1%	15 Missing ⚠️
...aptos-gas-schedule/src/gas_schedule/transaction.rs	0.0%	8 Missing ⚠️
...ove/move-vm/types/src/loaded_data/runtime_types.rs	94.7%	6 Missing ⚠️
aptos-move/framework/src/extended_checks.rs	42.8%	4 Missing ⚠️
aptos-move/block-executor/src/executor.rs	75.0%	3 Missing ⚠️
...arty/move/move-compiler/src/expansion/translate.rs	33.3%	2 Missing ⚠️
types/src/dkg/real_dkg/mod.rs	0.0%	2 Missing ⚠️
aptos-move/aptos-gas-meter/src/meter.rs	88.8%	1 Missing ⚠️
aptos-move/aptos-vm-types/src/resolver.rs	0.0%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@             Coverage Diff              @@
##           randomnet   #12078     +/-   ##
============================================
- Coverage       71.3%    69.9%   -1.5%     
============================================
  Files            800      842     +42     
  Lines         183535   188575   +5040     
============================================
+ Hits          131043   131992    +949     
- Misses         52492    56583   +4091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sherry-x]

should aim to redeploy randomnet once this merge?

[zjma]

should aim to redeploy randomnet once this merge?

we don't have to take the risk... but can try

[github-actions]

✅ Forge suite compat success on aptos-node-v1.8.3 ==> fa66e2bec67679a43f93ebf8b5165a4c9c8d794c

Compatibility test results for aptos-node-v1.8.3 ==> fa66e2bec67679a43f93ebf8b5165a4c9c8d794c (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4960 txn/s, latency: 6637 ms, (p50: 6900 ms, p90: 9900 ms, p99: 11100 ms), latency samples: 183540
2. Upgrading first Validator to new version: fa66e2bec67679a43f93ebf8b5165a4c9c8d794c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1766 txn/s, latency: 15796 ms, (p50: 19200 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 91880
3. Upgrading rest of first batch to new version: fa66e2bec67679a43f93ebf8b5165a4c9c8d794c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1768 txn/s, latency: 16480 ms, (p50: 19100 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 88400
4. upgrading second batch to new version: fa66e2bec67679a43f93ebf8b5165a4c9c8d794c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3651 txn/s, latency: 8771 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12600 ms), latency samples: 142420
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> fa66e2bec67679a43f93ebf8b5165a4c9c8d794c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on fa66e2bec67679a43f93ebf8b5165a4c9c8d794c

two traffics test: inner traffic : committed: 7380 txn/s, latency: 5189 ms, (p50: 4800 ms, p90: 6500 ms, p99: 12900 ms), latency samples: 3188320
two traffics test : committed: 100 txn/s, latency: 2388 ms, (p50: 2100 ms, p90: 2600 ms, p99: 9400 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.204", "QsPosToProposal: max: 0.299, avg: 0.173", "ConsensusProposalToOrdered: max: 0.625, avg: 0.561", "ConsensusOrderedToCommit: max: 0.528, avg: 0.497", "ConsensusProposalToCommit: max: 1.097, avg: 1.058"]
Max round gap was 1 [limit 4] at version 1505682. Max no progress secs was 4.618017 [limit 15] at version 1505682.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Test runner output
• Test run is land-blocking