Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FatalVMError shouldn't create "Delayed materialization code invariant" #12044

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

igor-aptos
Copy link
Contributor

@igor-aptos igor-aptos commented Feb 15, 2024

  • when FatalVMError happens, we have those logs, it doesn't get wrapped into delayed materialization code invariant error
  • do not alert on FatalVMError - if it is invariant - it is already alerted, if it is node issue (i.e. old binary so VM_STARTUP_FAILURE) alert is too aggressive

Description

Test Plan

Copy link

trunk-io bot commented Feb 15, 2024

⏱️ 13h 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 3h 32m 🟩🟩🟩🟩
rust-smoke-tests 1h 56m 🟩🟩🟩🟩
windows-build 1h 19m 🟩🟩🟩🟩🟩
execution-performance / single-node-performance 1h 18m 🟩🟩🟩🟩
forge-e2e-test / forge 1h 1m 🟩🟩🟩🟩
rust-images / rust-all 48m 🟩🟩🟩🟩
forge-compat-test / forge 47m 🟩🟥🟥🟩
rust-lints 35m 🟥🟥🟩🟩🟩
cli-e2e-tests / run-cli-tests 35m 🟥🟥🟥🟥
run-tests-main-branch 26m 🟥🟥🟥🟥🟥
check 20m 🟩🟩🟩🟩🟩
general-lints 13m 🟩🟩🟩🟩🟩
check-dynamic-deps 13m 🟩🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 3m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 54s 🟩🟩🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩🟩
file_change_determinator 46s 🟩🟩🟩🟩
execution-performance / file_change_determinator 38s 🟩🟩🟩🟩
permission-check 23s 🟩🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 9s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 9m 6m +37%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos enabled auto-merge (squash) February 15, 2024 21:58

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/distinguish_vm_errors_parallel branch from 46082f3 to 48c3230 Compare February 15, 2024 23:29

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/distinguish_vm_errors_parallel branch from 48c3230 to 6c5cd6d Compare February 16, 2024 00:09

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/distinguish_vm_errors_parallel branch from 6c5cd6d to f1eb60b Compare February 16, 2024 03:37

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on testnet ==> f1eb60bfaee81703181b3985cb289e983a5195af

Compatibility test results for testnet ==> f1eb60bfaee81703181b3985cb289e983a5195af (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : committed: 6840 txn/s, latency: 4879 ms, (p50: 4800 ms, p90: 7800 ms, p99: 9000 ms), latency samples: 239400
2. Upgrading first Validator to new version: f1eb60bfaee81703181b3985cb289e983a5195af
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 588 txn/s, submitted: 641 txn/s, expired: 52 txn/s, latency: 36389 ms, (p50: 40000 ms, p90: 59200 ms, p99: 60700 ms), latency samples: 51766
3. Upgrading rest of first batch to new version: f1eb60bfaee81703181b3985cb289e983a5195af
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 386 txn/s, submitted: 695 txn/s, expired: 308 txn/s, latency: 33089 ms, (p50: 32000 ms, p90: 56300 ms, p99: 58700 ms), latency samples: 26668
4. upgrading second batch to new version: f1eb60bfaee81703181b3985cb289e983a5195af
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2993 txn/s, latency: 10216 ms, (p50: 12600 ms, p90: 14700 ms, p99: 15900 ms), latency samples: 131700
5. check swarm health
Compatibility test for testnet ==> f1eb60bfaee81703181b3985cb289e983a5195af passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f1eb60bfaee81703181b3985cb289e983a5195af

two traffics test: inner traffic : committed: 7519 txn/s, latency: 5064 ms, (p50: 4500 ms, p90: 6300 ms, p99: 13500 ms), latency samples: 3248380
two traffics test : committed: 100 txn/s, latency: 2292 ms, (p50: 2100 ms, p90: 2500 ms, p99: 10500 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.257, avg: 0.215", "QsPosToProposal: max: 0.178, avg: 0.150", "ConsensusProposalToOrdered: max: 0.599, avg: 0.553", "ConsensusOrderedToCommit: max: 0.480, avg: 0.453", "ConsensusProposalToCommit: max: 1.042, avg: 1.006"]
Max round gap was 1 [limit 4] at version 1525689. Max no progress secs was 10.010251 [limit 15] at version 1525689.
Test Ok

@igor-aptos igor-aptos merged commit 7a7ba82 into main Feb 16, 2024
42 of 43 checks passed
@igor-aptos igor-aptos deleted the igor/distinguish_vm_errors_parallel branch February 16, 2024 04:07
danielxiangzl added a commit that referenced this pull request Feb 16, 2024
* clean error log lines (#12019)

* [table info][2/4] add utils for table info backup and restore and redesign the db read (#11793)

* separate indexer async v2 db from aptosdb

* address comments

* add utils for table info backup and restore and redesign the db read

* address comments to spawn block sync file ops

* address comments

* tests for events and improve event v1 handling (#12012)

* [move-vm] Cache verified modules (#12002)

* [move-vm] Cache verified modules

* fixup! [move-vm] Cache verified modules

* [passkey] Add MAX_BYTES limit for signatures (#11697)

* [passkey] Add MAX_BYTES limit for signatures

* [passkey] Add tracing for AssertionSignature type and fix README

* [passkey] Rebased on latest main, rerun authenticator_regenerate.sh

* Object Code Deployment module with CLI commands generated (#11748)

* [simple] rename RG split in VmChangeSet flag (#12027)

* rename RG split in VmChangeSet flag

old name was stale, when charging was different

* [fuzzing] fixes oss-fuzz FP and fuzz.sh (#12030)

* [fuzzing] fixes oss-fuzz FP and fuzz.sh

* Update Docker images (#12026)

Co-authored-by: sionescu <sionescu@users.noreply.github.com>

* Update release.yaml (#12020)

* Update release.yaml

* enable REFUNDABLE_BYTES

* enable FairnessShuffler

* enable WEBAUTHN_SIGNATURE

* AIP-54 Object Code Deployment release addition

* enable vtxn and jwk consensus

* Update release.yaml

adding aggregators v2 flags, and updating execution onchain config

* add feature flag for zkID (ZK-only mode)

* fix jwk/zkid entries in release yaml 1.10 (#12024)

* update

* update

* Update release.yaml

fix flag name

* Update release.yaml

rename feature

---------

Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: hariria <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: zhoujunma <zjma@users.noreply.github.com>

* Cherry-pick VM changes (#12021)

* [gas] add gas charges for type creation

* [gas-calibration] Add calibration sample

* [move-vm] Implement a per-frame cache for paranoid mode

* fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* [gas] add gas charges for dependencies

---------

Co-authored-by: Runtian Zhou <runtian@aptoslabs.com>

* trivial doc fix

* [GHA] Upgrade actions/checkout to v4

* jwk ob counters (#12048)

* Revert "[GHA] Upgrade actions/checkout to v4"

This reverts commit 04d078f.

* [CI][indexer] fix the e2e localnet. (#12047)

* fix the e2e localnet.

* fix the e2e localnet.

* bump latest gas feature version to 14

Also be conservative and leave legacy parameters in >14 versions for
now. Need to clean up after REFUNDABLE_BYTES feature is actually enabled
on all networks.

* compat test to be against the testnet tag

* [GHA] Upgrade lint-test.yaml and the dependent actions to checkout@v4

actions/checkout@v4 doesn't behave well if both a workflow and an
invoked action checkout the source code on top of each other.

* [GHA] Update pin for tj-actions/changed-files

* start jwk consensus for google (#12053)

* [consensus] check rpc epoch in epoch_manager (#12018)

* [consensus] check rpc epoch in epoch_manager

* fix gas version (13 is deprecated/cannot be used) (#12064)

* FatalVMError shouldn't create "Delayed materialization code invariant" (#12044)

* Move all visibility checking into AST-level function_checker, simplify that code a bit, and improve diagnostics. (#11948)

* rust changes to move all visibility checking to AST and clean it up a bit
* change `Known attribute ... position` warning to a neater `Attribute .. position` warning
* add FunctionData id_loc to allow pointing at function name in declaration for more concise error messages. abstract messages a bit in function_checker
* add 'inlined from' labels to diagnostics with labels, fix bug in function_checker to enable post-inlining visibility checking

* lint

* fix for small stakes

* assert

---------

Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: jill <121921928+jillxuu@users.noreply.github.com>
Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com>
Co-authored-by: runtianz <runtian@aptoslabs.com>
Co-authored-by: Andrew Hariri <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: Gerardo Di Giacomo <gerardo@aptoslabs.com>
Co-authored-by: sionescu <sionescu@users.noreply.github.com>
Co-authored-by: Junkil Park <jpark@aptoslabs.com>
Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: Victor Gao <10379359+vgao1996@users.noreply.github.com>
Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com>
Co-authored-by: Stelian Ionescu <sionescu@cddr.org>
Co-authored-by: larry-aptos <112209412+larry-aptos@users.noreply.github.com>
Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
Co-authored-by: Brian R. Murphy <132495859+brmataptos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants