Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuzzing] fixes oss-fuzz FP and fuzz.sh #12030

Merged
merged 2 commits into from
Feb 15, 2024
Merged

[fuzzing] fixes oss-fuzz FP and fuzz.sh #12030

merged 2 commits into from
Feb 15, 2024

Conversation

gedigi
Copy link
Contributor

@gedigi gedigi commented Feb 15, 2024

Description

This PR:

  • fixes a false positive generated by the move_aptosvm_publish_and_run fuzzer
  • fixes minor bugs in fuzz.sh

Test Plan

the move_aptosvm_publish_and_run fuzzer is tested not to crash with this testcase.

@gedigi gedigi requested a review from zi0Black February 15, 2024 02:04
Copy link

trunk-io bot commented Feb 15, 2024

@gedigi gedigi requested a review from a team February 15, 2024 02:04
@gedigi gedigi requested a review from a team February 15, 2024 02:12
@gedigi gedigi enabled auto-merge (squash) February 15, 2024 15:59

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 7705cfe7a98fcd6d1df6921fa298080ad925e957

Compatibility test results for aptos-node-v1.8.3 ==> 7705cfe7a98fcd6d1df6921fa298080ad925e957 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3324 txn/s, latency: 6362 ms, (p50: 6300 ms, p90: 9300 ms, p99: 14700 ms), latency samples: 192820
2. Upgrading first Validator to new version: 7705cfe7a98fcd6d1df6921fa298080ad925e957
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1840 txn/s, latency: 15721 ms, (p50: 18700 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 92020
3. Upgrading rest of first batch to new version: 7705cfe7a98fcd6d1df6921fa298080ad925e957
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1830 txn/s, latency: 15908 ms, (p50: 18700 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 91540
4. upgrading second batch to new version: 7705cfe7a98fcd6d1df6921fa298080ad925e957
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3701 txn/s, latency: 8696 ms, (p50: 9900 ms, p90: 12100 ms, p99: 12400 ms), latency samples: 144340
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 7705cfe7a98fcd6d1df6921fa298080ad925e957 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7705cfe7a98fcd6d1df6921fa298080ad925e957

two traffics test: inner traffic : committed: 7739 txn/s, latency: 4934 ms, (p50: 4500 ms, p90: 6100 ms, p99: 10800 ms), latency samples: 3343620
two traffics test : committed: 100 txn/s, latency: 2153 ms, (p50: 2100 ms, p90: 2400 ms, p99: 4900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.234, avg: 0.204", "QsPosToProposal: max: 0.172, avg: 0.147", "ConsensusProposalToOrdered: max: 0.574, avg: 0.526", "ConsensusOrderedToCommit: max: 0.462, avg: 0.447", "ConsensusProposalToCommit: max: 0.993, avg: 0.973"]
Max round gap was 1 [limit 4] at version 1512772. Max no progress secs was 4.642138 [limit 15] at version 1512772.
Test Ok

@gedigi gedigi merged commit 2218beb into main Feb 15, 2024
81 of 82 checks passed
@gedigi gedigi deleted the gdg/fuzz-fix branch February 15, 2024 16:35
danielxiangzl added a commit that referenced this pull request Feb 16, 2024
* clean error log lines (#12019)

* [table info][2/4] add utils for table info backup and restore and redesign the db read (#11793)

* separate indexer async v2 db from aptosdb

* address comments

* add utils for table info backup and restore and redesign the db read

* address comments to spawn block sync file ops

* address comments

* tests for events and improve event v1 handling (#12012)

* [move-vm] Cache verified modules (#12002)

* [move-vm] Cache verified modules

* fixup! [move-vm] Cache verified modules

* [passkey] Add MAX_BYTES limit for signatures (#11697)

* [passkey] Add MAX_BYTES limit for signatures

* [passkey] Add tracing for AssertionSignature type and fix README

* [passkey] Rebased on latest main, rerun authenticator_regenerate.sh

* Object Code Deployment module with CLI commands generated (#11748)

* [simple] rename RG split in VmChangeSet flag (#12027)

* rename RG split in VmChangeSet flag

old name was stale, when charging was different

* [fuzzing] fixes oss-fuzz FP and fuzz.sh (#12030)

* [fuzzing] fixes oss-fuzz FP and fuzz.sh

* Update Docker images (#12026)

Co-authored-by: sionescu <sionescu@users.noreply.github.com>

* Update release.yaml (#12020)

* Update release.yaml

* enable REFUNDABLE_BYTES

* enable FairnessShuffler

* enable WEBAUTHN_SIGNATURE

* AIP-54 Object Code Deployment release addition

* enable vtxn and jwk consensus

* Update release.yaml

adding aggregators v2 flags, and updating execution onchain config

* add feature flag for zkID (ZK-only mode)

* fix jwk/zkid entries in release yaml 1.10 (#12024)

* update

* update

* Update release.yaml

fix flag name

* Update release.yaml

rename feature

---------

Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: hariria <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: zhoujunma <zjma@users.noreply.github.com>

* Cherry-pick VM changes (#12021)

* [gas] add gas charges for type creation

* [gas-calibration] Add calibration sample

* [move-vm] Implement a per-frame cache for paranoid mode

* fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* fixup! fixup! fixup! fixup! [move-vm] Implement a per-frame cache for paranoid mode

* [gas] add gas charges for dependencies

---------

Co-authored-by: Runtian Zhou <runtian@aptoslabs.com>

* trivial doc fix

* [GHA] Upgrade actions/checkout to v4

* jwk ob counters (#12048)

* Revert "[GHA] Upgrade actions/checkout to v4"

This reverts commit 04d078f.

* [CI][indexer] fix the e2e localnet. (#12047)

* fix the e2e localnet.

* fix the e2e localnet.

* bump latest gas feature version to 14

Also be conservative and leave legacy parameters in >14 versions for
now. Need to clean up after REFUNDABLE_BYTES feature is actually enabled
on all networks.

* compat test to be against the testnet tag

* [GHA] Upgrade lint-test.yaml and the dependent actions to checkout@v4

actions/checkout@v4 doesn't behave well if both a workflow and an
invoked action checkout the source code on top of each other.

* [GHA] Update pin for tj-actions/changed-files

* start jwk consensus for google (#12053)

* [consensus] check rpc epoch in epoch_manager (#12018)

* [consensus] check rpc epoch in epoch_manager

* fix gas version (13 is deprecated/cannot be used) (#12064)

* FatalVMError shouldn't create "Delayed materialization code invariant" (#12044)

* Move all visibility checking into AST-level function_checker, simplify that code a bit, and improve diagnostics. (#11948)

* rust changes to move all visibility checking to AST and clean it up a bit
* change `Known attribute ... position` warning to a neater `Attribute .. position` warning
* add FunctionData id_loc to allow pointing at function name in declaration for more concise error messages. abstract messages a bit in function_checker
* add 'inlined from' labels to diagnostics with labels, fix bug in function_checker to enable post-inlining visibility checking

* lint

* fix for small stakes

* assert

---------

Co-authored-by: igor-aptos <110557261+igor-aptos@users.noreply.github.com>
Co-authored-by: jill <121921928+jillxuu@users.noreply.github.com>
Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com>
Co-authored-by: runtianz <runtian@aptoslabs.com>
Co-authored-by: Andrew Hariri <hariria@usc.edu>
Co-authored-by: John Chang <johnchang9094@gmail.com>
Co-authored-by: Gerardo Di Giacomo <gerardo@aptoslabs.com>
Co-authored-by: sionescu <sionescu@users.noreply.github.com>
Co-authored-by: Junkil Park <jpark@aptoslabs.com>
Co-authored-by: aldenhu <msmouse@gmail.com>
Co-authored-by: danielxiangzl <xiangzhuolun@gmail.com>
Co-authored-by: Alin Tomescu <tomescu.alin@gmail.com>
Co-authored-by: Victor Gao <10379359+vgao1996@users.noreply.github.com>
Co-authored-by: Stelian Ionescu <stelian@aptoslabs.com>
Co-authored-by: Stelian Ionescu <sionescu@cddr.org>
Co-authored-by: larry-aptos <112209412+larry-aptos@users.noreply.github.com>
Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
Co-authored-by: Brian R. Murphy <132495859+brmataptos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants