[move][aptos-vm] Addressing comments

[georgemitenkov]

Description

Addressing comments from #14206.

1. ScriptStorage is now CodeStorage: ModuleStorage. After all, you cannot have scripts without modules, I guess, most of the time. Interfaces updated to take a single parameter only, either module or code storage.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 4h 41m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	22m	🟩
general-lints	18m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-cargo-deny	17m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-move-unit-coverage	16m	🟩
rust-move-unit-coverage	14m	🟩
rust-move-tests	14m	🟥
rust-move-tests	14m	🟥
rust-move-tests	14m	🟥
rust-move-tests	14m	🟥
rust-move-tests	13m	🟥
rust-move-tests	13m	🟥
rust-move-tests	13m	🟥
check-dynamic-deps	13m	🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-move-unit-coverage	13m	🟩
rust-move-unit-coverage	12m	🟩
rust-move-tests	10m	⬜
rust-move-unit-coverage	10m	⬜
rust-move-unit-coverage	9m	🟩
rust-move-unit-coverage	8m	🟩
rust-move-unit-coverage	8m	🟩
rust-move-unit-coverage	4m	🟥
semgrep/ci	4m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-move-tests	3m	🟥
rust-move-tests	2m	🟥
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+5 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check	35s	🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check	32s	🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check	25s	🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check	25s	🟩 🟩 🟩 🟩 🟩 (+5 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[georgemitenkov]

• [aptos-vm] Fixed previous size calculation for modules #14408
• [move][aptos-vm] Addressing comments #14402 👈
• [move] Fixing unit tests for loader V2 #14397 : 1 other dependent PR (#14001 )
• [move][aptos-vm] End-to-end module publishing #14395
• Introduce code cache and loader V2 #14184 : 6 other dependent PRs (#14075 , #14206 , #14341 and 3 others)
• [move] Change interpreter to use loaded func and improve scoping #14185
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 17.75148% with 139 lines in your changes missing coverage. Please review.

Please upload report for BASE (george/fixing-tests@25e70f1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
aptos-move/aptos-vm/src/aptos_vm.rs	0.0%	68 Missing ⚠️
...rc/module_and_script_storage/state_view_adapter.rs	0.0%	12 Missing ⚠️
...n/user_transaction_sessions/session_change_sets.rs	0.0%	12 Missing ⚠️
aptos-move/aptos-vm-types/src/module_write_set.rs	0.0%	9 Missing ⚠️
...d_party/move/move-vm/runtime/src/storage/loader.rs	0.0%	9 Missing ⚠️
...es/src/module_and_script_storage/module_storage.rs	0.0%	6 Missing ⚠️
aptos-move/aptos-gas-meter/src/traits.rs	0.0%	5 Missing ⚠️
third_party/move/move-vm/runtime/src/session.rs	33.3%	4 Missing ⚠️
...tos-move/aptos-vm/src/block_executor/vm_wrapper.rs	0.0%	3 Missing ⚠️
third_party/move/move-vm/runtime/src/loader/mod.rs	25.0%	3 Missing ⚠️
... and 3 more

Additional details and impacted files

@@                  Coverage Diff                   @@
##             george/fixing-tests   #14402   +/-   ##
======================================================
  Coverage                       ?    59.5%           
======================================================
  Files                          ?      856           
  Lines                          ?   208735           
  Branches                       ?        0           
======================================================
  Hits                           ?   124344           
  Misses                         ?    84391           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[runtian-zhou]

Looks like a nice clean up to me