-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[block-stm] Integrate script caches #14472
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @georgemitenkov and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## george/main #14472 +/- ##
==============================================
Coverage ? 59.4%
==============================================
Files ? 857
Lines ? 209210
Branches ? 0
==============================================
Hits ? 124434
Misses ? 84776
Partials ? 0 ☔ View full report in Codecov by Sentry. |
c30b7a8
to
54658bc
Compare
6bdeb02
to
d90a9ee
Compare
54658bc
to
c3f1757
Compare
03515a0
to
a5e7ca6
Compare
b3805a6
to
b4aef0c
Compare
a5e7ca6
to
1a55481
Compare
b4aef0c
to
b437e06
Compare
1a55481
to
97c24d7
Compare
b437e06
to
0c41712
Compare
97c24d7
to
49d88e4
Compare
0c41712
to
a284380
Compare
49d88e4
to
c01635f
Compare
a284380
to
333be8f
Compare
c01635f
to
687c31a
Compare
333be8f
to
6ae08f6
Compare
687c31a
to
ddcdc41
Compare
6ae08f6
to
0b4adb8
Compare
ddcdc41
to
0e72671
Compare
Description
This completes Block-STM integration for the code cache by adding an implementation to deserialize/verify and cache scripts. Right now, we opt for a very basic policy of:
We can revisit this in later PRs, but for now it suffices to get things running. Correctness is guaranteed because we publish at commit time, and so if there is a txn with a script that used older versions of code, it will be invalidated since there will be at least a single module dependency that gets loaded and is invalidated.
Other:
is_none()
got replaced byis_some()
.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
For tests, see the PR stacked on top.
Key Areas to Review
Checklist