-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aptos-vm] Fixed previous size calculation for modules #14408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 49m total CI duration on this PR
|
This was referenced Aug 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @georgemitenkov and the rest of your teammates on Graphite |
21 tasks
georgemitenkov
requested review from
runtian-zhou,
vgao1996,
gelash,
zekun000 and
ziaptos
August 25, 2024 17:09
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
August 25, 2024 17:39
a95271f
to
208c298
Compare
georgemitenkov
requested review from
gregnazario,
banool,
movekevin,
alinush and
heliuchuan
as code owners
August 25, 2024 17:39
georgemitenkov
force-pushed
the
george/prev-module-size
branch
2 times, most recently
from
August 25, 2024 20:53
93f60c5
to
5c665d5
Compare
gelash
approved these changes
Aug 26, 2024
This was referenced Aug 30, 2024
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 1, 2024 15:21
82cef15
to
43c3ed0
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 1, 2024 15:22
5c665d5
to
028d317
Compare
This was referenced Sep 2, 2024
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 4, 2024 08:00
43c3ed0
to
135922e
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 4, 2024 08:00
028d317
to
a333f3e
Compare
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 4, 2024 18:37
135922e
to
35270ca
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 4, 2024 18:37
a333f3e
to
bee51ae
Compare
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 5, 2024 21:11
35270ca
to
ff680fe
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 5, 2024 21:11
bee51ae
to
52a6c52
Compare
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 5, 2024 21:45
ff680fe
to
d357e6a
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 5, 2024 21:45
52a6c52
to
e09437f
Compare
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 5, 2024 21:48
d357e6a
to
b1eb6e8
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 5, 2024 21:48
e09437f
to
8de880d
Compare
georgemitenkov
force-pushed
the
george/comments-14206
branch
from
September 5, 2024 21:59
b1eb6e8
to
1f36817
Compare
georgemitenkov
force-pushed
the
george/prev-module-size
branch
from
September 5, 2024 21:59
8de880d
to
6589b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR connects previous size calculation for write ops with new module storage interfaces. The fact that we need to pass
&impl AptosModuleStorage
even if there are no modules is ugly, but we can live with this for now :)Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist