Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aptos-vm] Fixed previous size calculation for modules #14408

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Aug 24, 2024

Description

This PR connects previous size calculation for write ops with new module storage interfaces. The fact that we need to pass &impl AptosModuleStorage even if there are no modules is ugly, but we can live with this for now :)

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Aug 24, 2024

⏱️ 49m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟥
rust-move-tests 13m 🟥
rust-move-tests 6m 🟥
general-lints 5m 🟩🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
check-dynamic-deps 4m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Aug 24, 2024

@georgemitenkov georgemitenkov merged commit ebd4636 into george/comments-14206 Sep 5, 2024
41 of 47 checks passed
@georgemitenkov georgemitenkov deleted the george/prev-module-size branch September 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants