[loader] Enable V2 implementation as default, V1 uses an env var

[georgemitenkov]

Description

1. Enables V2 loader as default implementation in features and VM configs.
2. AptosVM module publish validation is applied to both V1 and V2 now. While V2 implementation allows for hooks so that validate_publish_request runs after bytecode verifier, we keep this as is for now to run tests and minimize the divergence in behaviour.
3. Fixed genesis module publishing for V2 flow. V1 was actually broken but worked because of loader cache :/
4. Fixed init module where the user session changes were not found in init_module temporary session.
5. Fixed runtime environment sharing to allow for multiple versions (like with warm VM cache).
6. Fixed a few tests failures due to error messages/error codes.

Note: proptests for Block-STM for module publishing are still broken.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 14h 9m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	3h 45m	🟥 🟥 🟥 🟥 🟥 (+2 more)
forge-compat-test / forge	1h 5m	🟩 🟩 🟩 🟥
forge-e2e-test / forge	1h 4m	🟥 🟥 🟥 🟥
check-dynamic-deps	40m	🟩 🟩 🟩 🟩 ⬜ (+16 more)
general-lints	34m	🟩 🟩 🟩 🟩 🟩 (+14 more)
rust-cargo-deny	33m	🟩 🟩 🟩 🟩 🟩 (+14 more)
execution-performance / test-target-determinator	32m	🟩 🟩 🟩 🟩 🟩 (+2 more)
test-target-determinator	25m	🟩 🟩 🟩 🟩 🟩
check	21m	🟩 🟩 ⬜ 🟩 🟩 (+1 more)
rust-move-unit-coverage	16m	🟩
rust-move-unit-coverage	13m	🟩
rust-move-unit-coverage	13m	🟩
rust-move-unit-coverage	13m	🟩
rust-move-unit-coverage	12m	🟩
rust-move-tests	10m	🟥
rust-move-tests	10m	🟩
rust-move-unit-coverage	9m	🟩
rust-move-tests	9m	🟩
rust-move-unit-coverage	9m	🟩
rust-move-tests	9m	🟥
rust-move-tests	9m	🟩
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-move-tests	9m	🟩
rust-move-tests	8m	🟥
semgrep/ci	8m	🟩 🟩 🟩 🟩 🟩 (+16 more)
rust-move-unit-coverage	8m	🟩
rust-move-unit-coverage	8m	🟩
rust-move-tests	8m	🟥
rust-move-tests	7m	⬜
rust-move-unit-coverage	7m	🟩
rust-move-unit-coverage	7m	🟩
rust-smoke-tests	7m	⬜
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	7m	🟩 🟩 🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-doc-tests	5m	🟩
rust-move-unit-coverage	4m	🟥
file_change_determinator	4m	🟩 🟩 🟩 🟩 🟩 (+14 more)
file_change_determinator	4m	🟩 🟩 🟩 🟩 🟩 (+15 more)
rust-move-unit-coverage	4m	🟥
rust-move-unit-coverage	4m	⬜
rust-move-unit-coverage	3m	🟥
rust-move-unit-coverage	3m	🟥
rust-move-tests	3m	🟥
rust-move-unit-coverage	3m	🟥
rust-move-unit-coverage	3m	⬜
rust-move-tests	3m	🟥
rust-move-tests	3m	⬜
rust-move-tests	3m	🟥
rust-move-tests	3m	🟥
rust-move-tests	3m	🟥
rust-move-tests	2m	🟥
rust-move-tests	2m	⬜
permission-check	1m	🟩 🟩 🟩 🟩 🟩 (+15 more)
permission-check	1m	🟩 🟩 🟩 🟩 🟩 (+16 more)
permission-check	1m	🟩 🟩 🟩 🟩 🟩 (+16 more)
permission-check	1m	🟩 🟩 🟩 🟩 🟩 (+15 more)
file_change_determinator	56s	🟩 🟩 🟩 🟩 🟩
permission-check	20s	🟩 🟩 🟩
Backport PR	18s	🟥 🟥 🟥
permission-check	14s	🟩 🟩 🟩 🟩 🟩
determine-docker-build-metadata	12s	🟩 🟩 🟩 🟩 🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
check-dynamic-deps	18m	1m
check	6m	4m
test-target-determinator	7m	5m
execution-performance / test-target-determinator	7m	5m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[georgemitenkov]

• [move] Improve & test struct index map #14507
• [loader-v2] Addressing some loader TODOs and performance issues #14495
• [loader] Enable V2 implementation as default, V1 uses an env var #14473 👈
• [block-stm] Integrate script caches #14472
• [block-stm] Versioned module storage template #14001
• [move] Fixing unit tests for loader V2 #14397 : 1 other dependent PR (#14402 )
• [move][aptos-vm] End-to-end module publishing #14395
• Introduce code cache and loader V2 #14184 : 6 other dependent PRs (#14075 , #14206 , #14341 and 3 others)
• [move] Change interpreter to use loaded func and improve scoping #14185
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 35.54633% with 466 lines in your changes missing coverage. Please review.

Please upload report for BASE (george/main@e9f53e6). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
aptos-move/aptos-vm/src/aptos_vm.rs	0.0%	158 Missing ⚠️
...e_vm_ext/session/user_transaction_sessions/user.rs	0.0%	96 Missing ⚠️
...tos-move/aptos-vm/src/move_vm_ext/warm_vm_cache.rs	0.0%	47 Missing ⚠️
...ptos-move/aptos-vm/src/verifier/resource_groups.rs	0.0%	43 Missing ⚠️
...tos-move/aptos-vm/src/verifier/event_validation.rs	0.0%	29 Missing ⚠️
aptos-move/aptos-vm/src/move_vm_ext/vm.rs	0.0%	20 Missing ⚠️
third_party/move/move-vm/runtime/src/loader/mod.rs	42.4%	19 Missing ⚠️
...ty/move/move-vm/runtime/src/storage/environment.rs	68.8%	19 Missing ⚠️
...tos-move/block-executor/src/modules_and_scripts.rs	0.0%	11 Missing ⚠️
types/src/vm/modules.rs	0.0%	7 Missing ⚠️
... and 9 more

Additional details and impacted files

@@              Coverage Diff               @@
##             george/main   #14473   +/-   ##
==============================================
  Coverage               ?    58.9%           
==============================================
  Files                  ?      858           
  Lines                  ?   209460           
  Branches               ?        0           
==============================================
  Hits                   ?   123570           
  Misses                 ?    85890           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.