Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.41.4 #8737

Closed
wants to merge 18 commits into from
Closed

Release v0.41.4 #8737

wants to merge 18 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 1, 2021 •
edited
Loading

closes: #8715

DON'T MERGE THIS QUITE YET, please

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

mergify bot and others added 14 commits February 22, 2021 11:52
@mergify @colin-axner
Update baseapp docs (#8630) (#8644)
bdec113 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@atheeshp
backport: x/{auth, bank, distr} docs basic cleanup (#8268) (#8304)
ba8de90
@mergify @alexanderbez
server: fix interceptConfigs (bp #8641) (#8659)
02aa30e 
From: #8641

Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
@mergify @lovincyrus
docs: update master docs (bp #8353) (#8672)
819af54 
* docs: update master docs (#8353)

* bump docs theme to 1.0.180

* add v0.40 to config.js versions

* Fix code snippet link

* reorganize order of versions
* 0.39, 0.41, master
* defaulting to 0.41

Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 4c70268)

# Conflicts:
#	docs/package-lock.json

* rm package-lock.json, reinstall

Co-authored-by: Cyrus Goh <hello@lovincyrus.com>
@mergify
Add multisign batch command (bp #7787) (#8691)
7060935 
From #7787
Thanks: @sahith-narahari
@mergify
update tendermint to v0.34.8 (#8701) (#8702)
72cfca1 
(cherry picked from commit 5d3f29b)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
@mergify @amaury1093
docs: Add mention to use gRPC v1.33.2 (#8658) (#8699)
e766410 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit eeb3eab)

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@mergify @clevinson
Add warning notice in changelog for v0.41.x bug (ref: #8461) (bp #8707)…
50744f8 
… (#8708)

* Add warning notice in changelog for v0.41.x bug (ref: #8461) (#8707)

* add disclaimer for v0.41 series for non-hub SDK chains due to #8461

(cherry picked from commit b19ac2c)

Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
@mergify @anilcse
@aleem1314 @tac0turtle
fix REST endpoints in migration docs (bp #8648) (#8687)
ce82077 
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
(cherry picked from commit 897f20b)
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@mergify @tac0turtle
auth: allow 0 coin accounts in genesis (bp #8714) (#8716)
16fbb50 
* auth: allow 0 coin accounts in genesis (#8714)

* allow zero accounts

* fix test

* fix test

(cherry picked from commit a786830)

Co-authored-by: Marko <marbar3778@yahoo.com>
@mergify
fix: per 8711 fix typo and minor command text edit for multi sign bat…
2e60065 
…ch command (#8718) (#8721)

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
(cherry picked from commit 68e7a3a)

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@zmanian @odeke-em @fedekunze
Backport genesis speed ups to 0.41.x (#8722)
5a6b846 
From: #8719
Fixes: #7766

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@amaury1093 @robert-zaremba
Use x/auth/client for querying Txs (#8732)
0e0e5e9 
* Use x/auth/client for querying Txs

* Fix lint

* Fix small test

* update comment

* Fix tests

* Fix test

* Update x/auth/tx/service.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Remove context.background

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@mergify @amaury1093
Allow REST endpoint to query txs with multisig (bp #8730) (#8731)
b8134c1 
(cherry picked from commit 3832860)

From: #8730

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
tac0turtle
tac0turtle approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

tac0turtle
tac0turtle requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking to allow other prs to land

shahankhatch
shahankhatch approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@shahankhatch shahankhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

amaury1093
amaury1093 suggested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions: what is the purpose of the release/0.41.4 branch? Is it long-living?

Most importantly, why are we not doing the same thing as for previous 0.41.* releases, i.e. tagging off v0.41.4 off the long-living branch release/v0.41.x?

@tac0turtle
Copy link
Member

I have questions: what is the purpose of the release/0.41.4 branch? Is it long-living?

Most importantly, why are we not doing the same thing as for previous 0.41.* releases, i.e. tagging off v0.41.4 off the long-living branch release/v0.41.x?

This does follow the release procedure outlined on the contributing: https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#point-release-procedure. It doesn't seem the 0.41 line has been following this practice. If something has changed and the doc hasn't been updated then it should be

@amaury1093
Copy link
Contributor

This does follow the release procedure outlined on the contributing: https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#point-release-procedure. It doesn't seem the 0.41 line has been following this practice. If something has changed and the doc hasn't been updated then it should be

That doc should definitely be updated (cc @clevinson for visibility) 👍, they are not even up-to-date for launchpad.

@alessio my understanding is that we agreed in the internal Release Comittee discord chat (from a couple weeks/months ago, re Stargate) to tag releases off the release/* long-living branch, can you confirm?

@alessio
Copy link
Contributor Author

alessio commented Mar 2, 2021 •
edited
Loading

Yes I confirm. I opened up this PR to display the CI status and check on the simulations. This PR will not be merged.

@sahith-narahari @jgimeno @amaury1093
crypto/keyring: fix offline keys migration (#8738)
ba3ac53 
* crypto/keyring: fix offline keys migration (#8639)

Fix `keys migrate` command (#8703)

crypto/keyring: reinstate the InfoImporter interface

InfoImporter is implemented by those Keyring implementations
that support import of Info objects.

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* refresh golangci-lint

* Rename InfoImporter -> LegacyInfoImporter (#8739)

Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.

* Revert "refresh golangci-lint"

This reverts commit 38e1349.

Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@fdymylja
Copy link
Contributor

fdymylja commented Mar 2, 2021

I have a doubt, isn't the 0 balance change in genesis breaking?

@marbar3778 @AmauryM @alessio

@tac0turtle
Copy link
Member

I have a doubt, isn't the 0 balance change in genesis breaking?

@marbar3778 @AmauryM @alessio

This is only a check. It doesnt alter state. Could you touch on how you see it as breaking?

@fdymylja
Copy link
Contributor

fdymylja commented Mar 2, 2021

This is only a check. It doesnt alter state. Could you touch on how you see it as breaking?

I don't have much context because I haven't digged in the issue, but if before it failed (panicked, or returned errors) and now it doesn't then IMO it is breaking. Because something that should have failed does not fail anymore.

I don't expect any sdk user to rely on this logic, but still.

@mergify @tac0turtle
further reduce logging (#8752) (#8753)
4afd4f4 
(cherry picked from commit 8106056)

Co-authored-by: Marko <marbar3778@yahoo.com>
@sahith-narahari
Copy link
Contributor

This is only a check. It doesnt alter state. Could you touch on how you see it as breaking?

I don't have much context because I haven't digged in the issue, but if before it failed (panicked, or returned errors) and now it doesn't then IO it is breaking. Because something that should have failed does not fail anymore.

I don't expect any sdk user to rely on this logic, but still.

I don't think it's a breaking change, it just alters the response of a command line utility. wdyt?

amaury1093
amaury1093 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got clarification with Alessio, the release/0.41.4 branch will be deleted once 0.41.4 is out.

@alessio
Copy link
Contributor Author

alessio commented Mar 2, 2021

Closing and releasing.

Thank you all for the great effort. Keep up the great work!

@alessio alessio closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian zmanian approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@jgimeno jgimeno jgimeno approved these changes

@shahankhatch shahankhatch shahankhatch approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@fdymylja fdymylja Awaiting requested review from fdymylja

@gsora gsora Awaiting requested review from gsora

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@alessio @tac0turtle @amaury1093 @fdymylja @sahith-narahari @zmanian @jgimeno @shahankhatch @atheeshp