Use Directory.CreateTempSubdirectory

[eerhardt]

The advantage here is that the folder gets the correct permissions on Unix.

@danegsta - who cleans up this folder?

[danegsta]

The advantage here is that the folder gets the correct permissions on Unix.

@danegsta - who cleans up this folder?

The original structure for the temp assets was %TEMP%/aspire/session/<pid>, where <pid> is the PID of the executing application (usually the AppHost) in order to make it easier to track down specific assets for an aspire run, like the kubeconfig for DCP. That was causing issues with tests that might need to run multiple tests which would end up colliding on the PID of the test host.

DCP will cleanup the <pid> folder when it exits normally, but the rest of the parent folders don't have anything cleaning them up.

I'm wondering if we should consider refactoring back to %TEMP%/aspire/<pid> and remove the session folder, plus add a new property to DistributedApplicationOptions to override the %TEMP%/aspire/ path for tests, since that gives us only one orphan aspire temp folder for normal operations (and makes it easy to track down the kubeconfig for diagnostics), while letting tests set a unique value to avoid collisions.

[danegsta]

If the given path doesn't exist, we specifically create it as part of creating the folder to hold the unix domain socket we use for sending system logs from DCP back to the AppHost. If the default for Directory.CreateDirectory isn't 0700 on Unix, we should probably update that call as well.

[danegsta]

But now that I think about it, using a shared root aspire folder is asking for trouble on Unix systems if anyone ever runs an AppHost as a different user (or something changed the permissions on the folder), so sticking with a simple Directory.CreateTempSubdirectory() folder and removing all the extraneous aspire/session/<pid> subpath is the safest overall option.

[eerhardt]

Note another change we could have made is to add a prefix - the CreateTempSubdirectory takes an optional (string? prefix = null). So we can pass "aspire" in for the prefix and all the temp directories will have that prefix.