Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for temp paths and OS check #624

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Improvements for temp paths and OS check #624

merged 1 commit into from
Nov 1, 2023

Conversation

danegsta
Copy link
Member

@danegsta danegsta commented Nov 1, 2023

Add suggested improvements from @eerhardt and @davidfowl

@danegsta danegsta requested a review from eerhardt November 1, 2023 16:56
eerhardt
eerhardt approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@danegsta danegsta mentioned this pull request Nov 1, 2023
Merged
@danegsta danegsta enabled auto-merge (squash) November 1, 2023 17:01
@danegsta danegsta merged commit b893971 into main Nov 1, 2023
4 checks passed
@danegsta danegsta deleted the danegsta/tempPath branch November 1, 2023 17:17
danegsta added a commit that referenced this pull request Nov 1, 2023
@danegsta
Improvements for temp paths and OS check (#624)
0d61f1f
@danegsta danegsta mentioned this pull request Nov 1, 2023
Merged
davidfowl pushed a commit that referenced this pull request Nov 2, 2023
@danegsta @eerhardt
[release/8.0-preview1] Cherry-pick temp path changes (#626)
6e1c4b3 
* Use Directory.CreateTempSubdirectory (#607)

* Use Directory.CreateTempSubdirectory

The advantage here is that the folder gets the correct permissions on Unix.

* Improvements for temp paths and OS check (#624)

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
joperezr added a commit that referenced this pull request Nov 14, 2023
@joperezr
Merged PR 35034: Merge branch 'release/8.0-preview1' into 'internal/r…
f58a51b 
…elease/8.0-preview1'

Related work items: #592, #602, #607, #617, #622, #624, #626, #627, #632, #638, #639, #640, #644, #647, #649, #650, #651, #652, #653, #656, #663
@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danegsta @eerhardt @danmoseley