Make DCP internal. #639
Merged
Make DCP internal. #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Nov 2, 2023
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
davidfowl
reviewed
Nov 2, 2023
| public class DcpVisibilityTests | ||
| { | ||
| [Fact] | ||
| public void EnsureNoTypesFromDcpNamespaceArePublic() |
There was a problem hiding this comment.
This test is a bit much, we can delete it afterwards.
davidfowl
approved these changes
Nov 2, 2023
davidfowl
pushed a commit
that referenced
this pull request
Nov 2, 2023
joperezr
added a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
... with a covering test to make sure we don't accidentally leak types in the future.