Update trace colors for accessibility #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
smitpatel,
dbreshears and
leslierichardson95
|
As of yesterday, the plan was to backport this to preview 1 as well once approved |
dbreshears
approved these changes
Nov 1, 2023
JamesNK
approved these changes
Nov 1, 2023
|
/backport to release/8.0-preview1 |
|
Started backporting to release/8.0-preview1: https://github.com/dotnet/aspire/actions/runs/6728052386 |
|
@tlmii backporting to release/8.0-preview1 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@tlmii an error occurred while backporting to release/8.0-preview1, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small modifications to the text color in a few areas of the traces and trace details pages.
This updates the text colors in the following places to ensure proper contrast:
The actual color changes are minimal. In all cases, both light and dark mode, we were close, but not quite. Before/After screenshots don't show any obvious difference unless you look really hard.
These changes impact both light and dark mode even though I've only shown dark mode above. I used the same setup that @JamesNK implemented for the metrics colors to handle the light/dark toggling given we're creating new variables.
This partially resolves #77, and I'm going to split off the remaining items I found into separate issues because they need more design discussion and potentially a11y team involvement.