Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview1] Cherry-pick temp path changes #626

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

danegsta
Copy link
Member

@danegsta danegsta commented Nov 1, 2023

This cherry-picks updates to the Aspire temp session path from #607 and #624

eerhardt and others added 2 commits November 1, 2023 10:23
* Use Directory.CreateTempSubdirectory

The advantage here is that the folder gets the correct permissions on Unix.
@danegsta danegsta requested a review from karolz-ms November 1, 2023 19:38
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidfowl davidfowl merged commit 6e1c4b3 into release/8.0-preview1 Nov 2, 2023
6 checks passed
@davidfowl davidfowl deleted the danegsta/cherryPick branch November 2, 2023 05:06
joperezr added a commit that referenced this pull request Nov 14, 2023
@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants