Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding #149997

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Feb 1, 2023

Summary

  • Added Fix for Resource tab has empty component
  • Added small CSS fix for button on CSPM not centered

@animehart animehart marked this pull request as ready for review February 1, 2023 00:15
@animehart animehart requested a review from a team as a code owner February 1, 2023 00:15
@animehart animehart linked an issue Feb 1, 2023 that may be closed by this pull request
@animehart animehart added release_note:skip Skip the PR/issue when compiling release notes bug Fixes for quality problems that affect the customer experience backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related v8.7.0 labels Feb 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart requested a review from JordanSh February 6, 2023 04:36
Copy link
Contributor

@JordanSh JordanSh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animehart I've managed to resolve this issue with what i think is a much simpler solution, please give it a go and tell me if it causing you any problems that I didn't notice.

The reason that you had problems here, and with the button in particular is that you used a repeating CSS selector. basically applying all those styles to every third child div. including the button, which also got the 450px width and that's what caused it to break outside of its container.

We can replace the entire css property with those 3 lines,

css={css`
        > :nth-child(3) {
          display: block;
          margin: auto;
          width: 450px;
        }
`}

Result:
image

@animehart animehart requested a review from JordanSh February 7, 2023 23:36
@animehart animehart enabled auto-merge (squash) February 8, 2023 09:20
@animehart animehart merged commit 752f87b into elastic:main Feb 8, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 142.3KB 142.3KB -79.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 8, 2023
* main: (187 commits)
  [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528)
  [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997)
  Making maxTransactionGroupsExceeded false by default (elastic#150458)
  [Fleet] refactor install registry and upload to extract common logic (elastic#150444)
  [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416)
  [APM] switch get environment function to use terms_enum api (elastic#150175)
  [Unified search] Fixes ally issues (elastic#150411)
  [Synthetics] Fix overview status query (elastic#150285)
  [api-docs] 2023-02-08 Daily api_docs build (elastic#150518)
  [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439)
  [RAM] Bring flapping status and settings in o11y (elastic#150483)
  [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403)
  [RAM] Allow alert table to show new alert status on apm (elastic#150500)
  [Synthetics] errors - adjust empty state content (elastic#150455)
  Uncomment tests (elastic#150481)
  [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479)
  [enterprise search]: disallow removing last index from engine (elastic#150464)
  [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180)
  Adds link to Jan 2023 contributors newsletter. (elastic#150259)
  [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finding's flyout presents an empty component
5 participants