-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding #149997
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
x-pack/plugins/cloud_security_posture/public/components/cloud_posture_page.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@animehart I've managed to resolve this issue with what i think is a much simpler solution, please give it a go and tell me if it causing you any problems that I didn't notice.
The reason that you had problems here, and with the button in particular is that you used a repeating CSS selector. basically applying all those styles to every third child div. including the button, which also got the 450px width and that's what caused it to break outside of its container.
We can replace the entire css
property with those 3 lines,
css={css`
> :nth-child(3) {
display: block;
margin: auto;
width: 450px;
}
`}
x-pack/plugins/cloud_security_posture/public/components/cloud_posture_page.tsx
Outdated
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* main: (187 commits) [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528) [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997) Making maxTransactionGroupsExceeded false by default (elastic#150458) [Fleet] refactor install registry and upload to extract common logic (elastic#150444) [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416) [APM] switch get environment function to use terms_enum api (elastic#150175) [Unified search] Fixes ally issues (elastic#150411) [Synthetics] Fix overview status query (elastic#150285) [api-docs] 2023-02-08 Daily api_docs build (elastic#150518) [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439) [RAM] Bring flapping status and settings in o11y (elastic#150483) [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403) [RAM] Allow alert table to show new alert status on apm (elastic#150500) [Synthetics] errors - adjust empty state content (elastic#150455) Uncomment tests (elastic#150481) [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479) [enterprise search]: disallow removing last index from engine (elastic#150464) [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180) Adds link to Jan 2023 contributors newsletter. (elastic#150259) [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236) ...
Summary