Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr tests] split x-pack functional_with_es_ssl config #150416

Merged

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Feb 7, 2023

Summary

Splitting config as it takes over 40 minutes into smaller ones to speedup CI

The following "Functional Tests" configs have durations that exceed the maximum amount of time desired for a single CI job. This is not an error, and if you don't own any of these configs then you can ignore this warning.If you own any of these configs please split them up ASAP and ask Operations if you have questions about how to do that.

x-pack/test/functional_with_es_ssl/config.ts: 40.6 minutes

Quick tests execution time analysis:

/apps/triggers_actions_ui ~ 13 min
09:01:15 CEST - 09:14:10 CEST

/apps/discover ~ 6 min
09:14:10 CEST - 09:20:21 CEST

/apps/uptime. ~ 2 min
09:20:21 CEST - 09:22:08 CEST

/apps/ml ~1 min
09:22:08 CEST - 09:22:57 CEST

/apps/cases ~ 17 min
09:23:02 CEST - 09:40:19 CEST

Splitting into 3 groups:
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts 12m 46s
x-pack/test/functional_with_es_ssl/apps/cases/config.ts 18m 07s
x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts 10m 38s

Splitting cases/config into 2 groups:
x-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts 10m 18s
x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts 8m 58s

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v8.6.2 labels Feb 7, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review February 7, 2023 15:17
@dmlemeshko dmlemeshko requested review from a team as code owners February 7, 2023 15:17
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@shahzad31
Copy link
Contributor

can you please also update code-owner file? uptime seems required but i can't see any files. i suspect files got moved and ownership is not updated.

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LTGM!

@dmlemeshko dmlemeshko merged commit c190a5f into elastic:main Feb 8, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.6 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 150416

Questions ?

Please refer to the Backport tool documentation

@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Feb 8, 2023
## Summary

Splitting config as it takes over 40 minutes into smaller ones to
speedup CI

```
The following "Functional Tests" configs have durations that exceed the maximum amount of time desired for a single CI job. This is not an error, and if you don't own any of these configs then you can ignore this warning.If you own any of these configs please split them up ASAP and ask Operations if you have questions about how to do that.

x-pack/test/functional_with_es_ssl/config.ts: 40.6 minutes
```

Quick tests execution time
[analysis](https://buildkite.com/elastic/kibana-pull-request/builds/105995#01862b40-f797-4537-9e05-a56453173b6d):

/apps/triggers_actions_ui ~ 13 min
09:01:15 CEST - 09:14:10 CEST

/apps/discover ~ 6 min
09:14:10 CEST - 09:20:21 CEST

/apps/uptime. ~ 2 min
09:20:21 CEST - 09:22:08 CEST

/apps/ml ~1 min
09:22:08 CEST - 09:22:57 CEST

/apps/cases ~ 17 min
09:23:02 CEST - 09:40:19 CEST

Splitting into 3 groups:
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts
12m 46s
x-pack/test/functional_with_es_ssl/apps/cases/config.ts 18m 07s
x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts 10m
38s

Splitting cases/config into 2 groups:
x-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts 10m 18s
x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts 8m 58s

(cherry picked from commit c190a5f)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/functional_with_es_ssl/apps/cases/group2/list_view.ts
#	x-pack/test/functional_with_es_ssl/apps/cases/group2/upgrade.ts
#	x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/uptime/simple_down_alert.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 8, 2023
* main: (187 commits)
  [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528)
  [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997)
  Making maxTransactionGroupsExceeded false by default (elastic#150458)
  [Fleet] refactor install registry and upload to extract common logic (elastic#150444)
  [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416)
  [APM] switch get environment function to use terms_enum api (elastic#150175)
  [Unified search] Fixes ally issues (elastic#150411)
  [Synthetics] Fix overview status query (elastic#150285)
  [api-docs] 2023-02-08 Daily api_docs build (elastic#150518)
  [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439)
  [RAM] Bring flapping status and settings in o11y (elastic#150483)
  [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403)
  [RAM] Allow alert table to show new alert status on apm (elastic#150500)
  [Synthetics] errors - adjust empty state content (elastic#150455)
  Uncomment tests (elastic#150481)
  [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479)
  [enterprise search]: disallow removing last index from engine (elastic#150464)
  [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180)
  Adds link to Jan 2023 contributors newsletter. (elastic#150259)
  [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2023
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

dmlemeshko added a commit that referenced this pull request Feb 9, 2023
#150534)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ftr tests] split x-pack functional_with_es_ssl config
(#150416)](#150416)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-02-08T08:56:40Z","message":"[ftr
tests] split x-pack functional_with_es_ssl config (#150416)\n\n##
Summary\r\n\r\nSplitting config as it takes over 40 minutes into smaller
ones to\r\nspeedup CI\r\n\r\n```\r\nThe following \"Functional Tests\"
configs have durations that exceed the maximum amount of time desired
for a single CI job. This is not an error, and if you don't own any of
these configs then you can ignore this warning.If you own any of these
configs please split them up ASAP and ask Operations if you have
questions about how to do
that.\r\n\r\nx-pack/test/functional_with_es_ssl/config.ts: 40.6
minutes\r\n```\r\n\r\nQuick tests execution
time\r\n[analysis](https://buildkite.com/elastic/kibana-pull-request/builds/105995#01862b40-f797-4537-9e05-a56453173b6d):\r\n\r\n/apps/triggers_actions_ui
~ 13 min\r\n09:01:15 CEST - 09:14:10 CEST\r\n\r\n/apps/discover ~ 6
min\r\n09:14:10 CEST - 09:20:21 CEST\r\n\r\n/apps/uptime. ~ 2
min\r\n09:20:21 CEST - 09:22:08 CEST\r\n\r\n/apps/ml ~1 min\r\n09:22:08
CEST - 09:22:57 CEST\r\n\r\n/apps/cases ~ 17 min\r\n09:23:02 CEST -
09:40:19 CEST\r\n\r\nSplitting into 3
groups:\r\nx-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts\r\n12m
46s\r\nx-pack/test/functional_with_es_ssl/apps/cases/config.ts 18m
07s\r\nx-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts
10m\r\n38s\r\n\r\nSplitting cases/config into 2
groups:\r\nx-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts
10m
18s\r\nx-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts 8m
58s","sha":"c190a5f9141f96a15a4b30d285d2e121b3eb7651","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.6.2"],"number":150416,"url":"https://github.com/elastic/kibana/pull/150416","mergeCommit":{"message":"[ftr
tests] split x-pack functional_with_es_ssl config (#150416)\n\n##
Summary\r\n\r\nSplitting config as it takes over 40 minutes into smaller
ones to\r\nspeedup CI\r\n\r\n```\r\nThe following \"Functional Tests\"
configs have durations that exceed the maximum amount of time desired
for a single CI job. This is not an error, and if you don't own any of
these configs then you can ignore this warning.If you own any of these
configs please split them up ASAP and ask Operations if you have
questions about how to do
that.\r\n\r\nx-pack/test/functional_with_es_ssl/config.ts: 40.6
minutes\r\n```\r\n\r\nQuick tests execution
time\r\n[analysis](https://buildkite.com/elastic/kibana-pull-request/builds/105995#01862b40-f797-4537-9e05-a56453173b6d):\r\n\r\n/apps/triggers_actions_ui
~ 13 min\r\n09:01:15 CEST - 09:14:10 CEST\r\n\r\n/apps/discover ~ 6
min\r\n09:14:10 CEST - 09:20:21 CEST\r\n\r\n/apps/uptime. ~ 2
min\r\n09:20:21 CEST - 09:22:08 CEST\r\n\r\n/apps/ml ~1 min\r\n09:22:08
CEST - 09:22:57 CEST\r\n\r\n/apps/cases ~ 17 min\r\n09:23:02 CEST -
09:40:19 CEST\r\n\r\nSplitting into 3
groups:\r\nx-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts\r\n12m
46s\r\nx-pack/test/functional_with_es_ssl/apps/cases/config.ts 18m
07s\r\nx-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts
10m\r\n38s\r\n\r\nSplitting cases/config into 2
groups:\r\nx-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts
10m
18s\r\nx-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts 8m
58s","sha":"c190a5f9141f96a15a4b30d285d2e121b3eb7651"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150416","number":150416,"mergeCommit":{"message":"[ftr
tests] split x-pack functional_with_es_ssl config (#150416)\n\n##
Summary\r\n\r\nSplitting config as it takes over 40 minutes into smaller
ones to\r\nspeedup CI\r\n\r\n```\r\nThe following \"Functional Tests\"
configs have durations that exceed the maximum amount of time desired
for a single CI job. This is not an error, and if you don't own any of
these configs then you can ignore this warning.If you own any of these
configs please split them up ASAP and ask Operations if you have
questions about how to do
that.\r\n\r\nx-pack/test/functional_with_es_ssl/config.ts: 40.6
minutes\r\n```\r\n\r\nQuick tests execution
time\r\n[analysis](https://buildkite.com/elastic/kibana-pull-request/builds/105995#01862b40-f797-4537-9e05-a56453173b6d):\r\n\r\n/apps/triggers_actions_ui
~ 13 min\r\n09:01:15 CEST - 09:14:10 CEST\r\n\r\n/apps/discover ~ 6
min\r\n09:14:10 CEST - 09:20:21 CEST\r\n\r\n/apps/uptime. ~ 2
min\r\n09:20:21 CEST - 09:22:08 CEST\r\n\r\n/apps/ml ~1 min\r\n09:22:08
CEST - 09:22:57 CEST\r\n\r\n/apps/cases ~ 17 min\r\n09:23:02 CEST -
09:40:19 CEST\r\n\r\nSplitting into 3
groups:\r\nx-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts\r\n12m
46s\r\nx-pack/test/functional_with_es_ssl/apps/cases/config.ts 18m
07s\r\nx-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts
10m\r\n38s\r\n\r\nSplitting cases/config into 2
groups:\r\nx-pack/test/functional_with_es_ssl/apps/cases/group1/config.ts
10m
18s\r\nx-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts 8m
58s","sha":"c190a5f9141f96a15a4b30d285d2e121b3eb7651"}},{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2023
@dmlemeshko dmlemeshko deleted the ftr/split-functional_with_es_ssl-config branch November 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.6.2 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants