-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Removing the icon for tech preview and fixing some of the alert badges #150528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/apm-ui (Team:APM) |
…-ref HEAD~1..HEAD --fix'
MiriamAparicio
added
backport:skip
This commit does not require backporting
v8.7.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Feb 8, 2023
MiriamAparicio
changed the title
Apm alert icons
[APM] Removing the icon for tech preview and fixing some of the alert badges
Feb 8, 2023
MiriamAparicio
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟
The changes requested in the previous PR were addressed
yngrdyn
approved these changes
Feb 8, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 8, 2023
* main: (187 commits) [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528) [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997) Making maxTransactionGroupsExceeded false by default (elastic#150458) [Fleet] refactor install registry and upload to extract common logic (elastic#150444) [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416) [APM] switch get environment function to use terms_enum api (elastic#150175) [Unified search] Fixes ally issues (elastic#150411) [Synthetics] Fix overview status query (elastic#150285) [api-docs] 2023-02-08 Daily api_docs build (elastic#150518) [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439) [RAM] Bring flapping status and settings in o11y (elastic#150483) [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403) [RAM] Allow alert table to show new alert status on apm (elastic#150500) [Synthetics] errors - adjust empty state content (elastic#150455) Uncomment tests (elastic#150481) [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479) [enterprise search]: disallow removing last index from engine (elastic#150464) [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180) Adds link to Jan 2023 contributors newsletter. (elastic#150259) [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @maciejforcone and @grabowskit it was recommended to remove the tech preview badge for the Alerts tab. We also made small change in the alert badge in different areas in APM to make easier to understand and align them with the actionable o11y team.
Before / After