Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Removing the icon for tech preview and fixing some of the alert badges #150528

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

boriskirov
Copy link
Contributor

@boriskirov boriskirov commented Feb 8, 2023

After a discussion with @maciejforcone and @grabowskit it was recommended to remove the tech preview badge for the Alerts tab. We also made small change in the alert badge in different areas in APM to make easier to understand and align them with the actionable o11y team.

Before / After
image

image

@boriskirov boriskirov requested a review from a team as a code owner February 8, 2023 09:04
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@MiriamAparicio MiriamAparicio added backport:skip This commit does not require backporting v8.7.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 8, 2023
@MiriamAparicio MiriamAparicio changed the title Apm alert icons [APM] Removing the icon for tech preview and fixing some of the alert badges Feb 8, 2023
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

The changes requested in the previous PR were addressed

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.3MB 3.3MB +570.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit ebc6750 into main Feb 8, 2023
@MiriamAparicio MiriamAparicio deleted the apm-alert-icons branch February 8, 2023 10:42
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 8, 2023
* main: (187 commits)
  [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528)
  [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997)
  Making maxTransactionGroupsExceeded false by default (elastic#150458)
  [Fleet] refactor install registry and upload to extract common logic (elastic#150444)
  [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416)
  [APM] switch get environment function to use terms_enum api (elastic#150175)
  [Unified search] Fixes ally issues (elastic#150411)
  [Synthetics] Fix overview status query (elastic#150285)
  [api-docs] 2023-02-08 Daily api_docs build (elastic#150518)
  [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439)
  [RAM] Bring flapping status and settings in o11y (elastic#150483)
  [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403)
  [RAM] Allow alert table to show new alert status on apm (elastic#150500)
  [Synthetics] errors - adjust empty state content (elastic#150455)
  Uncomment tests (elastic#150481)
  [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479)
  [enterprise search]: disallow removing last index from engine (elastic#150464)
  [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180)
  Adds link to Jan 2023 contributors newsletter. (elastic#150259)
  [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants