Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] switch get environment function to use terms_enum api #150175

Merged
merged 17 commits into from
Feb 8, 2023
Merged

[APM] switch get environment function to use terms_enum api #150175

merged 17 commits into from
Feb 8, 2023

Conversation

achyutjhunjhunwala
Copy link
Contributor

Fixes #144544

Summary

To get the list of Environments, aggregation was used on search api. With this change, list of environments will now be retrieved using the Terms Enum API

@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner February 2, 2023 14:02
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Feb 2, 2023
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

sorenlouv
sorenlouv requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only use the terms enum API on the service inventory page

@achyutjhunjhunwala achyutjhunjhunwala changed the title switch get environment function to use terms_enum api instead of aggr… [APM] switch get environment function to use terms_enum api Feb 2, 2023
@achyutjhunjhunwala
Copy link
Contributor Author

achyutjhunjhunwala commented Feb 6, 2023 •
edited
Loading

Feature wise, i have pushed all the changes.
[WIP] Currently i am working on improving the Unit, API test cases and syntrace data generation

sorenlouv
sorenlouv reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits around naming.

x-pack/plugins/apm/public/hooks/use_environments_fetcher.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/hooks/use_environments_fetcher.tsx Outdated Show resolved Hide resolved
cauemarcondes
cauemarcondes approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.3MB 3.3MB +232.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

sorenlouv
sorenlouv approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for improving the inspector!

@achyutjhunjhunwala achyutjhunjhunwala merged commit 0648296 into main Feb 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the switch_get_environments_to_terms_enum_api branch February 8, 2023 08:33
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 8, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 8, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
0a185eb 
* main: (187 commits)
  [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528)
  [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997)
  Making maxTransactionGroupsExceeded false by default (elastic#150458)
  [Fleet] refactor install registry and upload to extract common logic (elastic#150444)
  [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416)
  [APM] switch get environment function to use terms_enum api (elastic#150175)
  [Unified search] Fixes ally issues (elastic#150411)
  [Synthetics] Fix overview status query (elastic#150285)
  [api-docs] 2023-02-08 Daily api_docs build (elastic#150518)
  [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439)
  [RAM] Bring flapping status and settings in o11y (elastic#150483)
  [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403)
  [RAM] Allow alert table to show new alert status on apm (elastic#150500)
  [Synthetics] errors - adjust empty state content (elastic#150455)
  Uncomment tests (elastic#150481)
  [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479)
  [enterprise search]: disallow removing last index from engine (elastic#150464)
  [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180)
  Adds link to Jan 2023 contributors newsletter. (elastic#150259)
  [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Use terms enum to fetch environments on Service inventory page
6 participants
@achyutjhunjhunwala @elasticmachine @kibana-ci @sorenlouv @cauemarcondes @kibanamachine