[enterprise search]: disallow removing last index from engine #150464
Conversation
TattdCodeMonkey
added
release_note:skip
There was a problem hiding this comment.
Interestingly enough, I don't think we technically enforce this constraint on PUT requests to the backend API.
I think this is OK to do for now, but we should think if there are any use cases to having an Engine lying around with no more indices. Perhaps the engine is going away but they're still hanging onto analytics? Would that be a valid use case? If there truly are no valid use cases for this, we should consider on the backend either a) disallowing removal of the last index from the engine or b) acting the way aliases do and remove the engine itself if the last index is removed (I don't think that we want to do b in practice).
Removing the option to remove the last index from an engine. We don't allow creating engines with no indices, so allowing a user to remove all indices from an engine doesn't make sense either.
TattdCodeMonkey
force-pushed
the
rnorris/feat/engines-disallow-removing-final-index
branch
from
d91e638 to
1d11305
Compare
|
@sloanelybutsurely there is not a ticket for preventing this at the API-level. It has come up in a few meetings and wanted to go ahead and get this in before feature freeze. But we should definitely talk more about it. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* main: (187 commits) [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528) [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997) Making maxTransactionGroupsExceeded false by default (elastic#150458) [Fleet] refactor install registry and upload to extract common logic (elastic#150444) [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416) [APM] switch get environment function to use terms_enum api (elastic#150175) [Unified search] Fixes ally issues (elastic#150411) [Synthetics] Fix overview status query (elastic#150285) [api-docs] 2023-02-08 Daily api_docs build (elastic#150518) [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439) [RAM] Bring flapping status and settings in o11y (elastic#150483) [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403) [RAM] Allow alert table to show new alert status on apm (elastic#150500) [Synthetics] errors - adjust empty state content (elastic#150455) Uncomment tests (elastic#150481) [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479) [enterprise search]: disallow removing last index from engine (elastic#150464) [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180) Adds link to Jan 2023 contributors newsletter. (elastic#150259) [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236) ...
Summary
Removing the option to remove the last index from an engine. We don't allow creating engines with no indices, so allowing a user to remove all indices from an engine doesn't make sense either.
Screenshots
Engine with 1 index
Engines with >1 index (has remove index action)