Variety of quick a11y fixes #46569

myasonik · 2019-09-25T11:06:39Z

(## Summary

A slew of accessibility fixes for a wide range of issues, mostly around document structure. Focusing on things that are easily detectable by automated tools (which we keep getting flagged for in audits) and things that are easy to fix.

Not all solutions are perfect but they're improvements on what we have today.

Addresses some pages of #37539 (Home, Discover, Dashboard, Visualize). Probably more can be done but this is a good start.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~

This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-25T11:23:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-25T13:33:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-25T15:54:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sulemanof · 2019-09-26T11:20:52Z

Hi @myasonik !
I would suggest to revert all changes in src/legacy/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html because I have an opened PR #45766 with EUI-fying of this stuff. I've added you as a reviewer. I also tried to follow the general structure you've done in your PR and replaced all the headings to h3 tag.
And I'd also like you to explain the necessity of such a replacement!
Thanks in advance.

x-pack/test/functional/apps/machine_learning/create_population_job.ts

myasonik · 2019-09-26T11:31:23Z

@sulemanof Previously I suggested using an h2 because of the existing heading structure. I think the sidebar title was set to be the h1 on the page which would make the headings inside of the sidebar h2s.

Now, I've gone and added a proper h1 to the page (though it's visually hidden) that describes the whole page. The sidebar header is now an h2 which makes all of the sections inside of the sidebar h3 headers.

elasticmachine · 2019-09-26T12:52:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sulemanof

LGTM

timroes

Overall looks really good, got a couple of minor code style comments.

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

...y/core_plugins/embeddable_api/public/np_ready/public/lib/panel/panel_header/panel_header.tsx

src/legacy/core_plugins/kibana/public/discover/components/field_chooser/field_chooser.html

..._plugins/embeddable_api/public/np_ready/public/lib/panel/panel_header/panel_options_menu.tsx

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

timroes · 2019-09-27T13:12:27Z

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

+                aria-label={this.props.intl.formatMessage(
+                  {
+                    id: 'data.query.queryBar.searchInputAriaLabel',
+                    defaultMessage: 'Start typing to search and filter the {pageType} page',


If you change the default message of a string, you should remove all existing translations for this string, so it will be retranslated by our translators again. Just search for that id and remove it from all internationalization files.

Looks like all of them were already removed... Am I missing anything?

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

elasticmachine · 2019-10-01T10:23:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-10-01T14:44:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes

Code LGTM, looked at a couple of changes and checked it didn't break styling.

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

elasticmachine · 2019-10-02T12:16:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

bhavyarm

LGTM

joshdover

Platform changes LGTM

kertal

Change in Discover LGTM 👍

elasticmachine · 2019-10-02T16:26:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-10-02T19:13:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...

Focusing on heading structure and page layout for Home, Discover, Dashboard, and Visualize. This is progress on #37539

myasonik requested a review from bhavyarm September 25, 2019 11:06

myasonik requested a review from a team as a code owner September 25, 2019 11:06

myasonik added Project:Accessibility release_note:fix v7.5.0 v8.0.0 labels Sep 25, 2019

myasonik force-pushed the axe-a11y-fixes branch from ab7ca26 to 4dac86d Compare September 25, 2019 11:42

myasonik force-pushed the axe-a11y-fixes branch from 4dac86d to 683f2d1 Compare September 25, 2019 14:10

myasonik requested a review from a team September 25, 2019 14:38

timroes self-requested a review September 25, 2019 14:41

myasonik requested review from maryia-lapata and sulemanof September 25, 2019 14:43

myasonik force-pushed the axe-a11y-fixes branch from 683f2d1 to 6552d55 Compare September 26, 2019 11:13

myasonik requested a review from a team as a code owner September 26, 2019 11:13

peteharverson reviewed Sep 26, 2019

View reviewed changes

x-pack/test/functional/apps/machine_learning/create_population_job.ts Outdated Show resolved Hide resolved

myasonik force-pushed the axe-a11y-fixes branch from 6552d55 to a0ac23a Compare September 26, 2019 11:40

sulemanof approved these changes Sep 26, 2019

View reviewed changes

timroes suggested changes Sep 27, 2019

View reviewed changes

myasonik force-pushed the axe-a11y-fixes branch from a0ac23a to 00107fe Compare October 1, 2019 09:08

myasonik requested a review from timroes October 1, 2019 09:38

Michail Yasonik added 2 commits October 1, 2019 18:36

a variety of simple a11y quick fixes

bcf0581

PR feedback

91f1e92

myasonik force-pushed the axe-a11y-fixes branch from 00107fe to 91f1e92 Compare October 1, 2019 13:33

timroes approved these changes Oct 1, 2019

View reviewed changes

timroes reviewed Oct 1, 2019

View reviewed changes

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx Outdated Show resolved Hide resolved

Michail Yasonik added 2 commits October 2, 2019 16:32

Merge remote-tracking branch 'upstream/master' into axe-a11y-fixes

35482e9

PR feedback

4cb27c1

bhavyarm approved these changes Oct 2, 2019

View reviewed changes

joshdover approved these changes Oct 2, 2019

View reviewed changes

kertal self-requested a review October 2, 2019 13:24

kertal approved these changes Oct 2, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into axe-a11y-fixes

677844e

updating jest snapshots

4f37f56

myasonik merged commit ea18949 into elastic:master Oct 3, 2019

myasonik deleted the axe-a11y-fixes branch October 3, 2019 09:30

myasonik mentioned this pull request Oct 3, 2019

[7.x] Variety of quick a11y fixes (#46569) #47194

Merged

myasonik pushed a commit that referenced this pull request Oct 3, 2019

[7.x] Variety of quick a11y fixes (#46569) (#47194)

c3ef55d

Focusing on heading structure and page layout for Home, Discover, Dashboard, and Visualize. This is progress on #37539

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Variety of quick a11y fixes #46569

Variety of quick a11y fixes #46569

myasonik commented Sep 25, 2019 •

edited

Loading

elasticmachine commented Sep 25, 2019

elasticmachine commented Sep 25, 2019

elasticmachine commented Sep 25, 2019

sulemanof commented Sep 26, 2019

myasonik commented Sep 26, 2019

elasticmachine commented Sep 26, 2019

sulemanof left a comment

timroes left a comment

timroes Sep 27, 2019

myasonik Oct 1, 2019

elasticmachine commented Oct 1, 2019

elasticmachine commented Oct 1, 2019

timroes left a comment

elasticmachine commented Oct 2, 2019

bhavyarm left a comment

joshdover left a comment

kertal left a comment

elasticmachine commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

Variety of quick a11y fixes #46569

Variety of quick a11y fixes #46569

Conversation

myasonik commented Sep 25, 2019 • edited Loading

Checklist

For maintainers

elasticmachine commented Sep 25, 2019

💔 Build Failed

elasticmachine commented Sep 25, 2019

💔 Build Failed

elasticmachine commented Sep 25, 2019

💔 Build Failed

sulemanof commented Sep 26, 2019

myasonik commented Sep 26, 2019

elasticmachine commented Sep 26, 2019

💚 Build Succeeded

sulemanof left a comment

Choose a reason for hiding this comment

timroes left a comment

Choose a reason for hiding this comment

timroes Sep 27, 2019

Choose a reason for hiding this comment

myasonik Oct 1, 2019

Choose a reason for hiding this comment

elasticmachine commented Oct 1, 2019

💔 Build Failed

elasticmachine commented Oct 1, 2019

💚 Build Succeeded

timroes left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

bhavyarm left a comment

Choose a reason for hiding this comment

joshdover left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 2, 2019

💔 Build Failed

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

myasonik commented Sep 25, 2019 •

edited

Loading