[unskip-test] Add scroll into view to avoid tooltip overlap #47106

markov00 · 2019-10-02T10:32:16Z

Summary

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button.
The tooltip implementation will be soon replaced by EUI #38272, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.

fix #45105

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button. The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.

elasticmachine · 2019-10-02T11:45:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

markov00 · 2019-10-02T11:45:57Z

code search error on smoke test

1) Code
       Search
         Code Search
           "before all" hook for "Trigger symbols in typeahead":
     NoSuchSessionError: Tried to run command without establishing a connection
      at Object.throwDecodedError (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
      at parseHttpResponse (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/http.js:560:13)
      at Executor.execute (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/http.js:486:26)
      at process._tickCallback (internal/process/next_tick.js:68:7)

               └- ✖ fail: "Code Search Code Search "before all" hook for "Trigger symbols in typeahead""
               │
               └-> "after all" hook
                 │ERROR SCREENSHOT FAILED
                 │ERROR NoSuchSessionError: Tried to run command without establishing a connection
                 │          at Object.throwDecodedError (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
                 │          at parseHttpResponse (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/http.js:560:13)
                 │          at Executor.execute (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/kibana/node_modules/selenium-webdriver/lib/http.js:486:26)
                 │          at process._tickCallback (internal/process/next_tick.js:68:7)

elasticmachine · 2019-10-02T12:55:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

bhavyarm

LGTM. But @dmlemeshko is going to run it multiple times

dmlemeshko

LGTM. Passed on CI 30x times

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button. The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.

…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button. The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.

markov00 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 test-matrix Use this label to ensure PRs are tested with matrix jobs labels Oct 2, 2019

markov00 requested review from bhavyarm and dmlemeshko October 2, 2019 10:32

markov00 changed the title ~~Add scroll into view to avoid tooltip overlap~~ [unskip-test] Add scroll into view to avoid tooltip overlap Oct 2, 2019

bhavyarm approved these changes Oct 2, 2019

View reviewed changes

dmlemeshko mentioned this pull request Oct 2, 2019

Test PR for re-enabling vertical bar chart tests #47122

Closed

dmlemeshko approved these changes Oct 2, 2019

View reviewed changes

markov00 merged commit 802cd33 into elastic:master Oct 3, 2019

markov00 mentioned this pull request Oct 3, 2019

[7.x] Add scroll into view to avoid tooltip overlap (#47106) #47202

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[unskip-test] Add scroll into view to avoid tooltip overlap #47106

[unskip-test] Add scroll into view to avoid tooltip overlap #47106

markov00 commented Oct 2, 2019 •

edited

Loading

elasticmachine commented Oct 2, 2019

markov00 commented Oct 2, 2019 •

edited

Loading

elasticmachine commented Oct 2, 2019

bhavyarm left a comment

dmlemeshko left a comment

[unskip-test] Add scroll into view to avoid tooltip overlap #47106

[unskip-test] Add scroll into view to avoid tooltip overlap #47106

Conversation

markov00 commented Oct 2, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 2, 2019

💔 Build Failed

markov00 commented Oct 2, 2019 • edited Loading

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

bhavyarm left a comment

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

markov00 commented Oct 2, 2019 •

edited

Loading

markov00 commented Oct 2, 2019 •

edited

Loading