[Uptime] Update pings chart colors #46780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:enhancement
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
|
@justinkambic @andrewvc do we need to update docs somewhere for this, to describe that gray color now represents ping success ? |
|
Do we want to target this patch for 7.5? I know we said in the past that we're fine with putting these changes in |
I agree, i will remove 7.5 label. |
shahzad31
changed the title
💔 Build Failed |
…for-pings-histogram
💔 Build Failed |
…for-pings-histogram
💔 Build Failed |
kobelb
reviewed
Sep 30, 2019
...bana/space_aware_privilege_section/__snapshots__/space_aware_privilege_section.test.tsx.snap
Outdated
Show resolved
Hide resolved
…for-pings-histogram
💚 Build Succeeded |
justinkambic
approved these changes
Oct 2, 2019
x-pack/legacy/plugins/uptime/public/components/functional/charts/snapshot_histogram.tsx
Show resolved
Hide resolved
…for-pings-histogram
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
|
@shahzad31 I see this is tagged as 8.0.0 . Not sure if that was a mistake. This should be targeting 7.5.0 and be backported as part of the redesign. |
|
@andrewvc do we want to ship this if the rest of the redesign doesn't make it? I also was planning on targeting some redesign changes for 7.x, but not specifically 7.5.0. |
shahzad31
deleted the
redesign/44553--use-red-grey-color-scheme-for-pings-histogram
branch
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 11, 2019
* update pings chart colors * update snaps * update snaps * update snaps
tylersmalley
pushed a commit
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #44553
Using new red / gray color scheme on the for pings over time chart.
Checklist
For maintainers
Testing
Open Uptime app and observe new color scheme used for pings chart.