Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add validation for QI in PR #35677

Merged
merged 1 commit into from
Jun 17, 2023
Merged

fix: add validation for QI in PR #35677

merged 1 commit into from
Jun 17, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jun 13, 2023 •
edited
Loading

Source / Ref: ISS-23-24-01397

Issue: A same Quality Inspection can be selected for different Items and Voucher Types which creates a circular linking between the Quality Inspection and Linked Vouchers.

Steps to Replicate:

  • Create a Purchase Receipt with two different line items.
  • Create a Quality Inspection for the first item.
  • Select the same Quality Inspection for both line items in Purchase Receipt.
  • Submit the Purchase Receipt.
  • No, try to Cancel the Quality Inspection or Purchase Receipt.

Changes: Validation for Quality Inspection in Purchase Receipt.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #35677 (2c1ab56) into develop (a3ea985) will increase coverage by 0.16%.
The diff coverage is 36.36%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35677      +/-   ##
===========================================
+ Coverage    63.94%   64.11%   +0.16%     
===========================================
  Files          811      811              
  Lines        61856    61888      +32     
===========================================
+ Hits         39554    39677     +123     
+ Misses       22302    22211      -91
Impacted Files Coverage Δ
...stock/doctype/purchase_receipt/purchase_receipt.py 91.25% <36.36%> (-1.39%) ⬇️

... and 7 files with indirect coverage changes

@s-aga-r s-aga-r marked this pull request as ready for review June 16, 2023 11:18
@s-aga-r s-aga-r merged commit 9fb6fc5 into frappe:develop Jun 17, 2023
This was referenced Jun 17, 2023
Merged
Merged
s-aga-r added a commit that referenced this pull request Jun 17, 2023
@mergify @s-aga-r
fix: add validation for QI in PR (backport #35677) (#35757)
59ab13c 
fix: add validation for QI in PR

(cherry picked from commit 2c1ab56)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
s-aga-r added a commit that referenced this pull request Jun 17, 2023
@mergify @s-aga-r
fix: add validation for QI in PR (backport #35677) (#35758)
0a8b714 
fix: add validation for QI in PR

(cherry picked from commit 2c1ab56)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jun 20, 2023
@frappe-bot
chore(release): Bumped to Version 14.27.9
2561cf2 
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20)

### Bug Fixes

* `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5))
* add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c))
* Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68))
* cannot start / stop jobs ([53ec2a9](53ec2a9))
* conflicts ([697fcef](697fcef))
* consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85))
* date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd))
* don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f))
* Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4))
* fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4))
* for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b))
* incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2))
* incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950))
* keyerror while checking the stock balance report ([baf014f](baf014f))
* loan interest accrual date ([#35695](#35695)) ([070df97](070df97))
* **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1))
* stock error for service item ([2bbea63](2bbea63))
* test case ([4af0a9b](4af0a9b))
* unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc))
* update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8))
* **ux:** set route options for new `Batch` ([b261242](b261242))
* validation of job card in stock entry ([ce2bf5f](ce2bf5f))
* work order serial no issue ([50a8907](50a8907))

### Performance Improvements

* Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c))
* duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2))
* Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d))
* index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8))
* Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6))
* Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
frappe-pr-bot pushed a commit that referenced this pull request Jun 21, 2023
@frappe-bot
chore(release): Bumped to Version 13.51.6
60a170d 
## [13.51.6](v13.51.5...v13.51.6) (2023-06-21)

### Bug Fixes

* account group totals calculation to consider include_in_gross ([f22969d](f22969d))
* add total col for gross and net profit ([e899c30](e899c30))
* add validation for QI in PR (backport [#35677](#35677)) ([#35758](#35758)) ([0a8b714](0a8b714))
* Allocated amount validation for other party types ([#35741](#35741)) ([3d0add8](3d0add8))
* date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35800](#35800)) ([aa8446d](aa8446d))
* don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35716](#35716)) ([0e11317](0e11317))
* fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35788](#35788)) ([04990d5](04990d5))
* Incorrect field while calculating Tax withholding net total ([571c977](571c977))
* Incorrect field while calculating Tax withholding net total ([b95d459](b95d459))
* loan interest accrual date ([#35695](#35695)) ([46d0b7d](46d0b7d))

### Performance Improvements

* index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35784](#35784)) ([7239e83](7239e83))
@commit-lint commit-lint bot mentioned this pull request Jun 28, 2023
Merged
@s-aga-r s-aga-r deleted the FIX-ISS-23-24-01397 branch July 27, 2023 08:12
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-aga-r