Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Process Loss Report #35712

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: Process Loss Report #35712

merged 1 commit into from
Jun 15, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jun 15, 2023 •
edited
Loading

Source / Ref: ISS-23-24-01470

Changes:

  • Removed Actual Manufactured Qty, added Qty To Manufacture.
  • Added condition for Stock Entry purpose = Manufacture.
  • Fixed Loss Value, FG Value and Raw Material Value calculation.
  • Changed label Loss Qty --> Process Loss Qty, Loss Value --> Process Loss Value.

BOM
image
image
image

Work Order
image

Process Loss Report - Before
image

Process Loss Report - After
image

#32735

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 15, 2023
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Jun 15, 2023
@s-aga-r s-aga-r marked this pull request as ready for review June 15, 2023 10:58
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #35712 (d176d86) into develop (24d1bf2) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #35712   +/-   ##
========================================
  Coverage    64.11%   64.11%           
========================================
  Files          811      811           
  Lines        61892    61892           
========================================
  Hits         39680    39680           
  Misses       22212    22212
Impacted Files Coverage Δ
.../report/process_loss_report/process_loss_report.py 87.09% <0.00%> (ø)

@rohitwaghchaure rohitwaghchaure merged commit 6cb31a9 into frappe:develop Jun 15, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Jun 15, 2023
@mergify mergify bot mentioned this pull request Jun 15, 2023
Merged
s-aga-r added a commit that referenced this pull request Jun 15, 2023
@mergify @s-aga-r
fix: Process Loss Report (backport #35712) (#35719)
55a8be5 
fix: `Process Loss Report`

(cherry picked from commit d176d86)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jun 20, 2023
@frappe-bot
chore(release): Bumped to Version 14.27.9
2561cf2 
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20)

### Bug Fixes

* `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5))
* add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c))
* Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68))
* cannot start / stop jobs ([53ec2a9](53ec2a9))
* conflicts ([697fcef](697fcef))
* consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85))
* date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd))
* don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f))
* Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4))
* fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4))
* for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b))
* incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2))
* incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950))
* keyerror while checking the stock balance report ([baf014f](baf014f))
* loan interest accrual date ([#35695](#35695)) ([070df97](070df97))
* **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1))
* stock error for service item ([2bbea63](2bbea63))
* test case ([4af0a9b](4af0a9b))
* unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc))
* update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8))
* **ux:** set route options for new `Batch` ([b261242](b261242))
* validation of job card in stock entry ([ce2bf5f](ce2bf5f))
* work order serial no issue ([50a8907](50a8907))

### Performance Improvements

* Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c))
* duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2))
* Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d))
* index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8))
* Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6))
* Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
@commit-lint commit-lint bot mentioned this pull request Jun 28, 2023
Merged
@s-aga-r s-aga-r deleted the FIX-ISS-23-24-01470 branch July 27, 2023 08:12
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-aga-r @rohitwaghchaure