Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Ignore cancelled pick lists while fetching picked items #35737

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Jun 16, 2023

docstatus!=2 is already a condition but it's not useful in status index. Hence add separate condition to prevent over-reading data.

Before:

+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+-------+---------+----------+-------->
| id   | select_type | table             | type  | possible_keys        | key          | key_len | ref                                 | rows  | r_rows  | filtered | r_filte>
+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+-------+---------+----------+-------->
|    1 | SIMPLE      | tabPick List      | range | PRIMARY,status_index | status_index | 563     | NULL                                | 10591 | 7280.00 |   100.00 |      99>
|    1 | SIMPLE      | tabPick List Item | ref   | parent               | parent       | 563     | _fc28cbacdbac857b.tabPick List.name | 3     | 8.63    |   100.00 |       0>
+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+-------+---------+----------+-------->

After:

+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+------+---------+----------+--------->
| id   | select_type | table             | type  | possible_keys        | key          | key_len | ref                                 | rows | r_rows  | filtered | r_filter>
+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+------+---------+----------+--------->
|    1 | SIMPLE      | tabPick List      | range | PRIMARY,status_index | status_index | 563     | NULL                                | 1549 | 1547.00 |   100.00 |      99.>
|    1 | SIMPLE      | tabPick List Item | ref   | parent               | parent       | 563     | _fc28cbacdbac857b.tabPick List.name | 3    | 7.85    |   100.00 |       4.>
+------+-------------+-------------------+-------+----------------------+--------------+---------+-------------------------------------+------+---------+----------+--------->

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 16, 2023
@ankush ankush added the backport version-14-hotfix backport to version 14 label Jun 16, 2023
@ankush ankush removed the request for review from rohitwaghchaure June 16, 2023 08:52
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #35737 (fa8bd99) into develop (50f8385) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35737      +/-   ##
===========================================
- Coverage    64.14%   64.13%   -0.01%     
===========================================
  Files          810      810              
  Lines        61880    61880              
===========================================
- Hits         39690    39689       -1     
- Misses       22190    22191       +1     
Impacted Files Coverage Δ
erpnext/stock/doctype/pick_list/pick_list.py 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ankush ankush merged commit 81f916b into frappe:develop Jun 16, 2023
mergify bot pushed a commit that referenced this pull request Jun 16, 2023
ankush added a commit that referenced this pull request Jun 16, 2023
#35737) (#35740)

perf: Ignore cancelled pick lists while fetching picked items (#35737)

(cherry picked from commit 81f916b)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Jun 20, 2023
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20)

### Bug Fixes

* `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5))
* add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c))
* Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68))
* cannot start / stop jobs ([53ec2a9](53ec2a9))
* conflicts ([697fcef](697fcef))
* consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85))
* date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd))
* don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f))
* Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4))
* fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4))
* for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b))
* incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2))
* incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950))
* keyerror while checking the stock balance report ([baf014f](baf014f))
* loan interest accrual date ([#35695](#35695)) ([070df97](070df97))
* **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1))
* stock error for service item ([2bbea63](2bbea63))
* test case ([4af0a9b](4af0a9b))
* unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc))
* update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8))
* **ux:** set route options for new `Batch` ([b261242](b261242))
* validation of job card in stock entry ([ce2bf5f](ce2bf5f))
* work order serial no issue ([50a8907](50a8907))

### Performance Improvements

* Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c))
* duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2))
* Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d))
* index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8))
* Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6))
* Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant