-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consider field precision while setting sle actual_qty #35717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-aga-r
changed the title
fix: consider qty field precision while setting sle actual_qty
fix: consider field precision while setting sle actual_qty
Jun 15, 2023
s-aga-r
added
backport develop
instructs mergify to frontport PR to develop branch
and removed
backport develop
instructs mergify to frontport PR to develop branch
labels
Jun 15, 2023
s-aga-r
added
backport develop
instructs mergify to frontport PR to develop branch
and removed
buying
needs-tests
This PR needs automated unit-tests.
labels
Jun 15, 2023
s-aga-r
force-pushed
the
FIX-ISS-23-24-01422
branch
from
June 15, 2023 13:11
4b00ddd
to
d0f4151
Compare
s-aga-r
force-pushed
the
FIX-ISS-23-24-01422
branch
from
June 15, 2023 13:12
d0f4151
to
2fcd1d5
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
(cherry picked from commit 3f62e85) # Conflicts: # erpnext/controllers/buying_controller.py
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20) ### Bug Fixes * `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5)) * add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c)) * Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68)) * cannot start / stop jobs ([53ec2a9](53ec2a9)) * conflicts ([697fcef](697fcef)) * consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85)) * date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd)) * don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f)) * Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4)) * fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4)) * for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b)) * incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2)) * incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950)) * keyerror while checking the stock balance report ([baf014f](baf014f)) * loan interest accrual date ([#35695](#35695)) ([070df97](070df97)) * **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1)) * stock error for service item ([2bbea63](2bbea63)) * test case ([4af0a9b](4af0a9b)) * unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc)) * update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8)) * **ux:** set route options for new `Batch` ([b261242](b261242)) * validation of job card in stock entry ([ce2bf5f](ce2bf5f)) * work order serial no issue ([50a8907](50a8907)) ### Performance Improvements * Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c)) * duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2)) * Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d)) * index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8)) * Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6)) * Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
🎉 This PR is included in version 14.27.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source / Ref: ISS-23-24-01422
Use case: Purchase Receipt with a Serial Item having Qty 1581.632 (UOM = Kg) and Actual Received Qty is 410 i.e., Conversion Factor will be 0.196. But now when you try to submit the receipt an error will be thrown Serial No {item-code} quantity 309.99987200000004 cannot be a fraction.
Changes: Consider the field precision while setting the SLE Actual Qty. Users can update the Accepted Qty in Stock UOM field precision using Customize Form.
Purchase Order
Before
After: