fix: unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search #35710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OS Barcode search
vishdha
commented
Jun 15, 2023
| @@ -59,7 +58,7 @@ def search_by_term(search_term, warehouse, price_list): | |||
| "price_list": price_list, | |||
| "item_code": item_code, | |||
| }, | |||
| fields=["uom", "stock_uom", "currency", "price_list_rate"], | |||
There was a problem hiding this comment.
there is no stock_uom field in item price
deepeshgarg007
added
the
backport develop
deepeshgarg007
added a commit
that referenced
this pull request
Jun 19, 2023
…OS Barcode search (#35710) * fix: unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search (#35710) (cherry picked from commit 58a6bbc) # Conflicts: # erpnext/selling/page/point_of_sale/point_of_sale.py * chore: resolve conflicts --------- Co-authored-by: Vishal Dhayagude <vishdha@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20) ### Bug Fixes * `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5)) * add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c)) * Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68)) * cannot start / stop jobs ([53ec2a9](53ec2a9)) * conflicts ([697fcef](697fcef)) * consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85)) * date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd)) * don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f)) * Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4)) * fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4)) * for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b)) * incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2)) * incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950)) * keyerror while checking the stock balance report ([baf014f](baf014f)) * loan interest accrual date ([#35695](#35695)) ([070df97](070df97)) * **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1)) * stock error for service item ([2bbea63](2bbea63)) * test case ([4af0a9b](4af0a9b)) * unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc)) * update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8)) * **ux:** set route options for new `Batch` ([b261242](b261242)) * validation of job card in stock entry ([ce2bf5f](ce2bf5f)) * work order serial no issue ([50a8907](50a8907)) ### Performance Improvements * Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c)) * duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2)) * Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d)) * index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8)) * Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6)) * Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
|
🎉 This PR is included in version 14.27.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: Traceback (most recent call last):
File "apps/frappe/frappe/app.py", line 66, in application
response = frappe.api.handle()
File "apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "apps/frappe/frappe/handler.py", line 45, in handle
data = execute_cmd(cmd)
File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "apps/frappe/frappe/init.py", line 1607, in call
return fn(*args, **newargs)
File "apps/erpnext/erpnext/selling/page/point_of_sale/point_of_sale.py", line 96, in get_items
result = search_by_term(search_term, warehouse, price_list) or []
File "apps/erpnext/erpnext/selling/page/point_of_sale/point_of_sale.py", line 52, in search_by_term
item_stock_qty = item_stock_qty // item.get("conversion_factor")
TypeError: unsupported operand type(s) for //: 'float' and 'NoneType'
before:
New.POS.Invoice.-.new-pos-invoice-1.5.mp4
after:
New.POS.Invoice.-.new-pos-invoice-1.4.mp4