Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hostname for Elasticsearch and add CI test #614

Closed
wants to merge 25 commits into from
Closed

Fix hostname for Elasticsearch and add CI test #614

wants to merge 25 commits into from

Conversation

hellspawn679
Copy link
Contributor

What this PR does

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format,
will close that issue when PR gets merged)

  • fixes #

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@yurishkuro yurishkuro changed the title fixed hostname for es provisionDataStore.elasticsearch and added ci test Fix hostname for Elasticsearch and add CI test Oct 30, 2024
yurishkuro
yurishkuro reviewed Oct 30, 2024
View reviewed changes
.github/workflows/es.yaml Outdated
- name: Check if cert-manager is up
run: |
cmctl check api --wait=5m
- name: Run chart-testing (install)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: we can move all steps up to this point into a shared helper action (example) and not repeat them in each workflow. Then instead of defining a new workflow file you can add an extra job in the main workflow

@yurishkuro yurishkuro mentioned this pull request Oct 30, 2024
Merged
5 tasks
coryflucas and others added 16 commits November 1, 2024 17:30
@coryflucas
correct indentation of imagePullSecrets in indexer and lookback cronj…
36f1f3f 
…obs (jaegertracing#568)

Signed-off-by: mehul <mehulsharam4786@gmail.com>
@pavelnikolov
Update Chart.yaml
4780e1b 
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@pavelnikolov
Bump chart version
4269683 
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@coryflucas
quote host name in ingress templates (jaegertracing#572)
7d84655 
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@Stevenpc3
Fix typo preventing use of global.imageRegistry (jaegertracing#577)
026c454 
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@jimmy-ungerman
upgrade jaeger-operator to latest 1.57 version (jaegertracing#573)
5cbfc49 
Signed-off-by: Jimmy Ungerman <jimmy@defenseunicorns.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@pavelnikolov
fix storage val in readme
7f77941 
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@pavelnikolov
Add missing quotes in readme
d2f428b 
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@rgaduput
[jaeger] add new options, improvements into allInOne (jaegertracing#586)
7837343 
* [jaeger] allInOne add option automountServiceAccountToken for serviceaccount

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add affinity support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add topologySpreadConstraints support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add podSecurityContext and containerSecurityContext support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

---------

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@chenlujjj
[jaeger] allInOne add option tolerations (jaegertracing#588)
971a196 
Signed-off-by: chenlujjj <953546398@qq.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@yurishkuro
Link to sub-READMEs
6514064 
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@vishukamble
[jaeger] Add ability to edit port name and target port name in query …
224088b 
…and collector services (jaegertracing#590)

Signed-off-by: mehul <mehulsharam4786@gmail.com>
@shivendoodeshmukh
[jaeger-operator] Add ingressclasses to role.yaml so that the CRD has…
b4eba18 
… correct permissions when rbac.cluster.Role is set (jaegertracing#591)

* Update role.yaml to solve issue 581

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>

* Bump Chart Version

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>

---------

Signed-off-by: shivendoodeshmukh <shivendoo@gcoea.ac.in>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@kravciak
Fix Update role.yaml to solve issue 581 (jaegertracing#592)
5bf976f 
Signed-off-by: Martin Kravec <kravciak@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@brainstorm82 @pavelnikolov
[jaeger] Add securityContext for spark cron job (jaegertracing#587)
86b3c31 
Signed-off-by: Andreas Seelinger <Andreas.Seelinger@accenture.com>
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Co-authored-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@pavelnikolov
Add cassandra schema job toleration (jaegertracing#598)
fb7d680 
Signed-off-by: Pavel Nikolov <me@pavelnikolov.net>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
elukey and others added 6 commits November 1, 2024 17:30
@elukey
[jaeger] Add securityContext for the oauth sidecar in query-deploy.ya…
7110c61 
…ml (jaegertracing#600)

The sidecar is missing the securityContext entry, and it makes it
difficult to apply specific settings in the context of K8s PSS
(migrating from PSP for example).

Signed-off-by: Luca Toscano <ltoscano@wikimedia.org>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@K3ndu
[jaeger] Add missing loadBalancerIp to collector-svc template (jaeger…
6d51b06 
…tracing#601)

Signed-off-by: Kendi Paet <kendi@tavex.eu>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@rgaduput
Jaeger allInOne allow different storage types (jaegertracing#603)
ce10d09 
Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@bowdenblair
upgrade jaeger-operator to latest 1.61.0 (jaegertracing#605)
e5352db 
Signed-off-by: Blair Bowden <blair@radiusmethod.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@hellspawn679
added all-in-one deployment and configmap for jaeger-v2
4dc1c31 
Signed-off-by: Mehul <mehulsharma4786@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
@hellspawn679
lint fix
f14ffe3 
Signed-off-by: Mehul <mehulsharma4786@gmail.com>
Signed-off-by: mehul <mehulsharam4786@gmail.com>
yurishkuro
yurishkuro approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hellspawn679 and others added 3 commits November 3, 2024 00:32
@hellspawn679
fixed hostname for es provisionDataStore.elasticsearch and added ci t…
dfec458 
…est for it

Signed-off-by: mehul <mehulsharam4786@gmail.com>
@yurishkuro
Share setup sub-action in CI (jaegertracing#615)
18b296e 
* Share setup sub-action in CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: mehul <mehulsharam4786@gmail.com>

Update Chart.yaml

Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
@rgaduput
[jaeger] add new options, improvements into allInOne (jaegertracing#586)
1b91023 
* [jaeger] allInOne add option automountServiceAccountToken for serviceaccount

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add affinity support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add topologySpreadConstraints support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* [jaeger] allInOne add podSecurityContext and containerSecurityContext support

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

---------

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@davidvonthenen davidvonthenen Awaiting requested review from davidvonthenen

@naseemkullah naseemkullah Awaiting requested review from naseemkullah naseemkullah is a code owner

@pavelnikolov pavelnikolov Awaiting requested review from pavelnikolov pavelnikolov is a code owner

@batazor batazor Awaiting requested review from batazor batazor is a code owner

@cpanato cpanato Awaiting requested review from cpanato cpanato is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.