Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trusted-tester-bugs): Fix All Button in More Info Dialog in High Contrast Mode #3029

Merged

Conversation

AhmedAbdoOrtiga
Copy link
Contributor

@AhmedAbdoOrtiga AhmedAbdoOrtiga commented Jul 6, 2020

Description of changes

Description of changes
Problem:
"Inspect HTML", "Copy failure details" and "File issue" buttons are not visible in high contrast black theme in the injected more info dialog.

Solution:
"Inspect HTML", "Copy failure details" and "File issue" buttons should be visible in high contrast black theme.

Before:
hc mode inspect issue buttons before

After":
hc mode inspect issue buttons after

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

AhmedAbdoOrtiga and others added 30 commits April 1, 2020 13:19
chore(deps-dev): bump @types/react from 16.9.32 to 16.9.33 (microsoft#2470)
@AhmedAbdoOrtiga AhmedAbdoOrtiga requested a review from a team as a code owner July 6, 2020 22:03
@AhmedAbdoOrtiga AhmedAbdoOrtiga merged commit fa9e1fc into microsoft:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants