Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback registration functions to SimpleActionClient #99

Open
wants to merge 7 commits into
base: indigo-devel
Choose a base branch
from
Open

Add callback registration functions to SimpleActionClient #99

wants to merge 7 commits into from

Conversation

finger563
Copy link

@finger563 finger563 commented Apr 3, 2018 •
edited by mikaelarguedas
Loading

Mirrors the structure of the SimpleActionSever which allows

void registerGoalCallback (boost::function< void()> cb)
void registerPreemptCallback (boost::function< void()> cb)

so that the SimpleActionClient would have methods

void registerDoneCallback (SimpleDoneCallback cb)
void registerActiveCallback (SimpleActiveCallback cb)
void registerFeedbackCallback (SimpleFeedbackCallback cb)

connects to #101

@finger563 finger563 mentioned this pull request Apr 3, 2018
Closed
@finger563
Copy link
Author

I'm not sure why this says the build is failing but I'm able to run my own code as well as the examples from ros/common_tutorials

@mikaelarguedas
Copy link
Member

API + ABI breaking: to consider for ROS Noetic

@mikaelarguedas mikaelarguedas added the abi_break Change breaking ABI that should be considered for future ROS distribution label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
abi_break Change breaking ABI that should be considered for future ROS distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finger563 @mikaelarguedas