Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase off master prebid #24

Merged
merged 33 commits into from
Jun 26, 2018
Merged

Rebase off master prebid #24

merged 33 commits into from
Jun 26, 2018

Commits on Jun 20, 2018

  1. update some unit tests to clean-up consentManagement hooks (#2711) 

    * update some unit tests to clean-up gdpr module hooks

* add cleanup for pubCommonId requestBids hook
    @jsnellbaker @mkendall07
    jsnellbaker authored and mkendall07 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    b60a752 View commit details
    Browse the repository at this point in the history

  2. fix(AdyoulikeAdapter): set withCredentials option to true (#2661)

    @jaiminpanchal27
    Jeremy Hernandez authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    b90f12d View commit details
    Browse the repository at this point in the history

  3. update consentManagement error logic/handling (#2723)

    @jsnellbaker @jaiminpanchal27
    jsnellbaker authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    44fb866 View commit details
    Browse the repository at this point in the history

  4. enhance logWarn message (#2724)

    @jsnellbaker @jaiminpanchal27
    jsnellbaker authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    f60e239 View commit details
    Browse the repository at this point in the history

  5. Debugging (#2687) 

    * new debugging functionality with bid overrides

* update name from bidderOverrides to debugging

* change sessionStorage to window.sessionStorage

* solve sinon stubbing sessionStorage issue with dependency injection
    @snapwich @jaiminpanchal27
    snapwich authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    960ffdd View commit details
    Browse the repository at this point in the history

  6. add encodeURIComponent (#2660)

    @AdmixerTech @jaiminpanchal27
    AdmixerTech authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    8873b21 View commit details
    Browse the repository at this point in the history

  7. Function name was not logical (#2751)

    @jaiminpanchal27 @mkendall07
    jaiminpanchal27 authored and mkendall07 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    4daab3d View commit details
    Browse the repository at this point in the history

  8. Max origin concurrent auctions (#2743) 

    * initial attempt at limiting concurrenet auctions by origin

* fix queueing of auctions for max origin

* don't decrement on timeout as it is already called by onreadystatechange

* move auction timer so it doesn't start until queued auction starts

* set default max concurrent origin requests to 4 and make configurable

* fix tests to not queue for auction.callBids

* change MAX_REQUEST_PER_ORIGIN to local var
    @snapwich @jaiminpanchal27
    snapwich authored and jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    050494e View commit details
    Browse the repository at this point in the history

  9. allow s2s bidders call pbs without need of a client adapter file (#2704) 

    * allow s2s adapters call pbs without client adapter file

* add support in aliasBidAdapter for s2s-only bidders
    @jsnellbaker @mkendall07
    jsnellbaker authored and mkendall07 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    8036838 View commit details
    Browse the repository at this point in the history

  10. Prebid 1.15.0 Release

    @jaiminpanchal27
    jaiminpanchal27 committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    64f8e01 View commit details
    Browse the repository at this point in the history

  11. Add GDPR support for Quantcast adapter (#2733) 

    * Add GDPR support for Quantcast adapter

* Fix lint error
    @soarez @harpere
    soarez authored and harpere committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    0dda32f View commit details
    Browse the repository at this point in the history

  12. ixBidAdapter.js: allow siteId param to be number (#2729) 

    * ixBidAdapter.js: allow siteId param to be number

In v0.x, the siteID param would be string or number. Somehow, this was restricted to just a string in v1.x.

* ixBidAdapter.js logical error (not enough coffee)

* ixBidAdapter_spec.js: allow number for backwards compat
    @homeyjd @harpere
    homeyjd authored and harpere committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    ae287c3 View commit details
    Browse the repository at this point in the history

  13. Audience Network: add debug params to bid requests (#2657) 

    Remove deprecated pbv param
    @lovell @harpere
    lovell authored and harpere committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    3418665 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. Update CONTRIBUTING.md (#2757)

    @dbemiller
    Pascal S authored and dbemiller committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    9fc7045 View commit details
    Browse the repository at this point in the history

  2. Increment Pre Release

    @jaiminpanchal27
    jaiminpanchal27 committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    2507f4b View commit details
    Browse the repository at this point in the history

  3. Temporarily remove ios browsers from browserstack testing (#2759) 

    * update ios browsers

* removing ios browsers
    @jsnellbaker
    jsnellbaker committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    3868077 View commit details
    Browse the repository at this point in the history

  4. Rubicon adapter: add support for new size (#2760)

    @bretg @snapwich
    bretg authored and snapwich committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    d30de32 View commit details
    Browse the repository at this point in the history

  5. Update RELEASE_SCHEDULE.md (#2749)

    @bretg @mkendall07
    bretg authored and mkendall07 committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    0c25ef6 View commit details
    Browse the repository at this point in the history

  6. Added Weborama bid adapter (#2710)

    @devweborama @snapwich
    devweborama authored and snapwich committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    7e53e83 View commit details
    Browse the repository at this point in the history

  7. move logic to check if CMP frame is not found (#2715)

    @jsnellbaker @snapwich
    jsnellbaker authored and snapwich committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    4723710 View commit details
    Browse the repository at this point in the history

  8. Add crs parameter to eplanning adapter (#2682)

    @matimar @snapwich
    matimar authored and snapwich committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    af9b294 View commit details
    Browse the repository at this point in the history

  9. extracted bidder from recieved object in timeout event (#2741)

    @tegner @snapwich
    tegner authored and snapwich committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    ead7aa9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2018

  1. adding beta-releases to TOC (#2763)

    @bretg
    bretg committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    0c578b0 View commit details
    Browse the repository at this point in the history

  2. Feature/normalize size (#2738) 

    * Fix for incorrectly uppercased keys

* normalized the banner sizes param to always be [[h,w]]
    @mkendall07 @harpere
    mkendall07 authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    cdbd9cf View commit details
    Browse the repository at this point in the history

  3. Sharethrough - handle iframe bid param, safeframe support (#2762) 

    - if true, Sharethrough ad markup will not break out of iframe
- this also adds safeframe support
    @jchau87 @harpere
    jchau87 authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    33a502b View commit details
    Browse the repository at this point in the history

  4. Integration of Realvu analytics in Somo adapter (#2728) 

    * Integration of Realvu analytics in Somo adapter

* Bug Fixes

* Reworked adapter to not require or include the realvu adapter.  instead checking for and using the variables directly
    @SuprPhatAnon @harpere
    SuprPhatAnon authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    7d6504d View commit details
    Browse the repository at this point in the history

  5. Refactored URL query parameter passthrough for additional values, cha… 

    …nged SSP endpoint to v.lkqd.net, and updated associated unit tests (#2758)
    @mrcrawfo @harpere
    mrcrawfo authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    60e84cf View commit details
    Browse the repository at this point in the history

  6. Add user sync to Beachfront adapter (#2761)

    @jsalis @harpere
    jsalis authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    415926a View commit details
    Browse the repository at this point in the history

  7. Add gdpr and targeting support for Yieldlab adapter (#2755) 

    * Add targeting support

Support for optional key-value targeting. As the request to Yieldlab is joint, we expect the targeting params to be present for only one of the adUnits or to be the same for every adUnit.

* Add GDPR support

Support for the Prebid.js consent management module. Passing "consent" and "gdpr" (default: true) parameters if present.
    @mirkorean @harpere
    mirkorean authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    e8f543b View commit details
    Browse the repository at this point in the history

  8. sending information about prebid and adapter versions in request (#2753) 

    * sending information about prebid and adapter versions in request

* tests for new params
    @nwlosinski @harpere
    nwlosinski authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    afd974b View commit details
    Browse the repository at this point in the history

  9. add request timestamp and fix casing (#2664)

    @samuelhorwitz @harpere
    samuelhorwitz authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    30f7665 View commit details
    Browse the repository at this point in the history

  10. check if bidder exists before making request object (#2695) 

    * check if bidder exists before making request object

* remove redundant check
    @jsnellbaker @harpere
    jsnellbaker authored and harpere committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    5c08569 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2018

  1. allow outstream video, remove parsePosition method, simplify code (#2683 

    )

* allow outstream video, remove parsePosition method, simplify code

* update media type validation rule

* update media type validation rule

* video objetc bug fix

* cover no instream no outstream case

* add 'Rubicon bid adapter' as the prefix for log messages
    @moonshells @snapwich
    moonshells authored and snapwich committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    0c4b815 View commit details
    Browse the repository at this point in the history