Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some imports from sage.rings.all #33000

Closed
mkoeppe opened this issue Dec 9, 2021 · 15 comments
Closed

Remove some imports from sage.rings.all #33000

mkoeppe opened this issue Dec 9, 2021 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 9, 2021

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 759b0dd

Reviewer: Marc Mezzarobba, Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33000

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 9, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

Commit: 0a14b55

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

New commits:

b4791abgit grep -l 'rings[.]all import' | xargs sed -i.bak 's/rings[.]all import PolynomialRing/rings.polynomial.polynomial_ring_constructor import PolynomialRing/'
cfe563cFix up imports
0a14b55Remove imports from sage.rings.all

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title Remove imports from sage.rings.all Remove some imports from sage.rings.all Dec 9, 2021
@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 15, 2021

comment:4

Thank you

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 23, 2021

Changed commit from 0a14b55 to e197a91

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 23, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e197a91Merge tag '9.5.beta9' into t/33000/remove_imports_from_sage_rings_all

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 27, 2021
@orlitzky
Copy link
Contributor

Changed reviewer from Marc Mezzarobba to Marc Mezzarobba, Michael Orlitzky

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 27, 2021

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 29, 2022

comment:9

Merge failure on top of:

1dfe85bb51 Trac #32993: add pictures to line.py documentation

8ed386f88f Trac #32989: Remove imports from sage.misc.all

9d8ca508f2 Trac #32987: Deprecate sage.misc.misc.sage_makedirs

13f11bc57b Trac #32986: sage.misc.temporary_file: Move SAGE_TMP implementation here

dac469622d Trac #32985: cython: Update to 0.29.25

6d58b727ec Trac #32984: fix _row_ambient_module/_column_ambient_module and make them public

858cc31f42 Trac #32979: minor details in combinat

7e7e2850eb Trac #32978: fix usage of underscore in combinat loops

3e993e3833 Trac #32970: fix parent of 0th Bernoulli polynomial

7e9f663d58 Trac #32968: Update sphinx to 4.3

bebc3ce9bb Trac #32891: Unstable doctest geometry/hyperbolic_space/hyperbolic_model.py

2cfe03a5db Trac #32890: Unstable doctest in hmm/chmm.pyx

be9b2b085a Trac #32888: Feature for sage.groups

aa68f51edb Trac #32881: Feature for sage.rings.padics

8bbb0396d3 Trac #32877: Remove superfluous set_random_seed() calls

f3ce6a3b60 Trac #32873: sage.features, sage_setup: Replace use of distutils.errors by setuptools

f6b073a4c8 Trac #32856: Get rid of "# optional - build"

af111f45be Trac #32846: sage.geometry: More # optional

4c9d3c693a Trac #32802: Clean the use of weights in graph.py

8ff92bbb9a Trac #32798: Clean the use of weights in generic_graph.py - part 1

489917b93e Trac #32726: quaternion ideals' .scale() incorrectly copies cached left and right orders

b00a097998 Trac #32683: LP Bounds for Johnson Scheme, Q-Polynomial Association Schemes

94c664586a Trac #32553: Fix coefficient method for modular forms

28e310a9f7 Trac #32510: Update igraph to 0.9.5 and python_igraph to 0.9.8

4a973c1a06 Trac #32451: asymptotic expansions: improve compare_with_values(), including support for interval coefficients

64dff087ea Trac #32252: fix colours of tiles in TilingSolver

8426f59eba Trac #31787: Alternative parameters for generating a k-regular sequence from recurrence relations

ea1c94abc9 Trac #31424: wrong result for bool(a <= b)

3add19f748 Trac #31306: sage.repl: Replace use of SAGE_EXTCODE by importlib.resources

076224984e Trac #31299: Chu-Vandermonde simplification fails

d24931ecd1 Trac #31013: Remove unused class from sage_setup.optional extension

4d48fa5437 Trac #30362: Add symplectic structures

a8e84a5be4 Trac #29865: Modularization of sagelib: Break out separate packages sagemath-objects, sagemath-categories

77d23c7e4a Trac #25633: Speed up SBox module

cf5d0fdd73 Trac #21325: k-regular sequences: subsequences, forward/backward difference, partial sums

5ca0fed88f Trac #33189: Make tests pass with arb 2.22

dbef4504b6 Trac #33173: Off-by-one error in CFiniteSequence slices

12b383241b Trac #33131: Installation manual: Add decision tree, remove mention of Sage-mirror-hosted binary distributions

c08f68e732 Trac #33101: lrslib: fix doctest in game_theory/parser.py

4e495196e3 Trac #33077: pari-jupyter: Reinstate

3eae8fea1c Trac #33027: zombie maxima process - if invoked from a script

3f99298f0d Trac #8450: intermediate complex expression in real functions make many plot functions fail

5f30e62152 Trac #33243: Parallel docbuild broken with GNU make 4

3320e6e Trac #33240: Demote linter errors about importing from "all" to warnings for now

4fc017f Trac #33183: Better fix installation of cryptominisat and pycryptosat

34ab622 Trac #33151: sage-conf_pypi does not build wheelhouse

fb599d0 Trac #30933: GH Actions: Repair upload of docker images to docker.pkg.github.com

7f8ee0f Trac #33219: defining back ffmpeg as an external feature (which are not doctested by default)

97d550d Updated SageMath version to 9.5.rc4

merge was not clean: conflicts in src/sage/schemes/toric/variety.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

759b0ddMerge tag '9.6.beta1' into t/33000/remove_imports_from_sage_rings_all

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 14, 2022

Changed commit from e197a91 to 759b0dd

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 14, 2022

comment:11

trivial merge

@vbraun
Copy link
Member

vbraun commented Feb 20, 2022

Changed branch from u/mkoeppe/remove_imports_from_sage_rings_all to 759b0dd

@vbraun vbraun closed this as completed in 0aac323 Feb 20, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants