Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge origin/master into feature.use #1436

Merged
merged 81 commits into from
Jul 17, 2019
Merged

Merge origin/master into feature.use #1436

merged 81 commits into from
Jul 17, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 17, 2019 •
edited
Loading

[skip dart-sass]

nex3 added 30 commits June 17, 2019 16:20
@nex3
Make specs for adjust-color() style-guide-compliant
e50b242
@nex3
Make specs for scale-color() style-guide-compliant
5d73cd3
@nex3
Make specs for change-color() style-guide-compliant
6d8b652
@nex3
Make specs for ie-hex-str() style-guide-compliant
dac8f52
@nex3
Merge pull request #1405 from sass/color-fns
a24d817 
Make specs for remaining color functions style-guide-compliant
@nex3
Materialize parent HRX directories if necessary (#1408)
f5c83c0 
If an HRX directory is being materialized with #with_real_files and it
contains a file that reaches outside itself (with `../`), materialize
its parent directory as well. This allows individual tests to share
utility libraries that are defined in the same HRX archive.
@nex3
Make specs for percentage() style-guide-compliant
8ca5ff4
@nex3
Make specs for round() style-guide-compliant
b0edd65
@nex3
Make specs for ceil() style-guide-compliant
5b7bf63
@nex3
Make specs for floor() style-guide-compliant
154887b
@nex3
Make specs for abs() style-guide-compliant
53a8027
@nex3
Make specs for max() and min() style-guide-compliant
ebf9384
@nex3
Make specs for random() style-guide-compliant
7526f02
@nex3
Make specs for unit() style-guide-compliant
fb32335
@nex3
Make specs for unitless() style-guide-compliant
96b9625
@nex3
Make specs for comparable() style-guide-compliant
dde5196
@nex3
Update deprecation warnings (#1409)
214b086
@nex3
Merge pull request #1410 from sass/math-fns
89531ae 
Make math function specs style-guide-compliant
@nex3
Update specs for merging Dart Sass's feature.use into master (#1411)
7071a54
@nex3
Make specs for unquote() style-guide-compliant
5c19330
@nex3
Make specs for quote() style-guide-compliant
173e3ad
@nex3
Make specs for str-length() style-guide-compliant
f2f5ecd
@nex3
Make specs for str-insert() style-guide-compliant
4650635
@nex3
Move existing list specs into core_functions/list
cbf9604 
This also cleans up the join specs a bit.
@nex3
Always add spec/ to the load path
e4e3357 
This makes it easier to load utility libraries.
@nex3
Add a utility library for dealing with internal representations
e523c86
@nex3
Make specs for length() style-guide-compliant
3fc2942
@nex3
Make specs for nth() style-guide-compliant
e04521e
@nex3
Make specs for set-nth() style-guide-compliant
460f9ae
@nex3
Make specs for str-index() style-guide-compliant
7e0a16d
nex3 and others added 25 commits July 3, 2019 15:34
@nex3
Update Dart Sass specs for alpha()
57e60b0 
See sass/dart-sass#700
@nex3
Update Dart Sass spec for invert(..., 50%)
1394c0b 
See sass/dart-sass#704
@nex3
Update Dart Sass spec for plain-CSS invert() with a weight
c9dd1e4 
See sass/dart-sass#705
@nex3
Update Dart Sass spec for adjust-color() with $hue and $alpha
7313393 
See sass/dart-sass#708
@nex3
Update Dart Sass spec for str-slice() with astral plane characters
57e2a05 
See sass/dart-sass#732
@nex3
Update Dart Sass spec for str-insert() with $index -1
43d1a4d 
See sass/dart-sass#733
@nex3
Update Dart Sass specs for empty map separators
ae26bc0 
See sass/dart-sass#737
@nex3
Update Dart Sass specs for join() and append() $separator errors
ef647e9 
See sass/dart-sass#738
@nex3
Update Dart Sass spec for zip() with no arguments
5951337 
See sass/dart-sass#739
@nex3
Update Dart Sass spec for map-remove() with a named $key argument
27efe6f 
See sass/dart-sass#742
@nex3
Merge pull request #1424 from sass/dart-sass-fixes
d8dc38c 
Remove Dart Sass TODOs for function specs
@mgreter
Allow arguments to be passed to any command
07102ee 
Renames `--dart-args` to `--cmd-args`
@mgreter
Merge pull request #1426 from mgreter/feature/proxy-cmd-args
7cb62b5 
Allow arguments to be passed to any command
@nex3
Make Dart Sass errors the default in spec/get-function
72957a1
@nex3
Code review changes
6d301b1
@nex3
Merge pull request #1422 from sass/meta-fns
d197951 
Make meta function specs style-guide-compliant
@nex3
Merge spec/directives/import/nested into a single HRX
e7e2af8
@nex3
Add specs for at-rules in nested imports
f686457
@nex3
Merge pull request #1429 from sass/nested-import-keyframes
a62d330 
Add specs for at-rules in nested imports
@kaj @nex3
Fix a filename typo (#1431)
3484624 
Fix what I assue must be a typo in a filename in
different_module/defined in spec/core_functions/meta/mixin_exists.hrx
@nschonni @nex3
fix: Enable for libsass 2894 (#1421)
60875af
@nschonni @nex3
fix: Enable libsass 2914 (#1420)
a838a41
@nex3
Update feature-exists() specs for sass/libsass#2929 (#1434)
b7cc904
@mgreter @nex3
Fix typo in silent comment error message (#1432)
3f45fb6
@nex3
Merge remote-tracking branch 'origin/master' into feature.use
d0d1985
@nex3 nex3 requested a review from jathak July 17, 2019 01:48
@nex3 nex3 mentioned this pull request Jul 17, 2019
Merged
jathak
jathak approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Ruby, so I'm assuming those changes have already been reviewed. The rest LGTM.

@nex3 nex3 merged commit 3a9889c into feature.use Jul 17, 2019
@nex3 nex3 deleted the merge-master branch July 17, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nex3 @mgreter @jathak @kaj @nschonni