Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201911 fixes show ipv6 interfaces issue #937

Closed
wants to merge 70 commits into from
Closed

201911 fixes show ipv6 interfaces issue #937

wants to merge 70 commits into from

Conversation

tim-rj
Copy link
Contributor

@tim-rj tim-rj commented Jun 8, 2020

- What I did
check ipv6 interfaces

- How I did it
show ipv6 interfaces

- How to verify it
show ipv6 interfaces

- Previous command output (if the output of a command-line utility has changed)
root@switch2:/home/admin# show ipv6 interfaces
Interface Master IPv6 address/mask Admin/Oper BGP Neighbor Neighbor IP


Bridge fe80::88dc:a8ff:fecf:f537%Bridge/64 up/up N/A N/A
Ethernet0 PortChannel1 fe80::5a69:6cff:fefb:2230%Ethernet0/64 up/up N/A N/A
Ethernet52 2001:50:5:1::2/64 up/up N/A N/A
fe80::5a69:6cff:fefb:2230%Ethernet52/64
Loopback0 6::6/128 up/up N/A N/A
fe80::44f4:e3ff:fe31:cc94%Loopback0/64
PortChannel1 Bridge fe80::5a69:6cff:fefb:2230%PortChannel1/64 up/up N/A N/A
Vlan3 150::1/64 up/up N/A N/A
fe80::5a69:6cff:fefb:2230%Vlan3/64
eth0 fe80::5a69:6cff:fefb:2230%eth0/64 up/up N/A N/A
lo ::1/128 up/up N/A N/A
root@switch2:/home/admin# show ipv6 interfaces
root@switch2:/home/admin# show ipv6 interfaces
Interface Master IPv6 address/mask Admin/Oper BGP Neighbor Neighbor IP


Bridge fe80::88dc:a8ff:fecf:f537%Bridge/64 up/up N/A N/A
Ethernet0 PortChannel1 fe80::5a69:6cff:fefb:2230%Ethernet0/64 up/up N/A N/A
Ethernet52 2001:50:5:1::2/64 up/up LCv6 2001:50:5:1::1
fe80::5a69:6cff:fefb:2230%Ethernet52/64
Loopback0 6::6/128 up/up N/A N/A
fe80::44f4:e3ff:fe31:cc94%Loopback0/64
PortChannel1 Bridge fe80::5a69:6cff:fefb:2230%PortChannel1/64 up/up N/A N/A
Vlan3 150::1/64 up/up N/A N/A
fe80::5a69:6cff:fefb:2230%Vlan3/64
eth0 fe80::5a69:6cff:fefb:2230%eth0/64 up/up N/A N/A
lo ::1/128 up/up N/A N/A

santhosh-kt and others added 30 commits December 31, 2019 14:07
* Fastboot/warmboot platform plugin

* Added platform plugin
Add utility to translate text output of syseeprom dump into JSON, for
consumption by new management (1.0) command.

Signed-off-by: Howard Persh <hpersh@yahoo.com>
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Currently it misses the case where data for a new key is empty.
#757)

* [neighbor advertiser] catch all exceptions while trying https endpoint

When connecting https endpoint failed, we need to try http endpoint.
Therefore we need to catch all exceptions.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* raise exception if https returned non-success status code
…re (#758)

* [neighbor advertiser] raise exception when http endpoint return failure

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Delete deprecated error checking code

* Add back check for None
…(s) (#761)

Once any critical service is shutdown (radv/swss/syncd), we have to
commit to the reboot. Failing in the middle will leave the system in
bad state.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
#770)

* A generic JSON file updater, which can add/update-existing attributes.
This tool would be used to update /etc/sonic/core_analyzer.rc.json file to add
credentials by HW proxy.

* Updated per review comments.
The option is better named.
* [portstat] fix header used

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

* [portstat] fix print table_as_json

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

* Fix tx_ovr field
* [show] enhance 'show ip[v6] bgp summary' command
* changing ipaddr to ipaddress
…op counters (#784)

Signed-off-by: Danny Allen <daall@microsoft.com>
Merge two vrf configuration to avoid user can't add or delete management VRF through CLI.

Co-authored-by: Minkang-Tsai <58835052+Minkang-Tsai@users.noreply.github.com>
If ACL table name contains the substring "v6", set the EtherType of the rule to V6, otherwise set to V4.
… OID->interface name mapping (#789)

In release branches prior to 201911, FDB or ARP learnt on VLAN interface LAG port will cause nothing to appear in the "show arp" or "show mac" output because there existed no OID->interface name never had the mappings for LAG interface.

This issue has since been fixed in master (and 201911). However, making this change in master is not harmful and will prevent a regression from causing no output to be displayed for the interface name in the future.
* [neighbor advertiser] remove http endpoint access

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Remove obsolete comment
- Remove prefix-trimming from drop reason capability query
- Remove prefix-trimming from create/add safety checks

Signed-off-by: Danny Allen <daall@microsoft.com>
Signed-off-by: akhilesh.samineni@broadcom.com
Implemented following commands to use Zero Touch Provisioning

show ztp status
config ztp enable
config ztp disable
config ztp run

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
Co-authored-by: Akhilesh Samineni <47657796+AkhileshSamineni@users.noreply.github.com>
Co-authored-by: rlhui <48738894+rlhui@users.noreply.github.com>
…or each container (#798)

Since we introduced the auto-restart feature for each container, we need add a show subcommand to display the current status of auto-restart feature for all containers or a specific container.

- How I did it
We define a function named autorestart to show the status of this features. This function will accept an option parameter which is the container name. If this parameter is not specified, this function will by default show the status of all containers. Otherwise it will show the status of specific container.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…init_cfg.json implicitly (#812)

* [config/main.py] Modify the load() and reload() functions to load config
from config_db.json and init_cfg.json.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Undo the changes which load the configuration from
init_cfg.json for load() function and define a
constant string for the path of init_cfg.json.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Correct a typo.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Added an else statement in line 551 to decide whether
the init_cfg.json exsits or not in reload function.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Correct a typo error.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Change the loading order and we should first load
init_cfg.json and then config_db.json.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>

* [config/main.py] Use constant string to represent the path of
init_cfg.json.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
…815)

This is possible if some of docker are not built then corresponding
service file will not be present
…624)

This change is related to Platform Driver Development Framework (PDDF) which is being added to sonic-buildimage repo. More details can be found here, sonic-net/SONiC#406

PDDF supports its own CLI utilities, which use generic PDDF component plugins. I added these PDDF CLI utilities.
Add a "show platform fanstatus" command to allow user fetch FAN status data.
Add a "show platform temperature" command to allow user fetch thermal status data.
…ts (#772)

* [fwutil]: initial version.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix UI: enable progressbar render finalizer.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: integrate utility with SONiC CLI.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: update CLI command reference documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Revisit CLI architecture: avoid direct imports.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: refactor CLI command reference.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: update CLI documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
jleveque and others added 28 commits April 8, 2020 10:04
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
* [Vxlan] : adding show vnet/vxlan cmds
…e for FRR routing stack (#884)

Co-authored-by: Travis Van Duyn <trvanduy@microsoft.com>
- This flag is currently no functional impact with just this change.
- This flag is intended to coordinate fast-reboot shutdown path.
- This flag enables moving fast-reboot per service knowledge to service scripts.
  which unblocks moving warm-reboot per service knowledge to service scripts.
- This flag is consistent with the bootup flag we setting on the boot up path.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Co-authored-by: Travis Van Duyn <trvanduy@microsoft.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
* [utility] Filter FDB entries

FDB table can get large due to VM creation/deletion which cause
fast reboot to slow down. This utility fitlers FDB entries based on
current MAC entries in the ARP table.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
* [Phase 1] Multi ASIC config command changes, db_mgrator.py script updates for handing namespace.

* Fixes and comment updates

* Comments addressed + added support for user to input the config files per namespace also.

* Updates per comments + based on the updated SonicV2Connector/ConfigDBConnector class design

* Review comments update.

* Help string updated for config save/reload/load
* Fix NameError for 'swsssdk', align neig output
* Changes:
1) Add syslog support.
2) Enable forever periodic scan
3) Skip link local addresses
4) Skip eth0 routes
3) Adopt to 20191130 changes
    3.1) APPl-DB INTF_TABLE may not have IP address
    3.2) nexthop is never empty

* No logical code change. A small name change.

* 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes
2) Ensure to read route entry w/o prefix, if not present with prefix
- Modify the load_minigraph command handler to support multi NPU platforms
…multi-npu platforms. (#908)

* Changes to support acl-loader command for multi-npu platforms.

Move multi-npu related utility functions from config/main.py
to sonic-device-util.py so that it can be used by acl-loader/any other
module.

Updated Mirror Session add/remove for multi-npu platforms.
Needed for Everflow ACL rule programming.

* Address review comment to change comment from """ to #
except for doc string
* Changes to ignore services stop/start for config reload and
load_minigraph command. This will be needed when executed from
config-setup script.

* Updated Command Reference document

* Address Review Comments.
…g DB (#885)

Fix is_mgmt_vrf_enabled for the case where MGMT_VRF_CONFIG is not at all in the config DB.
This is the case where mgmt vrf is never configured. The function throws error at
File "/usr/lib/python2.7/dist-packages/show/main.py", line 651, in is_mgmt_vrf_enabled
mvrf_dict = json.loads(p.stdout.read())
Two show commands uses is_mgmt_vrf_enabled. "show mgmt-vrf" and "show ntp"
Both commands throw error if mgmt vrf is never configured

Co-authored-by: Bing Sun <Bing_Sun@dell.com>
* Multi-asic changes for config bgp commands and utilities.

* Review comments update

* Optimized the logic of checking the internal hosts using AS number.

* API changes due to rebase. Also setting ignore_local_hosts=false explicitly in BGP commands so that existing single ASIC platform implementation is unchanged.
load_minigraph. The behaviour got changed as part of multi-npu change
so make it correct again.
* Changes to make lldp show command for multi-npu platforms.
We will display only front-panel port information.

* Address Review Comments.

* Added Comment

* Fix LGTM error

* Address Review Comments
* [Mellanox] add document for thermal control related cli

* Update review comments thermal zones -> thermal sensors

* Make example better
… and thermal status (#836)

* [thermal fix] use natural sort for fan status and thermal status
* [thermal fix] set fan status to N/A when fan is removed
* Adjust header name for show platform temperature output
* [thermal fix] use natural sort for fan status and thermal status
* [thermal fix] set fan status to N/A when fan is removed
* Adjust header name for show platform temperature output
@tim-rj tim-rj closed this Jun 8, 2020
@tim-rj tim-rj changed the title 201911 fixes #4716 show ipv6 interfaces issue 201911 fixes show ipv6 interfaces issue Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.