chore: Remove unused pedersen c_binds #3058

kevaundray · 2023-10-26T12:15:27Z

Related to #3029

This removes all of the unused c_binds. The typescript code has been modified to not use any of these, so at this point its not a breaking change for yarn-packages. The bb.js codegen were using these inside of tests that I added to make sure that they were computing the same thing, these tests have been removed.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

…-rename-compress

… functions

- account for argument switch - fix: allocate instead of using scratch space

…rsen-cleanup-optimize-hashing

…-remove-unused-cbinds

kevaundray · 2023-10-26T12:33:18Z

barretenberg/ts/src/barretenberg_api/pedersen.test.ts

-  it('pedersenCompressWithHashIndex', async () => {
-    const result = await api.pedersenCompressWithHashIndex([new Fr(4n), new Fr(8n)], 7);
+  it('pedersenHashWithHashIndex', async () => {
+    const result = await api.pedersenHashWithHashIndex([new Fr(4n), new Fr(8n)], 7);
    expect(result).toEqual(new Fr(2152386650411553803409271316104075950536496387580531018130718456431861859990n));


Note that this is the same expected out from the pedersenHashMultipleWithHashIndex test that we've just deleted

kevaundray · 2023-10-26T14:17:48Z

barretenberg/cpp/src/barretenberg/crypto/pedersen_hash/c_bind.cpp

+WASM_EXPORT void pedersen__hash_with_hash_index(uint8_t const* inputs_buffer, uint32_t hash_index, uint8_t* output)
 {
    std::vector<grumpkin::fq> to_compress;
    read(inputs_buffer, to_compress);
-    auto r = crypto::pedersen_hash::hash(to_compress);
+    crypto::GeneratorContext<curve::Grumpkin> ctx; // todo fix
+    ctx.offset = static_cast<size_t>(hash_index);
+    auto r = crypto::pedersen_hash::hash(to_compress, ctx);
    barretenberg::fr::serialize_to_buffer(r, output);
 }


The previous pedersen__hash_with_hash_index was using uint32_t const* hash_index whereas the previous pedersen__compress_with_hash_index was using uint32_t const hash_index -- I set this to match the compress variant, though note its now different to the c_bind_new because they are using uint32_t const*

AztecBot · 2023-10-26T14:53:26Z

Benchmark results

Metrics with a significant change:

l2_block_building_time_in_ms (8): 14,595 (-19%)
l2_block_building_time_in_ms (32): 57,709 (-19%)
l2_block_building_time_in_ms (128): 231,378 (-19%)
l2_block_rollup_simulation_time_in_ms (8): 13,284 (-19%)
l2_block_rollup_simulation_time_in_ms (32): 52,481 (-19%)
l2_block_rollup_simulation_time_in_ms (128): 210,251 (-19%)
l2_block_public_tx_process_time_in_ms (8): 1,273 (-18%)
l2_block_public_tx_process_time_in_ms (32): 5,105 (-17%)
l2_block_public_tx_process_time_in_ms (128): 20,674 (-17%)
l2_block_processing_time_in_ms (8): 2,286 (-18%)
l2_block_processing_time_in_ms (32): 8,666 (-18%)
l2_block_processing_time_in_ms (128): 34,247 (-17%)
note_successful_decrypting_time_in_ms (8): 282 (-18%)
note_successful_decrypting_time_in_ms (32): 816 (-23%)
note_successful_decrypting_time_in_ms (128): 2,984 (-24%)
note_trial_decrypting_time_in_ms (8): 84.0 (+71%)
note_trial_decrypting_time_in_ms (32): 43.0 (-61%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9b6be227 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,852	868,040	3,449,264
l1_rollup_execution_gas	841,939	3,595,148	22,204,633
l2_block_processing_time_in_ms	⚠️ 2,286 (-18%)	⚠️ 8,666 (-18%)	⚠️ 34,247 (-17%)
note_successful_decrypting_time_in_ms	⚠️ 282 (-18%)	⚠️ 816 (-23%)	⚠️ 2,984 (-24%)
note_trial_decrypting_time_in_ms	⚠️ 84.0 (+71%)	⚠️ 43.0 (-61%)	137 (-7%)
l2_block_building_time_in_ms	⚠️ 14,595 (-19%)	⚠️ 57,709 (-19%)	⚠️ 231,378 (-19%)
l2_block_rollup_simulation_time_in_ms	⚠️ 13,284 (-19%)	⚠️ 52,481 (-19%)	⚠️ 210,251 (-19%)
l2_block_public_tx_process_time_in_ms	⚠️ 1,273 (-18%)	⚠️ 5,105 (-17%)	⚠️ 20,674 (-17%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,998	49,028
note_history_successful_decrypting_time_in_ms	1,927 (-1%)	3,755 (-1%)
note_history_trial_decrypting_time_in_ms	123 (+1%)	147
node_database_size_in_bytes	1,631,111	1,101,214
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	82.2 (-9%)	61,697	18,841
private-kernel-ordering	50.9 (-9%)	24,233	8,089
base-rollup	2,085 (-8%)	656,309	811
root-rollup	89.4 (-7%)	4,072	1,097
private-kernel-inner	59.2 (-9%)	81,504	18,841
public-kernel-private-input	46.7 (-9%)	41,455	18,841
public-kernel-non-first-iteration	28.9 (-10%)	41,497	18,841
merge-rollup	0.833 (-23%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,240

Related to #3029 We can merge this into `kw/pedersen-cleanup-remove-unused-cbinds` as part of the cleanup # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).

kevaundray · 2023-10-26T16:05:02Z

barretenberg/cpp/src/barretenberg/crypto/pedersen_hash/c_bind_new.cpp

+WASM_EXPORT void pedersen_hash_init() {}
+


I just moved this to be above pedersen_hash_with_hash_index because thats how it is ordered in the header file

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ### Features * `FieldNote` ([#3037](#3037)) ([3d1ffd0](3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](#2569)) ([997c15c](997c15c)) * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Compile noir contracts with noir_wasm ([#2737](#2737)) ([524cecf](524cecf)) * Dockerize aztec-cli ([#3031](#3031)) ([ec2e3c2](ec2e3c2)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](#2740)) ([f800a36](f800a36)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](#3091)) ([906429f](906429f)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ([16abb5a](16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](#2673)) ([ccd4611](ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](#3097)) ([57bec53](57bec53)) * Broken `FieldNote` test ([#3135](#3135)) ([fe78ecf](fe78ecf)) * Docker-compose up, rather than run. ([#3081](#3081)) ([242f780](242f780)) * Formatting ([#3070](#3070)) ([e1633d3](e1633d3)) * Minor stale naming fix ([#3117](#3117)) ([a6786ae](a6786ae)) * Push cli docker image to docker hub ([#3120](#3120)) ([ccad50f](ccad50f)) * Remove duplicate terraform resource definition ([#3066](#3066)) ([d5abadb](d5abadb)) * Retry request spot ([#3116](#3116)) ([82de5f1](82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * E2e on spots [ci rebuild] ([#3068](#3068)) ([15db6bf](15db6bf)) * Fix dapp_testing e2e race condition ([#3094](#3094)) ([89e7c21](89e7c21)) * Remove docs mirror ([#3122](#3122)) ([3fa51e2](3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](#3134)) ([3e07104](3e07104)) ### Documentation * Initial keys spec ([#3035](#3035)) ([4b24c58](4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ### Features * `FieldNote` ([#3037](AztecProtocol/aztec-packages#3037)) ([3d1ffd0](AztecProtocol/aztec-packages@3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](AztecProtocol/aztec-packages#2569)) ([997c15c](AztecProtocol/aztec-packages@997c15c)) * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Compile noir contracts with noir_wasm ([#2737](AztecProtocol/aztec-packages#2737)) ([524cecf](AztecProtocol/aztec-packages@524cecf)) * Dockerize aztec-cli ([#3031](AztecProtocol/aztec-packages#3031)) ([ec2e3c2](AztecProtocol/aztec-packages@ec2e3c2)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](AztecProtocol/aztec-packages#2740)) ([f800a36](AztecProtocol/aztec-packages@f800a36)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](AztecProtocol/aztec-packages#3091)) ([906429f](AztecProtocol/aztec-packages@906429f)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ([16abb5a](AztecProtocol/aztec-packages@16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](AztecProtocol/aztec-packages#2673)) ([ccd4611](AztecProtocol/aztec-packages@ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](AztecProtocol/aztec-packages#3097)) ([57bec53](AztecProtocol/aztec-packages@57bec53)) * Broken `FieldNote` test ([#3135](AztecProtocol/aztec-packages#3135)) ([fe78ecf](AztecProtocol/aztec-packages@fe78ecf)) * Docker-compose up, rather than run. ([#3081](AztecProtocol/aztec-packages#3081)) ([242f780](AztecProtocol/aztec-packages@242f780)) * Formatting ([#3070](AztecProtocol/aztec-packages#3070)) ([e1633d3](AztecProtocol/aztec-packages@e1633d3)) * Minor stale naming fix ([#3117](AztecProtocol/aztec-packages#3117)) ([a6786ae](AztecProtocol/aztec-packages@a6786ae)) * Push cli docker image to docker hub ([#3120](AztecProtocol/aztec-packages#3120)) ([ccad50f](AztecProtocol/aztec-packages@ccad50f)) * Remove duplicate terraform resource definition ([#3066](AztecProtocol/aztec-packages#3066)) ([d5abadb](AztecProtocol/aztec-packages@d5abadb)) * Retry request spot ([#3116](AztecProtocol/aztec-packages#3116)) ([82de5f1](AztecProtocol/aztec-packages@82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * E2e on spots [ci rebuild] ([#3068](AztecProtocol/aztec-packages#3068)) ([15db6bf](AztecProtocol/aztec-packages@15db6bf)) * Fix dapp_testing e2e race condition ([#3094](AztecProtocol/aztec-packages#3094)) ([89e7c21](AztecProtocol/aztec-packages@89e7c21)) * Remove docs mirror ([#3122](AztecProtocol/aztec-packages#3122)) ([3fa51e2](AztecProtocol/aztec-packages@3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](AztecProtocol/aztec-packages#3134)) ([3e07104](AztecProtocol/aztec-packages@3e07104)) ### Documentation * Initial keys spec ([#3035](AztecProtocol/aztec-packages#3035)) ([4b24c58](AztecProtocol/aztec-packages@4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

kevaundray and others added 24 commits October 25, 2023 18:22

remove pedersen_buffer_to_field from cbinds

84c35f5

regenerate bindings

d74eb76

remove test

7586a6d

use compressWIthHashIndex for redundant methods

53c65cd

remove pedersenGetHash

4954a42

lint

3c16824

add test to show that some methods are all the same

c3a54d0

Merge remote-tracking branch 'origin/master' into kw/pedersen-cleanup…

6798941

…-rename-compress

rename compress -> hash

c1ebc73

rename codebase to use hash

18a8e74

lint

1841760

fix typos

1095911

fix typo

245e44b

Empty commit

362f185

move output argument to last position to match c_bind_new and other c…

ccd0c96

… functions

modify calling code to:

ef27e71

- account for argument switch - fix: allocate instead of using scratch space

optimize pedersenHash for wasm scratch space

0a52d4f

lint

96d4ebd

Merge branch 'master' into kw/pedersen-cleanup-argument-ordering-fix

8f7408a

charlie review: free the allocated input

3deef57

Merge branch 'kw/pedersen-cleanup-argument-ordering-fix' into kw/pede…

4a8f73b

…rsen-cleanup-optimize-hashing

remove unused cbinds

d8a6917

re-generate bindings

3aa048c

update tests

e5c922e

kevaundray changed the title ~~chore: Remove unused c_binds~~ chore: Remove unused pedersen c_binds Oct 26, 2023

Base automatically changed from kw/pedersen-cleanup-optimize-hashing to master October 26, 2023 12:30

Merge remote-tracking branch 'origin/master' into kw/pedersen-cleanup…

5a039cb

…-remove-unused-cbinds

kevaundray commented Oct 26, 2023

View reviewed changes

kevaundray added 2 commits October 26, 2023 12:59

compress -> hash

427d1d9

Merge branch 'master' into kw/pedersen-cleanup-remove-unused-cbinds

6723259

kevaundray added 2 commits October 26, 2023 14:12

make pedersen_hash look exactly like pedersen_compress

55a7e87

remove leftover function definitions from header

8ce6c40

kevaundray commented Oct 26, 2023

View reviewed changes

Empty commit

36ffe57

kevaundray marked this pull request as ready for review October 26, 2023 15:00

kevaundray commented Oct 26, 2023

View reviewed changes

ludamad approved these changes Oct 26, 2023

View reviewed changes

kevaundray merged commit e71e5f9 into master Oct 26, 2023
2 checks passed

kevaundray deleted the kw/pedersen-cleanup-remove-unused-cbinds branch October 26, 2023 16:59

AztecBot mentioned this pull request Oct 26, 2023

chore(master): Release 0.13.0 #3067

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove unused pedersen c_binds #3058

chore: Remove unused pedersen c_binds #3058

kevaundray commented Oct 26, 2023

kevaundray Oct 26, 2023

kevaundray Oct 26, 2023 •

edited

Loading

AztecBot commented Oct 26, 2023

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

kevaundray Oct 26, 2023

chore: Remove unused pedersen c_binds #3058

chore: Remove unused pedersen c_binds #3058

Conversation

kevaundray commented Oct 26, 2023

Checklist:

kevaundray Oct 26, 2023

Choose a reason for hiding this comment

kevaundray Oct 26, 2023 • edited Loading

Choose a reason for hiding this comment

AztecBot commented Oct 26, 2023

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Miscellaneous

kevaundray Oct 26, 2023

Choose a reason for hiding this comment

kevaundray Oct 26, 2023 •

edited

Loading