fix: addressing flakiness of uniswap_trade_on_l1_from_l2.test.ts

[benesjan]

A PR which hopefully addresses flakiness of uniswap l1 l2 test. In this failing test run the first test case to fail fails because the account used is not seeded with enough WETH. I think the reason for this failure was that we did not wait for the tx to be mined. For this reason I now wait for a tx receipt. I've also moved sending the mint tx from beforeEach to beforeAll and now I simply mint there more ETH. Minting before each test case just wastes time.

The second and third failing test case seems to be unrelated to the first run and I am not sure if this will fix them but I think it makes sense to wait for this to be merged and spend time on it if they fail again.

I also went through all the occurrences of ".sendTransaction(" in the codebase and ensured that we always wait for the tx to be mined.

[benesjan]

• refactor: renaming rand() as unsafe_rand() #5457
• refactor: timestamp as u64 instead of a Field #5453
• refactor: leveraging Bufferable in pedersenHash(...) and sha256ToField(...) #5444
• fix: addressing flakiness of uniswap_trade_on_l1_from_l2.test.ts #5443 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[benesjan]

I placed here this check a while ago and the message was incorrect (I though we are using anvil ETH and not WETH here).

[AztecBot]

Benchmark results

Metrics with a significant change:

• l2_block_processing_time_in_ms (64): 11,561 (+31%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5a6bcef8 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,412	6,424
l1_rollup_execution_gas	585,757	585,745	585,757
l2_block_processing_time_in_ms	1,294 (-2%)	4,731 (+2%)	⚠️ 11,561 (+31%)
note_successful_decrypting_time_in_ms	180 (-2%)	521 (+3%)	969 (+4%)
note_trial_decrypting_time_in_ms	82.5 (-11%)	37.8 (+58%)	96.5 (+52%)
l2_block_building_time_in_ms	13,912 (-2%)	53,059 (+4%)	104,799 (+5%)
l2_block_rollup_simulation_time_in_ms	7,984	28,864 (+5%)	57,530 (+8%)
l2_block_public_tx_process_time_in_ms	5,901 (-4%)	24,147 (+3%)	47,115 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,076 (+3%)	27,331 (+4%)
note_history_successful_decrypting_time_in_ms	1,291 (+2%)	2,471 (+2%)
note_history_trial_decrypting_time_in_ms	100 (-9%)	157 (+34%)
node_database_size_in_bytes	18,628,688	35,037,264
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	243 (+2%)	44,377	28,214
private-kernel-ordering	216 (+3%)	52,880	14,296
base-parity	4,544 (+3%)	128	311
root-parity	1,618 (+3%)	1,244	311
base-rollup	18,449 (+5%)	165,760	861
root-rollup	50.5 (+1%)	4,359	725
private-kernel-inner	319 (+3%)	73,794	28,214
public-kernel-app-logic	129 (+2%)	35,251	28,217
public-kernel-tail	174 (+3%)	40,928	28,217
merge-rollup	8.20 (-10%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+2%)	16.1 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.587 (+1%)	0.497 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.3 (+3%)	72.4 (+1%)	237	448 (+1%)	868 (+2%)	1,717 (+4%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.485 (+3%)	0.447 (+1%)	0.432	0.419	0.414 (+2%)	0.413 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	55.1 (+3%)	107 (+2%)	341 (+1%)	668 (+1%)	1,303 (+2%)	2,604 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.487 (+3%)	0.482 (+2%)	0.465 (+1%)	0.460 (+1%)	0.454 (+2%)	0.454 (+4%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	65.8 (+9%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.576 (+8%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,966	494,914

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,765 (+14%)	1,440 (+3%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	17.9 (+21%)	747 (+3%)

[LHerskind]

Looks good. Thanks for fixing this.

[benesjan]

Merge activity

• Mar 26, 1:28 PM EDT: @benesjan started a stack merge that includes this pull request via Graphite.