Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Network release branch into master #5184

Closed
wants to merge 17 commits into from

Conversation

anton-evseev
Copy link
Contributor

Required two other PRs to get merged first:

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

MikhailTryakhov and others added 15 commits January 3, 2019 16:49
* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008)

* Update ddosCustomPolicy.json in 2018-12-01
* Added Prepare action documentation

* Took carte of the errors from the validation tool

* Error fixes from validation tool

* Adding a typo and a missing property
* Changes in the existing APIs result format.

* adding proxyresource to server variables APIs result

* Updating applicationgateway.json

* Update applicationGateway.json

* add Go SDK build for 2018-12-01

* changes to pythonand ruby readme files

* Update readme.ruby.md

* adding jave readme changes

* Minor Fix in spacing

* Creating a new tag for 2018-12 version

* Update readme.python.md

* Update applicationGateway.json

* fixing examples

* examples
@anton-evseev
Copy link
Contributor Author

@MikhailTryakhov please resolved merge conflicts, I don't have write access

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1174

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2216

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4341

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4062

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4665

@AutorestCI
Copy link

AutorestCI commented Feb 11, 2019

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', branch_name, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

* Fixed issue: #4721

* Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01
* Threat Intel changes for Azure Firewall

* Move the property to the end of the list
"description": "The name of the gateway."
},
{
"$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provisisoning -> provisioning

"description": "The name of the gateway."
},
{
"$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double word "for"

"description": "The name of the gateway."
},
{
"$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vpnclients -> VPN clients'

"$ref": "./examples/VpnSiteGet.json"
}
},
"description": "Retrieves the details of a VPNsite.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPNsite -> VPN site

],
"responses": {
"200": {
"description": "Request successful. The operation returns a list of ExpressRouteCrossConnection resources. If there are no crossconnection resources an empty list is returned.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crossconnection -> cross connection

],
"responses": {
"200": {
"description": "Request successful.The operation returns a list of ExpressRouteCrossConnection resources. If there are no crossconnection resources an empty list is returned.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crossconnection -> cross connection

],
"responses": {
"200": {
"description": "Request successful. The operation returns a list of ExpressRouteServiceProdiver resources.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpressRouteServiceProdiver -> ExpressRouteServiceProvider

"items": {
"type": "string"
},
"description": "The communities of bgp peering. Spepcified for microsoft peering"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spepcified -> Specified

"provisioningState": {
"type": "string",
"readOnly": true,
"description": "Provisioning state of the circuit connection resource. Possible values are: 'Succeded', 'Updating', 'Deleting', and 'Failed'."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeded -> Succeeded as long as the typo isn't in the enum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK code seems to override this prop with the one inherited from SubResource
https://github.com/Azure/azure-sdk-for-net/blob/master/src/SDKs/Network/Management.Network/Generated/Models/ExpressRouteCircuitConnection.cs#L52
I'll double check what the server returns

@anton-evseev
Copy link
Contributor Author

Closing in favor of #5189

@sergey-shandar sergey-shandar deleted the network-january-release branch April 19, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.