Chore: Missing some English translation keywords #20131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Jan 11, 2021
There was a problem hiding this comment.
thanks @Karting06 for your contribution.. most of the terms shouldn't be translated because they're actually names and not words.
@ggazzo I saw most of those missing keywords were recently added during the React rewrite. can you please make sure to always add the keys to the English translation files as well? thx
|
Yeah, I know those terms. |
|
Hi @sampaiodiego, |
dougfabris
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jul 29, 2022
…ctor/locationModal * 'develop' of github.com:RocketChat/Rocket.Chat: i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336) [IMPROVE] Remove public and node_modules folders from TypeScript server watcher (#26391)
gabriellsh
added a commit
that referenced
this pull request
Aug 2, 2022
…history * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) [IMPROVE] validateParams to accept different validators per request method (#26357) Regression: Fix spacing problem on AppStatus component (#26421) Chore: Convert client/views/account/security folder to ts (#26413) i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336)
carlosrodrigues94
pushed a commit
that referenced
this pull request
Aug 3, 2022
Co-authored-by: dougfabris <devfabris@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add missing translation keys in
en.i18n.jsonto be able to translate them via Lingohub.Issue(s)
Those translation keys were missing from the English JSON which led to untranslated strings in other languages.
Steps to test or reproduce
Use Rocket.Chat in another language and notice the missing translations.
Further comments