Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Exclude private/public folders from typecheck #26399

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jul 28, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

On local, this run under 2G of ram, which was a surprise, but on pipe, it needs 4G at least

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #26399 (4b51c59) into develop (2ab6aa9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26399      +/-   ##
===========================================
- Coverage    38.94%   38.90%   -0.04%     
===========================================
  Files          751      751              
  Lines        18797    18797              
  Branches      1413     1413              
===========================================
- Hits          7320     7313       -7     
- Misses       11260    11267       +7     
  Partials       217      217              
Flag Coverage Δ
e2e 38.90% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/client/hooks/useReactiveVar.ts 90.00% <0.00%> (-10.00%) ⬇️
apps/meteor/client/lib/rooms/roomTypes/public.ts 40.00% <0.00%> (-5.72%) ⬇️
apps/meteor/client/lib/meteorCallWrapper.ts 96.42% <0.00%> (-3.58%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (-3.43%) ⬇️
...ached-collection/client/models/CachedCollection.js 85.93% <0.00%> (+0.52%) ⬆️
apps/meteor/client/lib/rooms/roomTypes/private.ts 26.47% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 29, 2022
@kodiakhq kodiakhq bot merged commit 910d12c into develop Jul 29, 2022
@kodiakhq kodiakhq bot deleted the chore/exclude-folders-from-typecheck branch July 29, 2022 17:37
gabriellsh added a commit that referenced this pull request Jul 29, 2022
…ctor/locationModal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
  [IMPROVE] Remove public and node_modules folders from TypeScript server watcher (#26391)
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants