Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Marketplace apps page new list view layout #26181

Merged
merged 21 commits into from
Jul 29, 2022

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Jul 7, 2022

Proposed changes (including videos or screenshots)

Refactored the layout of the marketplace list of apps, now it has a more minimalist and flexbox-based style. Also implemented a new status filter.

Demo gif:
new-app-list

ClickUp task:
https://app.clickup.com/t/1na7437

Issue(s)

Steps to test or reproduce

Further comments

rique223 added 2 commits July 4, 2022 17:44
…dability

Refactored the AppsTable component to make it easier to understand what's happening with the loading and filtering logic and to implement the first steps of the new marketplace apps list.
Refactored the table layout of the Marketplace's AppsTable to a Flex Layout, also changed the name from AppsTable to AppsList. Will be working on the UX that was lost during refactoring and on the AppsRow next.
rique223 added 14 commits July 7, 2022 21:08
Finished the styling and UX of the new flex based layout for the MarketplaceRow component
Refactored the AppRow component to the new flex list view layout. While at that I've also merged MarketplaceRow on AppRow to avoid duplicated code. Also implemented an animated tooltip that opens on hover on the AppStatus component and inserted the bundledChips component on the AppRow.
Fixed the spacing for the AppStatus on the App List view, fixed some missing translation entries for the AppStatus and fixed a missrender of the DataBadge component on the Apps screen
Implemented a filter that filters apps based on their status, if it is Enabled or Disabled. Also solved some minor bugs, removed unnecessary code, solved UI inaccuracies and added missing translation keys to the i18n.
Implemented mediaQueries and necessary verifications to make sure the marketplace screen works properly on mobile screens.
Removed the hover and focus from the AppStatus now it is always visible, also refactored the AppStatus buttons to fit better with the figma design.
Included the Trial period and config needed/failed cases to the new status filter. Trial period is shown on enabled filtering and the other two are shown on disabled filtering.
…at/Rocket.Chat into feat/marketplace-apps-list-view
@rique223 rique223 marked this pull request as ready for review July 19, 2022 16:40
@rique223 rique223 requested review from a team as code owners July 19, 2022 16:40
@rique223 rique223 requested a review from ggazzo July 19, 2022 16:41
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 20, 2022
@casalsgh casalsgh added this to the 5.1.0 milestone Jul 25, 2022
@casalsgh casalsgh requested a review from PedroRorato July 26, 2022 16:12
Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 6d4f021 into develop Jul 29, 2022
@kodiakhq kodiakhq bot deleted the feat/marketplace-apps-list-view branch July 29, 2022 16:32
gabriellsh added a commit that referenced this pull request Jul 29, 2022
…ctor/locationModal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
  [IMPROVE] Remove public and node_modules folders from TypeScript server watcher (#26391)
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: apps ecosystem AECO stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants