-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Marketplace apps page new list view layout #26181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dability Refactored the AppsTable component to make it easier to understand what's happening with the loading and filtering logic and to implement the first steps of the new marketplace apps list.
Refactored the table layout of the Marketplace's AppsTable to a Flex Layout, also changed the name from AppsTable to AppsList. Will be working on the UX that was lost during refactoring and on the AppsRow next.
Finished the styling and UX of the new flex based layout for the MarketplaceRow component
Refactored the AppRow component to the new flex list view layout. While at that I've also merged MarketplaceRow on AppRow to avoid duplicated code. Also implemented an animated tooltip that opens on hover on the AppStatus component and inserted the bundledChips component on the AppRow.
Fixed the spacing for the AppStatus on the App List view, fixed some missing translation entries for the AppStatus and fixed a missrender of the DataBadge component on the Apps screen
Implemented a filter that filters apps based on their status, if it is Enabled or Disabled. Also solved some minor bugs, removed unnecessary code, solved UI inaccuracies and added missing translation keys to the i18n.
Implemented mediaQueries and necessary verifications to make sure the marketplace screen works properly on mobile screens.
Removed the hover and focus from the AppStatus now it is always visible, also refactored the AppStatus buttons to fit better with the figma design.
Included the Trial period and config needed/failed cases to the new status filter. Trial period is shown on enabled filtering and the other two are shown on disabled filtering.
…at/Rocket.Chat into feat/marketplace-apps-list-view
PedroRorato
reviewed
Jul 26, 2022
PedroRorato
reviewed
Jul 26, 2022
PedroRorato
approved these changes
Jul 29, 2022
thassiov
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gabriellsh
added a commit
that referenced
this pull request
Jul 29, 2022
…ctor/locationModal * 'develop' of github.com:RocketChat/Rocket.Chat: i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336) [IMPROVE] Remove public and node_modules folders from TypeScript server watcher (#26391)
gabriellsh
added a commit
that referenced
this pull request
Aug 2, 2022
…history * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) [IMPROVE] validateParams to accept different validators per request method (#26357) Regression: Fix spacing problem on AppStatus component (#26421) Chore: Convert client/views/account/security folder to ts (#26413) i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336)
carlosrodrigues94
pushed a commit
that referenced
this pull request
Aug 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
squad: apps ecosystem
AECO
stat: QA skipped
stat: ready to merge
PR tested and approved waiting for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Refactored the layout of the marketplace list of apps, now it has a more minimalist and flexbox-based style. Also implemented a new status filter.
Demo gif:
ClickUp task:
https://app.clickup.com/t/1na7437
Issue(s)
Steps to test or reproduce
Further comments