Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Change text of buttons tooltips on custom content homepage block #28094

Merged
merged 6 commits into from
Mar 2, 2023

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Feb 17, 2023

Proposed changes (including videos or screenshots)

Show to workspace Button:

  • No custom content added:

“This action will become available after the custom content has been added”

  • W/ custom content:

"Not it's visible for everyone"
"Not it's visible only for admins"


Show only this content Button:

  • if CE → “Enterprise only”
  • if EE and disabled → "This action will become available after the custom content has been added and made visible to everyone”
  • if EE and enabled → “It will hide…" or “It will show…"

Issue(s)

Steps to test or reproduce

Further comments

TC-489

@guijun13 guijun13 changed the title Chore: Change text of buttons tooltips Chore: Change text of buttons tooltips on custom content homepage block Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #28094 (994154b) into develop (bd17450) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28094      +/-   ##
===========================================
+ Coverage    44.87%   44.90%   +0.02%     
===========================================
  Files          766      766              
  Lines        14894    14903       +9     
  Branches      2068     2070       +2     
===========================================
+ Hits          6684     6692       +8     
  Misses        7917     7917              
- Partials       293      294       +1     
Flag Coverage Δ
e2e 44.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@guijun13 guijun13 marked this pull request as ready for review February 22, 2023 18:25
@guijun13 guijun13 requested a review from a team as a code owner February 22, 2023 18:25
@guijun13 guijun13 added this to the 6.0.0 milestone Feb 28, 2023
@ggazzo ggazzo changed the title Chore: Change text of buttons tooltips on custom content homepage block Regression: Change text of buttons tooltips on custom content homepage block Mar 2, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 2, 2023
@ggazzo ggazzo merged commit df9d2d2 into develop Mar 2, 2023
@ggazzo ggazzo deleted the fix/homepage-tooltips branch March 2, 2023 04:42
gabriellsh added a commit that referenced this pull request Mar 6, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Apps provider not handling apps lists correctly (#28264)
  Regression: Fix intermitent apps engine startup (#28254)
  Regression: Client is not loading new settings from server (#28248)
  Regression: Adjusted departments upsell modal to check for licence and modules (#28246)
  Regression: message-parse version update (#28245)
  [FIX] Notify apps engine event through ms api (#28169)
  Chore: Add extra stats for omnichannel video calling (#28211)
  Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233)
  Regression: Change text of buttons tooltips on custom content homepage block (#28094)
  Regression: run clientMessageRecieved hooks on thread main message (#27962)
  Regression: Jump to message not working (#28163)
  Regression: Hide price and category filters when inside of private apps page (#28188)
  [BREAK] Remove support to deprecated typing event (#28234)
  Regression: Fix app status filter not working in private apps page (#28198)
  Regression: UiKit message surface styles (#28213)
  [FIX] Search list missing key parameter (#28230)
  Regression: broken message exhibition when edited (#28180)
  Regression: EnableUnlimitedApps button action (#28221)
  Regression: Update Composer Formatters Translation Keys (#28228)
  Regression: EmojiPicker missing shadow on dark mode (#28236)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants