Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Client is not loading new settings from server #28248

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #28248 (f61c45a) into develop (fd33a0f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head f61c45a differs from pull request most recent head 3883550. Consider uploading reports for the commit 3883550 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28248      +/-   ##
===========================================
- Coverage    44.88%   44.86%   -0.03%     
===========================================
  Files          771      771              
  Lines        14984    14984              
  Branches      2090     2091       +1     
===========================================
- Hits          6726     6723       -3     
- Misses        7959     7962       +3     
  Partials       299      299              
Flag Coverage Δ
e2e 44.82% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.0.0 milestone Mar 2, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 2, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 2, 2023
@ggazzo ggazzo merged commit d62dec3 into develop Mar 3, 2023
@ggazzo ggazzo deleted the fix/client-not-getting-new-settings branch March 3, 2023 02:26
gabriellsh added a commit that referenced this pull request Mar 6, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Apps provider not handling apps lists correctly (#28264)
  Regression: Fix intermitent apps engine startup (#28254)
  Regression: Client is not loading new settings from server (#28248)
  Regression: Adjusted departments upsell modal to check for licence and modules (#28246)
  Regression: message-parse version update (#28245)
  [FIX] Notify apps engine event through ms api (#28169)
  Chore: Add extra stats for omnichannel video calling (#28211)
  Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233)
  Regression: Change text of buttons tooltips on custom content homepage block (#28094)
  Regression: run clientMessageRecieved hooks on thread main message (#27962)
  Regression: Jump to message not working (#28163)
  Regression: Hide price and category filters when inside of private apps page (#28188)
  [BREAK] Remove support to deprecated typing event (#28234)
  Regression: Fix app status filter not working in private apps page (#28198)
  Regression: UiKit message surface styles (#28213)
  [FIX] Search list missing key parameter (#28230)
  Regression: broken message exhibition when edited (#28180)
  Regression: EnableUnlimitedApps button action (#28221)
  Regression: Update Composer Formatters Translation Keys (#28228)
  Regression: EmojiPicker missing shadow on dark mode (#28236)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants