Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Apps provider not handling apps lists correctly #28264

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Mar 3, 2023

Proposed changes (including videos or screenshots)

Jira tasks: MKP-272 MKP-270

Fixed a bug in which the AppsProvider would not handle the marketplace, installed, and private apps lists correctly when running the install, update, and delete listeners. This also solved related bugs of app duplication during installation and loss of reactivity during uninstalls and status changes(private apps only).
Demo gif: apps-provider-behavior

Issue(s)

Steps to test or reproduce

Further comments

Fixed a bug in which the AppsProvider would not handle the marketplace, installed and private apps lists correctly when running the install, update and delete listeners. This also solved related bugs of app duplication during installation and loss of reactivity during uninstalls and status changes(private apps only)
@casalsgh casalsgh added this to the 6.0.0 milestone Mar 3, 2023
@casalsgh casalsgh marked this pull request as ready for review March 3, 2023 21:39
@casalsgh casalsgh requested a review from a team as a code owner March 3, 2023 21:39
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this on the condition that we get the rewrite of this file on the backlog of an upcoming sprint.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #28264 (016d53a) into develop (5e6015e) will increase coverage by 5.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28264      +/-   ##
===========================================
+ Coverage    39.62%   44.84%   +5.22%     
===========================================
  Files          750      771      +21     
  Lines        14765    14984     +219     
  Branches      2053     2091      +38     
===========================================
+ Hits          5850     6720     +870     
+ Misses        8639     7967     -672     
- Partials       276      297      +21     
Flag Coverage Δ
e2e 44.80% <ø> (+5.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 4, 2023
@kodiakhq kodiakhq bot merged commit 0e969e9 into develop Mar 4, 2023
@kodiakhq kodiakhq bot deleted the regression/apps-provider-behavior branch March 4, 2023 03:43
gabriellsh added a commit that referenced this pull request Mar 6, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Apps provider not handling apps lists correctly (#28264)
  Regression: Fix intermitent apps engine startup (#28254)
  Regression: Client is not loading new settings from server (#28248)
  Regression: Adjusted departments upsell modal to check for licence and modules (#28246)
  Regression: message-parse version update (#28245)
  [FIX] Notify apps engine event through ms api (#28169)
  Chore: Add extra stats for omnichannel video calling (#28211)
  Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233)
  Regression: Change text of buttons tooltips on custom content homepage block (#28094)
  Regression: run clientMessageRecieved hooks on thread main message (#27962)
  Regression: Jump to message not working (#28163)
  Regression: Hide price and category filters when inside of private apps page (#28188)
  [BREAK] Remove support to deprecated typing event (#28234)
  Regression: Fix app status filter not working in private apps page (#28198)
  Regression: UiKit message surface styles (#28213)
  [FIX] Search list missing key parameter (#28230)
  Regression: broken message exhibition when edited (#28180)
  Regression: EnableUnlimitedApps button action (#28221)
  Regression: Update Composer Formatters Translation Keys (#28228)
  Regression: EmojiPicker missing shadow on dark mode (#28236)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants